A patch for Speakup?

A patch for Speakup?

[Jean-Philippe MENGUAL]

Hi,

You will find on http://dl.free.fr/pmthtsxVp a patch I suggest, where I did some important
changes to add French for Speakup.
1. All the user guide is translated.
2. This guide and translation are completed (section 14, I divided 14.2
with 14.2.1 and 14.2.2 and 14.2.3, 14.2.2 explains how to change the
language, in the French version it explains how to have Speakup in
French).
3. speakupmap.map: I added comments to detail the function (to be more
explicit for any user, I did this in speakmapfr.map (I can do this in
English if you want, but it's less useful as names of functions say what
necessary). I guess there's a better solution but I don't know yet.
4. Add of a new directory in the root of tree: named locales, it
contains config files for French (iso and utf8) and English locales (if
a user wants to come back). They are files to copy in /sys system, but a
script does this (see follow).
5. Add of a shell script which allows to change the language: the user
has to enter the number for his language (precised in the list of the
screen). So far only French and English are available, but the script
can be easily completed with other languages.

Could you tell me if:
1. You're interested and will add this patch on the main trunk?
2. If someone wants to do a review of the translations, it's a good idea
(especially the user guide). It's a short work I think.
3. You want to put online the user guide translated?

I followed the project of "future" mentioned in the manual. I hope it's
a good idea. I wait for your agreement for this patch and waiting, and
anyway, I'll put it online on a Traduc.org server to make it available
for users who want to have it easily.

Thanks for your answer.

Regards,


Jean-Philippe MENGUAL

Re: A patch for Speakup?

[Samuel Thibault]

Hello,

Jean-Philippe MENGUAL, le Sun 05 Sep 2010 23:55:58 +0200, a écrit :
> 5. Add of a shell script which allows to change the language: the user
> has to enter the number for his language (precised in the list of the
> screen). So far only French and English are available, but the script
> can be easily completed with other languages.

This seems to be missing.

> 1. You're interested and will add this patch on the main trunk?

I'll probably commit this after review, yes.

> 3. You want to put online the user guide translated?

I'd probably be a good idea, with automatic selection through apache
language selection.

Samuel

Re: A patch for Speakup?

[Jean-Philippe MENGUAL]

Hi, :)

Le dimanche 12 septembre 2010 à 01:35 +0200, Samuel Thibault a écrit :
> Hello,

> This seems to be missing.
Indeed. I did again the patch: http://dl.free.fr/t9HocSwKo
Tell me if it's full (I hope). I did a mistake because trying patching a soft and learning git at the same time... hard :D git commit doesn't complain at all anymore (clean directory)

> > 1. You're interested and will add this patch on the main trunk?
> 
> I'll probably commit this after review, yes.
Very cool. I'm happy. This patch is designed to be extensible to other languages. If this suits, I'll see how I can add spanish and italian (but won't translate manual for these languages). Tell me what you think about patch (if you fixed something, if we could do better...). Especially, speakup.map, I don't know exactly what coule be done with it related languages, I tried something, answer would be useful.

> > 3. You want to put online the user guide translated?
> 
> I'd probably be a good idea, with automatic selection through apache
> language selection.
I let you do this. Yes I think too it's a good way. Doc should be reviewed a little I think, even if I have not much doubts about contents.
Regards,

> Samuel
> _______________________________________________
> Speakup mailing list
> Speakup@braille.uwo.ca
> http://speech.braille.uwo.ca/mailman/listinfo/speakup
Jean-Philippe MENGUAL

Re: A patch for Speakup?

[Jean-Philippe MENGUAL]

oops sorry, I forgot something: note that I added, in French and English
guides, at chapter 14, instructions to choose another languages (in
French guide, instructions to translate into French; in English, general
instructions), cf. sections 14.2 and 14.3). And I forgot to fix an
English word: untar has to be replaced with unpack of course in English
guide.

Sorry,

Regards,

Jean-Philippe MENGUAL


Le dimanche 12 septembre 2010 à 03:47 +0200, Jean-Philippe MENGUAL a
écrit :
> Hi, :)
> 
> Le dimanche 12 septembre 2010 à 01:35 +0200, Samuel Thibault a écrit :
> > Hello,
> 
> > This seems to be missing.
> Indeed. I did again the patch: http://dl.free.fr/t9HocSwKo
> Tell me if it's full (I hope). I did a mistake because trying patching a soft and learning git at the same time... hard :D git commit doesn't complain at all anymore (clean directory)
> 
> > > 1. You're interested and will add this patch on the main trunk?
> > 
> > I'll probably commit this after review, yes.
> Very cool. I'm happy. This patch is designed to be extensible to other languages. If this suits, I'll see how I can add spanish and italian (but won't translate manual for these languages). Tell me what you think about patch (if you fixed something, if we could do better...). Especially, speakup.map, I don't know exactly what coule be done with it related languages, I tried something, answer would be useful.
> 
> > > 3. You want to put online the user guide translated?
> > 
> > I'd probably be a good idea, with automatic selection through apache
> > language selection.
> I let you do this. Yes I think too it's a good way. Doc should be reviewed a little I think, even if I have not much doubts about contents.
> Regards,
> 
> > Samuel
> > _______________________________________________
> > Speakup mailing list
> > Speakup@braille.uwo.ca
> > http://speech.braille.uwo.ca/mailman/listinfo/speakup
> Jean-Philippe MENGUAL
> 
> 
> 
> _______________________________________________
> Speakup mailing list
> Speakup@braille.uwo.ca
> http://speech.braille.uwo.ca/mailman/listinfo/speakup

Re: A patch for Speakup?

[Samuel Thibault]

Hello,

Jean-Philippe MENGUAL, le Sun 05 Sep 2010 23:55:58 +0200, a écrit :
> You will find on http://dl.free.fr/pmthtsxVp a patch I suggest, where I did some important
> changes to add French for Speakup.

I have applied most of it, except speakupmapfr.map, for which I believe
the documentation of keypresses should be made indepent of the key
assignment.

Samuel

Re: A patch for Speakup?

[Jean-Philippe MENGUAL]

Hi,

Le dimanche 17 octobre 2010 à 18:29 +0200, Samuel Thibault a écrit :
> Hello,
> 
> I have applied most of it, except speakupmapfr.map, for which I believe
> the documentation of keypresses should be made indepent of the key
> assignment.
Great! Thanks I'm very pleased. What do you think we could do for keys assigments? Let the manual as it is and translate as I did, while letting speakupmap.map in its original state? Documenting differently the assignments? I think I could write differently the layout of documentation about assignments, in French and in English.

2 things I saw in the manual. First, I read that locales parameters for speakup only work after login. In my case, it worked immediately at the starting (even if with voxin I don't have accents). So are you sure of what is written? Is it due to your changes, in particular in the script? If I wrote this myself, it should be fixed.

Moreover, shouldn't be online this translation, as the English guide?

Actually I suggest a fix from your decision about speakupmap.map: in the translation of guide, instead of "est issue du fichier speakupmap.map", I suggest write "S'appuie sur le fichier" since it's a translation and because there are comments (French after # ) which don't exist in the English file.

I wait for your ideas about this.

Regards,

> Samuel
> _______________________________________________
> Speakup mailing list
> Speakup@braille.uwo.ca
> http://speech.braille.uwo.ca/mailman/listinfo/speakup
Jean-Philippe MENGUAL

Re: A patch for Speakup?

[Samuel Thibault]

Jean-Philippe MENGUAL, le Wed 20 Oct 2010 16:00:09 +0200, a écrit :
> Great! Thanks I'm very pleased. What do you think we could do for keys assigments? Let the manual as it is and translate as I did, while letting speakupmap.map in its original state? Documenting differently the assignments?

The description of keys should probably go to the manual, while the
assignement would be in a language neutral file.

> 2 things I saw in the manual. First, I read that locales parameters for speakup only work after login. In my case, it worked immediately at the starting (even if with voxin I don't have accents). So are you sure of what is written?

I don't know, I haven't written it.

> Is it due to your changes, in particular in the script? If I wrote this myself, it should be fixed.

I believe you wrote it yourself, so send patches :)

> Moreover, shouldn't be online this translation, as the English guide?

Sure, but I'm not webmaster.

> Actually I suggest a fix from your decision about speakupmap.map: in the translation of guide, instead of "est issue du fichier speakupmap.map", I suggest write "S'appuie sur le fichier" since it's a translation and because there are comments (French after # ) which don't exist in the English file.

Fixed.

Samuel

Re: A patch for Speakup?

[Christopher Brannon]

Samuel Thibault <samuel.thibault@ens-lyon.org> writes:

>> Moreover, shouldn't be online this translation, as the English guide?
>
> Sure, but I'm not webmaster.

The website is maintained in git, in the speakup-web repo.
I think that you have commit privileges, but I'm not sure.  Kirk would
know.  In any case, I'll add this to the site.

-- Chris

Re: A patch for Speakup?

[William Hubbs]

On Wed, Oct 20, 2010 at 10:29:53AM -0500, Christopher Brannon wrote:
> Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
> 
> >> Moreover, shouldn't be online this translation, as the English guide?
> >
> > Sure, but I'm not webmaster.
> 
> The website is maintained in git, in the speakup-web repo.
> I think that you have commit privileges, but I'm not sure.  Kirk would
> know.  In any case, I'll add this to the site.

Actually I don't think we can do that because the site documents the
most recent stable version of speakup not what is in git.

To make it correct, we need to translate the manual that is in the
speakup-3.1.6 tarball and put that translation on the site, not the one
in git.

William

Re: A patch for Speakup?

[Jean-Philippe MENGUAL]

Ok I do this tonight. There are not a lot of differences. Then I'll
patch my 1st write (English and French) about locales.

Regards,

Jean-Philippe MENGUAL


Le mercredi 20 octobre 2010 à 10:49 -0500, William Hubbs a écrit :
> On Wed, Oct 20, 2010 at 10:29:53AM -0500, Christopher Brannon wrote:
> > Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
> > 
> > >> Moreover, shouldn't be online this translation, as the English guide?
> > >
> > > Sure, but I'm not webmaster.
> > 
> > The website is maintained in git, in the speakup-web repo.
> > I think that you have commit privileges, but I'm not sure.  Kirk would
> > know.  In any case, I'll add this to the site.
> 
> Actually I don't think we can do that because the site documents the
> most recent stable version of speakup not what is in git.
> 
> To make it correct, we need to translate the manual that is in the
> speakup-3.1.6 tarball and put that translation on the site, not the one
> in git.
> 
> William
> 
> _______________________________________________
> Speakup mailing list
> Speakup@braille.uwo.ca
> http://speech.braille.uwo.ca/mailman/listinfo/speakup

Re: A patch for Speakup?

[Jean-Philippe MENGUAL]

Hi,

As I thought, the only difference between stable and git guide is what I
wrote myself. Here's the patch:
http://dl.free.fr/aPgOVCofz

For the assigments, I found the perfect file: DefaultKeyAssignments.
I'll translate it, change the guide to refer to it instead of pasting
speakupmap.map, and submit (tell me if you disagree). I assume this file
contains the same information as speakupmap.map (in a different form).
Some fixes of guide will come in the next mail. I wanted first to fix
the French guide in order to put online this release.


Regards,

Jean-Philippe MENGUAL


Le mercredi 20 octobre 2010 à 10:49 -0500, William Hubbs a écrit :
> On Wed, Oct 20, 2010 at 10:29:53AM -0500, Christopher Brannon wrote:
> > Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
> > 
> > >> Moreover, shouldn't be online this translation, as the English guide?
> > >
> > > Sure, but I'm not webmaster.
> > 
> > The website is maintained in git, in the speakup-web repo.
> > I think that you have commit privileges, but I'm not sure.  Kirk would
> > know.  In any case, I'll add this to the site.
> 
> Actually I don't think we can do that because the site documents the
> most recent stable version of speakup not what is in git.
> 
> To make it correct, we need to translate the manual that is in the
> speakup-3.1.6 tarball and put that translation on the site, not the one
> in git.
> 
> William
> 
> _______________________________________________
> Speakup mailing list
> Speakup@braille.uwo.ca
> http://speech.braille.uwo.ca/mailman/listinfo/speakup

Re: A patch for Speakup?

[William Hubbs]

Hi,

On Thu, Oct 21, 2010 at 12:27:38AM +0200, Jean-Philippe MENGUAL wrote:
> Hi,
> 
> As I thought, the only difference between stable and git guide is what I
> wrote myself. Here's the patch:
> http://dl.free.fr/aPgOVCofz

I could not figure out where to pull the patch from this link, can you
post it as a patch instead?

I'm guessing this is a patch which will bring the git French translation
back to match the stable French translation right?

Thanks,

William

Re: A patch for Speakup?

[Jean-Philippe MENGUAL]

Le jeudi 21 octobre 2010 à 17:59 -0500, William Hubbs a écrit :
> Hi,
Hi,

> On Thu, Oct 21, 2010 at 12:27:38AM +0200, Jean-Philippe MENGUAL wrote:
> > Hi,
> 
> I could not figure out where to pull the patch from this link, can you
> post it as a patch instead?
I don't understand. It's a patch. A diff from the original French translation and my recent changes. I sent it to mailing list as attached file but was "waiting for moderation". How can I send it so? Private mail as attached?

> I'm guessing this is a patch which will bring the git French translation
> back to match the stable French translation right?
Exactly. If you apply it on the current spkguidefr.txt, you'll get the spkguidefr.txt for stable release of speakup.

> Thanks,
You're welcome,

> William
> 
> _______________________________________________
> Speakup mailing list
> Speakup@braille.uwo.ca
> http://speech.braille.uwo.ca/mailman/listinfo/speakup
Jean-Philippe MENGUAL