* synth not removed from synths[] on failure
@ Okash Khawaja
` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Okash Khawaja @ UTC (permalink / raw)
To: Speakup is a screen review system for Linux.
Hi,
In synth.c synths[] array caches currently loaded synths. It is checked
when adding new synths. The synth_add function adds new synth to
synths[] before taking into account the result of do_synth_init. So if
do_synth_init fails, the failed synth remains cached in synths[]. Next
time user loads same synth which failed last time, it will succeed.
Adding the synth after do_synth_init succeeds seems like right solution
to me. Let me know if I have missed something here. Will be sending a
patch later.
Thanks,
Okash
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: synth not removed from synths[] on failure
synth not removed from synths[] on failure Okash Khawaja
@ ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ UTC (permalink / raw)
To: Okash Khawaja; +Cc: Speakup is a screen review system for Linux.
Okash Khawaja, on dim. 18 juin 2017 11:08:39 +0100, wrote:
> So if do_synth_init fails, the failed synth remains cached in
> synths[]. Next time user loads same synth which failed last time, it
> will succeed.
Oops :)
Samuel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~ UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
synth not removed from synths[] on failure Okash Khawaja
` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).