From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 14BBD1F0343; Sun, 18 Jun 2017 06:08:44 -0400 (EDT) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) by befuddled.reisers.ca (Postfix) with ESMTPS id 3186D1F0322 for ; Sun, 18 Jun 2017 06:08:43 -0400 (EDT) Received: by mail-wm0-x235.google.com with SMTP id d73so52443228wma.0 for ; Sun, 18 Jun 2017 03:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=kMDJIx9V/KwQYPIjcvrS5yaPSQsPwCjZZAJMgsE2VcU=; b=i24oQGSwLdUWrgssmucZ3jzBio9uhsFhkWNkQWomiLsnrtozfOjVuTq042mOmNjFD2 Njngizol2mA4RB02TQv/PJnHib8JF9B9MkqYXGWkx3F8ydW0p+Apo9+LNJcMoA/gdttJ udrhNB/oMVpM4+WkAFzI2vtxFyvZ0LLZJfOtfKj6lUfuC+l6zo5EO8xfCJ5SB3v57g6/ TBjSNhA9sh8Z2tMsphZEPbqkczVRc6de8uXCjAayA9GSEa+LkL5T5OnDpNLiWkpPZNTB +rD8YcLycJcxsy+zg8H6yp0yvPYlQrYtALaTDba28xBuA+aFFxCsQ8Cy6qg+ZwFgU6sK pXLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=kMDJIx9V/KwQYPIjcvrS5yaPSQsPwCjZZAJMgsE2VcU=; b=LBK+8WsjWkC9c9Z1sYAwoybDTj9G+wLpZ4Xz6p0wSX44G96we1zU1A0U0tDOcdHzZA xYXYUXe9n/BMN+kd3ZBjZEYOIE2a4NeFm2zHLYh2vDEuxQFVV/L+WP2Te+QwDXujlihy TVOhqxOy4SEovo/i+K3HmYunuo0eGoZJc0leAziQqUu6c/JhazNvOQQbI+DnwybWkKCR PT9UoP6kPtZV5nZX23LAd76UgEQYZmGVt+IXvG7vS3HVhEPULA+h0luL/OBjn1Rc1LUM hR0SNmbUFtoaN08y164kFDtPTZeH9c6z01cBJbcqcFS2uD/SAoYj9uIvSWcGbsBKlOWS cpEg== X-Gm-Message-State: AKS2vOwhlEXy3gZm0wZaOrmvrFGxu9ARMnsWC5azhVfEAFKyMPD/4YQu yg6WWp28hAk+a0CxvdY= X-Received: by 10.28.139.201 with SMTP id n192mr12130752wmd.84.1497780521953; Sun, 18 Jun 2017 03:08:41 -0700 (PDT) Received: from sanghar ([2a00:23c4:7320:5900:224:d6ff:fe76:7136]) by smtp.gmail.com with ESMTPSA id r40sm12202055wrb.37.2017.06.18.03.08.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Jun 2017 03:08:41 -0700 (PDT) Date: Sun, 18 Jun 2017 11:08:39 +0100 From: Okash Khawaja To: "Speakup is a screen review system for Linux." Subject: synth not removed from synths[] on failure Message-ID: <20170618100839.GA10536@sanghar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.8.2 (2017-04-18) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 10:08:45 -0000 Hi, In synth.c synths[] array caches currently loaded synths. It is checked when adding new synths. The synth_add function adds new synth to synths[] before taking into account the result of do_synth_init. So if do_synth_init fails, the failed synth remains cached in synths[]. Next time user loads same synth which failed last time, it will succeed. Adding the synth after do_synth_init succeeds seems like right solution to me. Let me know if I have missed something here. Will be sending a patch later. Thanks, Okash