From: Okash Khawaja <okash.khawaja@gmail.com>
To: "Speakup is a screen review system for Linux."
<speakup@linux-speakup.org>
Subject: synth not removed from synths[] on failure
Date: Sun, 18 Jun 2017 11:08:39 +0100 [thread overview]
Message-ID: <20170618100839.GA10536@sanghar> (raw)
Hi,
In synth.c synths[] array caches currently loaded synths. It is checked
when adding new synths. The synth_add function adds new synth to
synths[] before taking into account the result of do_synth_init. So if
do_synth_init fails, the failed synth remains cached in synths[]. Next
time user loads same synth which failed last time, it will succeed.
Adding the synth after do_synth_init succeeds seems like right solution
to me. Let me know if I have missed something here. Will be sending a
patch later.
Thanks,
Okash
next reply other threads:[~ UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
Okash Khawaja [this message]
` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170618100839.GA10536@sanghar \
--to=okash.khawaja@gmail.com \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).