* Re: [PATCH 3/5] staging: speakup: refactor spk_stop_serial_interrupt
@ Okash Khawaja
` Samuel Thibault
0 siblings, 1 reply; 3+ messages in thread
From: Okash Khawaja @ UTC (permalink / raw)
To: Speakup is a screen review system for Linux.
This moves the call to spk_stop_serial_interrupt() function into
release() method of respective synths.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/5] staging: speakup: refactor spk_stop_serial_interrupt
[PATCH 3/5] staging: speakup: refactor spk_stop_serial_interrupt Okash Khawaja
@ ` Samuel Thibault
` Okash Khawaja
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Thibault @ UTC (permalink / raw)
To: Okash Khawaja; +Cc: Speakup is a screen review system for Linux.
Okash Khawaja, on Wed 08 Feb 2017 22:51:15 +0000, wrote:
> This moves the call to spk_stop_serial_interrupt() function into
> release() method of respective synths.
Again, you need to say the "why": we don't want to hardcode calling
spk_stop_serial_interrupt() in synth_release(), and we don't actually
need to make it a method, making the release method call it is fine
enough.
Samuel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/5] staging: speakup: refactor spk_stop_serial_interrupt
` Samuel Thibault
@ ` Okash Khawaja
0 siblings, 0 replies; 3+ messages in thread
From: Okash Khawaja @ UTC (permalink / raw)
To: Samuel Thibault; +Cc: Speakup is a screen review system for Linux.
On Wed, Feb 8, 2017 at 11:04 PM, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
> Okash Khawaja, on Wed 08 Feb 2017 22:51:15 +0000, wrote:
>> This moves the call to spk_stop_serial_interrupt() function into
>> release() method of respective synths.
>
> Again, you need to say the "why": we don't want to hardcode calling
> spk_stop_serial_interrupt() in synth_release(), and we don't actually
> need to make it a method, making the release method call it is fine
> enough.
>
spk_stop_serial_interrupt() is not a method. release method calls it.
I think that's what I have said in the description. I'll add the
reason why.
> Samuel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~ UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[PATCH 3/5] staging: speakup: refactor spk_stop_serial_interrupt Okash Khawaja
` Samuel Thibault
` Okash Khawaja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).