From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <samuel.thibault@ens-lyon.org>
Received: by befuddled.reisers.ca (Postfix, from userid 65534)
 id 3E16C1F0B11; Wed,  8 Feb 2017 18:06:28 -0500 (EST)
Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a01:474::1])
 by befuddled.reisers.ca (Postfix) with ESMTP id BBEE41F052C
 for <speakup@linux-speakup.org>; Wed,  8 Feb 2017 18:04:40 -0500 (EST)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 357C3B732;
 Thu,  9 Feb 2017 00:04:40 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id uvGKsL1LpUsK; Thu,  9 Feb 2017 00:04:39 +0100 (CET)
Received: from var.youpi.perso.aquilenet.fr (unknown
 [IPv6:2a01:cb19:181:c200:3602:86ff:fe2c:6a19])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id A601D9ACE;
 Thu,  9 Feb 2017 00:04:39 +0100 (CET)
Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.88)
 (envelope-from <samuel.thibault@ens-lyon.org>)
 id 1cbbHx-0005pc-8T; Thu, 09 Feb 2017 00:04:37 +0100
Date: Thu, 9 Feb 2017 00:04:37 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: "Speakup is a screen review system for Linux." <speakup@linux-speakup.org>
Subject: Re: [PATCH 3/5] staging: speakup: refactor spk_stop_serial_interrupt
Message-ID: <20170208230437.GW2955@var.home>
References: 
 <CAOtcWM3+_MVf5poFgGDmPHDiapHDTz+QpeJ1fdJbK5TX3F+d2g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAOtcWM3+_MVf5poFgGDmPHDiapHDTz+QpeJ1fdJbK5TX3F+d2g@mail.gmail.com>
User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
X-BeenThere: speakup@linux-speakup.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Speakup is a screen review system for Linux."
 <speakup.linux-speakup.org>
List-Unsubscribe: <http://linux-speakup.org/cgi-bin/mailman/options/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=unsubscribe>
List-Archive: <http://linux-speakup.org/pipermail/speakup/>
List-Post: <mailto:speakup@linux-speakup.org>
List-Help: <mailto:speakup-request@linux-speakup.org?subject=help>
List-Subscribe: <http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Feb 2017 23:06:29 -0000

Okash Khawaja, on Wed 08 Feb 2017 22:51:15 +0000, wrote:
> This moves the call to spk_stop_serial_interrupt() function into
> release() method of respective synths.

Again, you need to say the "why": we don't want to hardcode calling
spk_stop_serial_interrupt() in synth_release(), and we don't actually
need to make it a method, making the release method call it is fine
enough.

Samuel