From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 4F0FF1F0B1F; Wed, 8 Feb 2017 18:10:31 -0500 (EST) Received: from mail-qk0-x232.google.com (mail-qk0-x232.google.com [IPv6:2607:f8b0:400d:c09::232]) by befuddled.reisers.ca (Postfix) with ESMTPS id 29F191F0B24 for ; Wed, 8 Feb 2017 18:10:16 -0500 (EST) Received: by mail-qk0-x232.google.com with SMTP id 11so139517484qkl.3 for ; Wed, 08 Feb 2017 15:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9uuxRRIXtT953ZI7WkPstr2MiKEhbVZlcdE4ANN8nF8=; b=ZRlRkwTonxBr6DCjK1bWhhZi8f3Hd5mhPRAktLhYpu8m/XfkMgxCwp63kOPu3Gbdp8 +e1lB3FRVF63hDyK79Ami+U0kBI4AuPswI7FDSkvEqSSHvhdZiZcFHzr1eaAmY9q+o20 aSfAcXm+r7xxEte28BrGo/lHksApes3Cx+xNgtNOKa4q03JVOwDCAB/TDE4oPin269fD +5atVlj6UvreodN0vvrN1ZTCcS+t9YB9taW88jotw7TSg/r5FqfMuOVm0Cc6v/KUyQiI lwOOdfg5y9GnN0RgKUFiUiwvEjchc264sDzx6LpRbycMAvQ5B1d+y+ao9RDmS4/DDGMN RI9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9uuxRRIXtT953ZI7WkPstr2MiKEhbVZlcdE4ANN8nF8=; b=lJ0+W8jxZkRac+1thEksWYLz/uwUNyoI0tgJom9VpSJW94ij99jqpC6Qc58PlOrFvW F+sKJ17PV4cUAnOgYpLMYZVTi2wegqj/kWhLyuAzNxgHxtmEnjK/XRZLiy4y6ZrGMpHo CHrU7lL8AsdoxnlfMlQm5zzS54wz7L1Yhlx+A1U/JsFXYg1Cu/CdT6R8OyK16t+a3k80 kKY+ndgslh+HorjT0bBZe34UApLEFpfyzjSfj3pt+1asA8IjzNm95rA3IZmOV+BlQBPv RkdQwyS+Bsi+5aG/olhjAMxEvQTQSNIk55XsAr5gJG1zmZZ9slovr/IKkjey2B+S7fPD nfOA== X-Gm-Message-State: AMke39lz9WzetlOi/9pIG1m3A3cEN570g0Y53TxF9er3Lu/QBsshFNmiKgcfC94RzSysJ4Y+ttplyHIMVCBPiw== X-Received: by 10.55.179.4 with SMTP id c4mr11127qkf.167.1486595415614; Wed, 08 Feb 2017 15:10:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.44.8 with HTTP; Wed, 8 Feb 2017 15:10:15 -0800 (PST) In-Reply-To: <20170208230437.GW2955@var.home> References: <20170208230437.GW2955@var.home> From: Okash Khawaja Date: Wed, 8 Feb 2017 23:10:15 +0000 Message-ID: Subject: Re: [PATCH 3/5] staging: speakup: refactor spk_stop_serial_interrupt To: Samuel Thibault Cc: "Speakup is a screen review system for Linux." Content-Type: text/plain; charset=UTF-8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Feb 2017 23:10:32 -0000 On Wed, Feb 8, 2017 at 11:04 PM, Samuel Thibault wrote: > Okash Khawaja, on Wed 08 Feb 2017 22:51:15 +0000, wrote: >> This moves the call to spk_stop_serial_interrupt() function into >> release() method of respective synths. > > Again, you need to say the "why": we don't want to hardcode calling > spk_stop_serial_interrupt() in synth_release(), and we don't actually > need to make it a method, making the release method call it is fine > enough. > spk_stop_serial_interrupt() is not a method. release method calls it. I think that's what I have said in the description. I'll add the reason why. > Samuel