speakup_setlocale concerns

speakup_setlocale concerns

[William Hubbs]

All,

I just looked this over and I have a couple of concerns about it.

The first is that the way it uses speakupconf save might be considered
broken, because, it doesn't allow me to specify which save directory I
want to use.  My suggestion for a solution to that would be to remove
the calls to speakupconf save from speakupconf_setlocale and just warn
the user that they need to use speakupconf save after running this
script.

Also, why not  make this part of speakupconf by adding another command
to it, like "speakupconf locale", which would check the LANG variable
and load the correct settings?  I think if we do that we can remove
speakup_setlocale entirely.

What do the rest of you think?

Thanks,

William

Re: speakup_setlocale concerns

[Steve Holmes]

Hey, if speakupconf can handle the additional feature without bloating
it too much, and if this results in eliminating another module or
script, then it's a good idea.  I think given a bit of explanation of
how the locale deal works, I could probably work it into speakupconf
unless someone else would rather do it.  I've never done anything with
locale stuff as I'm not an i18n sort of guy.

On Sun, Oct 17, 2010 at 05:44:12PM -0500, William Hubbs wrote:
> All,
> 
> I just looked this over and I have a couple of concerns about it.
> 
> The first is that the way it uses speakupconf save might be considered
> broken, because, it doesn't allow me to specify which save directory I
> want to use.  My suggestion for a solution to that would be to remove
> the calls to speakupconf save from speakupconf_setlocale and just warn
> the user that they need to use speakupconf save after running this
> script.
> 
> Also, why not  make this part of speakupconf by adding another command
> to it, like "speakupconf locale", which would check the LANG variable
> and load the correct settings?  I think if we do that we can remove
> speakup_setlocale entirely.
> 
> What do the rest of you think?
> 
> Thanks,
> 
> William
> 
> _______________________________________________
> Speakup mailing list
> Speakup@braille.uwo.ca
> http://speech.braille.uwo.ca/mailman/listinfo/speakup