From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-gw0-f42.google.com (mail-gw0-f42.google.com [74.125.83.42]) by speech.braille.uwo.ca (Postfix) with ESMTP id 4C4B3C1A386 for ; Sun, 17 Oct 2010 22:59:11 -0400 (EDT) Received: by gwb1 with SMTP id 1so163229gwb.29 for ; Sun, 17 Oct 2010 19:59:11 -0700 (PDT) Received: by 10.90.35.3 with SMTP id i3mr1564321agi.142.1287370749502; Sun, 17 Oct 2010 19:59:09 -0700 (PDT) Received: from lnx3.holmesgrown.com (ip72-208-185-148.ph.ph.cox.net [72.208.185.148]) by mx.google.com with ESMTPS id d15sm21131206ana.20.2010.10.17.19.59.07 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 17 Oct 2010 19:59:08 -0700 (PDT) Date: Sun, 17 Oct 2010 19:59:05 -0700 From: Steve Holmes To: speakup@braille.uwo.ca Subject: Re: speakup_setlocale concerns Message-ID: <20101018025905.GA21975@lnx3.holmesgrown.com> Mail-Followup-To: speakup@braille.uwo.ca References: <20101017224412.GA19219@linux1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101017224412.GA19219@linux1> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: speakup@braille.uwo.ca X-Mailman-Version: 2.1.13 Precedence: list Reply-To: "Speakup is a screen review system for Linux." List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2010 02:59:11 -0000 Hey, if speakupconf can handle the additional feature without bloating it too much, and if this results in eliminating another module or script, then it's a good idea. I think given a bit of explanation of how the locale deal works, I could probably work it into speakupconf unless someone else would rather do it. I've never done anything with locale stuff as I'm not an i18n sort of guy. On Sun, Oct 17, 2010 at 05:44:12PM -0500, William Hubbs wrote: > All, > > I just looked this over and I have a couple of concerns about it. > > The first is that the way it uses speakupconf save might be considered > broken, because, it doesn't allow me to specify which save directory I > want to use. My suggestion for a solution to that would be to remove > the calls to speakupconf save from speakupconf_setlocale and just warn > the user that they need to use speakupconf save after running this > script. > > Also, why not make this part of speakupconf by adding another command > to it, like "speakupconf locale", which would check the LANG variable > and load the correct settings? I think if we do that we can remove > speakup_setlocale entirely. > > What do the rest of you think? > > Thanks, > > William > > _______________________________________________ > Speakup mailing list > Speakup@braille.uwo.ca > http://speech.braille.uwo.ca/mailman/listinfo/speakup