From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <w.d.hubbs@gmail.com>
Received: from mail-gx0-f170.google.com (mail-gx0-f170.google.com
	[209.85.161.170])
	by speech.braille.uwo.ca (Postfix) with ESMTP id 4928AC1A100
	for <speakup@braille.uwo.ca>; Sun, 17 Oct 2010 18:44:16 -0400 (EDT)
Received: by gxk3 with SMTP id 3so104027gxk.29
	for <speakup@braille.uwo.ca>; Sun, 17 Oct 2010 15:44:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:received:date:from:to:subject
	:message-id:mail-followup-to:mime-version:content-type
	:content-disposition:user-agent;
	bh=T2+NzVAE+fyJIQwyrdJgqvFRenoh3q+PbKhrZ9uV3xs=;
	b=lpF2AyMbMxyXW6SOiugeGvwzYkA/BuBBhQbfVWS5oQU+CNR3jkn4SlGNnxFLfeg31F
	PNMZUbL9lcWf1D11FMVahLWjh76cWEHQitWFyAaj1xc72jNILyOUmj/Ul5eAp7kw9LDV
	TCh9tHGjvYnO8drN8/fVi/0n1uD80PGz447LY=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=date:from:to:subject:message-id:mail-followup-to:mime-version
	:content-type:content-disposition:user-agent;
	b=sLEcjRQmMu7FF8537ZnGs5niIPUWzOOw+QlqfavgPLlHDCua8oNov9dgeoaYA2LMie
	lnwwFwUQzepkU4cyDO3Rm18CYhv4n+Vq/TdiAd6G/8dlfYnjBjWBM/K9wdOUyDKESzGV
	HzSbzvERsyxvGLILTHjFGR3tX6iaVrBsk5qhs=
Received: by 10.236.105.201 with SMTP id k49mr6350694yhg.74.1287355455861;
	Sun, 17 Oct 2010 15:44:15 -0700 (PDT)
Received: from linux1 (cpe-76-183-49-63.tx.res.rr.com [76.183.49.63])
	by mx.google.com with ESMTPS id f46sm12662749yhc.17.2010.10.17.15.44.13
	(version=SSLv3 cipher=RC4-MD5); Sun, 17 Oct 2010 15:44:15 -0700 (PDT)
Received: by linux1 (sSMTP sendmail emulation);
 Sun, 17 Oct 2010 17:44:12 -0500
Date: Sun, 17 Oct 2010 17:44:12 -0500
From: William Hubbs <w.d.hubbs@gmail.com>
To: speakup mailing list <speakup@braille.uwo.ca>
Subject: speakup_setlocale concerns
Message-ID: <20101017224412.GA19219@linux1>
Mail-Followup-To: speakup mailing list <speakup@braille.uwo.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
X-BeenThere: speakup@braille.uwo.ca
X-Mailman-Version: 2.1.13
Precedence: list
Reply-To: "Speakup is a screen review system for Linux."
	<speakup@braille.uwo.ca>
List-Id: "Speakup is a screen review system for Linux."
	<speakup.braille.uwo.ca>
List-Unsubscribe: <http://speech.braille.uwo.ca/mailman/options/speakup>,
	<mailto:speakup-request@braille.uwo.ca?subject=unsubscribe>
List-Archive: <http://speech.braille.uwo.ca/pipermail/speakup>
List-Post: <mailto:speakup@braille.uwo.ca>
List-Help: <mailto:speakup-request@braille.uwo.ca?subject=help>
List-Subscribe: <http://speech.braille.uwo.ca/mailman/listinfo/speakup>,
	<mailto:speakup-request@braille.uwo.ca?subject=subscribe>
X-List-Received-Date: Sun, 17 Oct 2010 22:44:16 -0000

All,

I just looked this over and I have a couple of concerns about it.

The first is that the way it uses speakupconf save might be considered
broken, because, it doesn't allow me to specify which save directory I
want to use.  My suggestion for a solution to that would be to remove
the calls to speakupconf save from speakupconf_setlocale and just warn
the user that they need to use speakupconf save after running this
script.

Also, why not  make this part of speakupconf by adding another command
to it, like "speakupconf locale", which would check the LANG variable
and load the correct settings?  I think if we do that we can remove
speakup_setlocale entirely.

What do the rest of you think?

Thanks,

William