public inbox for speakup@linux-speakup.org
 help / color / mirror / Atom feed
From: Okash Khawaja <okash.khawaja@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: speakup@linux-speakup.org
Subject: Re: staging: speakup: add send_xchar, tiocmset and input functionality for tty
Date: Sat, 29 Apr 2017 14:38:12 +0100	[thread overview]
Message-ID: <20170429133812.GA1895@sanghar> (raw)
In-Reply-To: <20170429130604.sw3mmsufurrwfxpf@var.youpi.perso.aquilenet.fr>

On Sat, Apr 29, 2017 at 03:06:04PM +0200, Samuel Thibault wrote:
 
> Thinking of it: for spk_ttyio_in_nowait(), we shouldn't print a warning
> when down_timeout returns ETIMEDOUT. So pr_warn should be guarded by
> "if (timeout)".
> 
> Also, spk_ttyio_in_nowait() should return 0 instead of 0xff on timeout,
> since that's used for synth_insert_next_index() which takes 0 as "no new
> value", not 0xff.
> 
> I know, it's converging slowly, but we need to make sure we don't change
> things, otherwise it'll bring regressions.
Sure, I understand. These are also things I should have considered
before submitting.

Thanks,
Okash

  reply	other threads:[~ UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
 [patch 0/7] staging: speakup: migrate synths to use TTY-based comms Okash Khawaja
 ` [patch 1/7] staging: speakup: add send_xchar and tiocmset methods Okash Khawaja
   ` Okash Khawaja
 ` [patch 2/7] staging: speakup: make input functionality swappable Okash Khawaja
   ` Samuel Thibault
 ` [patch 3/7] tty: export tty_open_by_driver Okash Khawaja
 ` [patch 4/7] staging: speakup: add tty-based comms functions Okash Khawaja
 ` [patch 5/7] staging: speakup: migrate acntsa, bns, dummy and txprt to ttyio Okash Khawaja
 ` [patch 6/7] staging: speakup: add send_xchar, tiocmset and input functionality for tty Okash Khawaja
   ` Samuel Thibault
     ` Okash Khawaja
     ` Okash Khawaja
       ` Samuel Thibault
         ` Okash Khawaja
           ` Rob
             ` Okash Khawaja
           ` Samuel Thibault
             ` Okash Khawaja
               ` Samuel Thibault
                 ` Okash Khawaja [this message]
                 ` Okash Khawaja
                   ` Samuel Thibault
         ` Okash Khawaja
           ` Samuel Thibault
             ` Okash Khawaja
               ` Samuel Thibault
 ` [patch 7/7] staging: speakup: migrate apollo, ltlk, audptr, decext, dectlk and spkout Okash Khawaja
 ` [patch 0/7] staging: speakup: migrate synths to use TTY-based comms Samuel Thibault
   ` Okash Khawaja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170429133812.GA1895@sanghar \
    --to=okash.khawaja@gmail.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=speakup@linux-speakup.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).