From: Okash Khawaja <okash.khawaja@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: speakup@linux-speakup.org
Subject: Re: [patch 1/7] staging: speakup: add send_xchar and tiocmset methods
Date: Thu, 13 Apr 2017 18:55:56 +0100 [thread overview]
Message-ID: <20170413175556.GA2503@sanghar> (raw)
In-Reply-To: <20170413174725.870278884@gmail.com>
On Thu, Apr 13, 2017 at 06:41:29PM +0100, Okash Khawaja wrote:
> This adds two methods to spk_synth struct: send_xchar and tiocmset, and
> creates serial implementation for each of them. It takes existing code
> in apollo, audptr and spkout which already fits the behaviour of
> send_xchar and tiocmset. In follow-up patches there will be TTY-based
> implementations of these methods. Then migrating the synths to TTY will
> include repointing these methods to their TTY implementations
>
> Rest of the changes simply make use of serial implementation of these two
> functions.
>
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
> Reviewed-by: Samuel Thibault <samuel.thibault at ens-lyon.org>
I'll fix the at symbol across the patchset - copy-paste mistake.
next prev parent reply other threads:[~ UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[patch 0/7] staging: speakup: migrate synths to use TTY-based comms Okash Khawaja
` [patch 1/7] staging: speakup: add send_xchar and tiocmset methods Okash Khawaja
` Okash Khawaja [this message]
` [patch 2/7] staging: speakup: make input functionality swappable Okash Khawaja
` Samuel Thibault
` [patch 3/7] tty: export tty_open_by_driver Okash Khawaja
` [patch 4/7] staging: speakup: add tty-based comms functions Okash Khawaja
` [patch 5/7] staging: speakup: migrate acntsa, bns, dummy and txprt to ttyio Okash Khawaja
` [patch 6/7] staging: speakup: add send_xchar, tiocmset and input functionality for tty Okash Khawaja
` Samuel Thibault
` Okash Khawaja
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
` Rob
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` [patch 7/7] staging: speakup: migrate apollo, ltlk, audptr, decext, dectlk and spkout Okash Khawaja
` [patch 0/7] staging: speakup: migrate synths to use TTY-based comms Samuel Thibault
` Okash Khawaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413175556.GA2503@sanghar \
--to=okash.khawaja@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).