From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id EAF271F04B5; Thu, 13 Apr 2017 13:57:52 -0400 (EDT) Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) by befuddled.reisers.ca (Postfix) with ESMTPS id 3ADA21F0008 for ; Thu, 13 Apr 2017 13:56:00 -0400 (EDT) Received: by mail-wr0-x230.google.com with SMTP id z109so40110250wrb.1 for ; Thu, 13 Apr 2017 10:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bI8PlbsjAaJO8qq+c/IkQwi4t/Rtl5iGXu0HXaV6udQ=; b=KImy5ta/mjnOIDDB6HSkS85SMB43cR2fP9w95tMGxyt3pD/KGqCZsM4z9pXDw5HRWC RfTSKr8LsDg3XA6mVZ/2zSgdiAVp+ku+/lTWyyidi09vpcDOu2AiDEDCHsxa5ZyMziiJ W8IZ+0pRTr+UP6DY8vcmvzNSiDGYZFxGRnVcFi5MaQoKyapOpE/Mki6Dd8Z/rcBYcLnW 6N2jtBMYHCnjQuagyp4DDZzidMLyZwYxRrd8JoeQWB4b6oL2Ni/T2yyv8fIGHlt5PMR5 ad0Rr2/kCMD6AMb3BidVRzaRpJghJ9uoz8fHWnl5TDVd4gQrEKs10DWDQDhYcCRXdh6h hjVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bI8PlbsjAaJO8qq+c/IkQwi4t/Rtl5iGXu0HXaV6udQ=; b=JlyXgyiPpMWANUVU/TJBnDmtuQ8Bq00+01IkN3RaVOkBZjBgWSLQ2hL2VE2CYFaJj4 gXMzstbGMRBteZoRMqrX9GRG0HRwf13QiWkFkce2zSAcG3fKwlI1P69xSByeT5qr1nXD 6r4xXUyJpCqBzfsHz3SjSq3qujd2BT+MvCYKCOz/5X3AyJI6pv38xCtPA9vZqUQaBUZc E8LA+4BMpZCosChVDdNiRBEefM1POfBhnkbAJsUmsy0Jk06bMbqTCPRw1yheUUbTQIf6 +E4N7AcZfdZkwtGI+hQrJG97JJGFYFjV13Hj01Dnxg/40cFwRxQwY6s2I0Xl9+DWUer6 ZJCQ== X-Gm-Message-State: AN3rC/4wi8JMf0Ynaro2fhBe6fSh2jPCVhYWKIDyM2r5WvkNQl5MqW1r seRhuEe+l3fLfQ== X-Received: by 10.223.157.23 with SMTP id k23mr4064245wre.28.1492106157892; Thu, 13 Apr 2017 10:55:57 -0700 (PDT) Received: from sanghar ([2a00:23c4:7320:5e00:224:d6ff:fe76:7136]) by smtp.gmail.com with ESMTPSA id 186sm11478220wml.2.2017.04.13.10.55.57 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 13 Apr 2017 10:55:57 -0700 (PDT) Date: Thu, 13 Apr 2017 18:55:56 +0100 From: Okash Khawaja To: Samuel Thibault Cc: speakup@linux-speakup.org Subject: Re: [patch 1/7] staging: speakup: add send_xchar and tiocmset methods Message-ID: <20170413175556.GA2503@sanghar> References: <20170413174128.794011516@gmail.com> <20170413174725.870278884@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413174725.870278884@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 17:57:53 -0000 On Thu, Apr 13, 2017 at 06:41:29PM +0100, Okash Khawaja wrote: > This adds two methods to spk_synth struct: send_xchar and tiocmset, and > creates serial implementation for each of them. It takes existing code > in apollo, audptr and spkout which already fits the behaviour of > send_xchar and tiocmset. In follow-up patches there will be TTY-based > implementations of these methods. Then migrating the synths to TTY will > include repointing these methods to their TTY implementations > > Rest of the changes simply make use of serial implementation of these two > functions. > > Signed-off-by: Okash Khawaja > Reviewed-by: Samuel Thibault I'll fix the at symbol across the patchset - copy-paste mistake.