From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 5DB7F1F029E; Sat, 29 Apr 2017 09:39:49 -0400 (EDT) Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) by befuddled.reisers.ca (Postfix) with ESMTPS id CAD861F0270 for ; Sat, 29 Apr 2017 09:38:15 -0400 (EDT) Received: by mail-wr0-x230.google.com with SMTP id l50so45738173wrc.3 for ; Sat, 29 Apr 2017 06:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dJR1fVScIh53VPqS4kuO9YYnbLW4s4sXK5968tAb1a4=; b=IkShJZC0YnvLW+HpRrazX1G2hr8qo+T8CuU3+FDABtfK2L2eawqUwIC/3sHPKtZEjK c4ejUk1RrFqp3RWzSCzslppV4Flh+GH2XKbNfavcTOH3yo51Ww7T42qw1T90gw8dFHU/ 9ETD8pb+iXG90YeJ6rWswKVGLMXJTdz06STdWQVV2o7UNRPOhCm3Q3DPYBruHSFcTupN IKSv91MDQv2+GJ/Nw0UdWI69BYecAqjY5QasQXm9rpSAWc7EPNNia7O76qerOHAUTcIN iF0fwteDOtdT0haW5uFhZGALm3+5KMBx0SHprrVM6K3cNgYYj3OW/av2GPJ1HZ2EVO2/ 8BwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dJR1fVScIh53VPqS4kuO9YYnbLW4s4sXK5968tAb1a4=; b=hPtFEyqBMpRHcdT/3OQuisccbjgneBGVgLlHUb0AMAcByla0Hckz0IDlmF90cCyoNP a77dMs2AMG7d/9tAaqVUmIG7XNaHX4ovJKQB+/65hki0u/LFvTxUWSTIRL1fOd9COYCv 205LlggXJp1Dx7rMALfktyX6wxRO6jM9AaVIZsNv7F9CAtaanGCuejjeipVv0zTIQhh/ GFqKlT97uUI7v/Xb8Op+62PkPGioFZHIOTNBtBbzit1/JwrzPwiHpvdazXDOSXX1Ls1V ZU5aVL5tuCJijDosZIHqFPjNLt4e+NM+eBldwWJUqUVcclL0NvPzTuzRHNyKaoqwDmJp O6DA== X-Gm-Message-State: AN3rC/7HJqhAGrA2mNSdqA13RhnQ68s3Rg0NEhKJwmYw0N9xvPO8JJ7w 6H6wGW8XR8BbMv06 X-Received: by 10.223.177.155 with SMTP id q27mr10892079wra.173.1493473094579; Sat, 29 Apr 2017 06:38:14 -0700 (PDT) Received: from sanghar ([2a00:23c4:7320:5e00:224:d6ff:fe76:7136]) by smtp.gmail.com with ESMTPSA id q108sm10038219wrb.3.2017.04.29.06.38.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Apr 2017 06:38:14 -0700 (PDT) Date: Sat, 29 Apr 2017 14:38:12 +0100 From: Okash Khawaja To: Samuel Thibault Cc: speakup@linux-speakup.org Subject: Re: staging: speakup: add send_xchar, tiocmset and input functionality for tty Message-ID: <20170429133812.GA1895@sanghar> References: <20170429120808.2mqqujwn2bp7yi6r@var.youpi.perso.aquilenet.fr> <20170429124809.GA1692@sanghar> <20170429130604.sw3mmsufurrwfxpf@var.youpi.perso.aquilenet.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170429130604.sw3mmsufurrwfxpf@var.youpi.perso.aquilenet.fr> User-Agent: Mutt/1.8.2 (2017-04-18) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Apr 2017 13:39:50 -0000 On Sat, Apr 29, 2017 at 03:06:04PM +0200, Samuel Thibault wrote: > Thinking of it: for spk_ttyio_in_nowait(), we shouldn't print a warning > when down_timeout returns ETIMEDOUT. So pr_warn should be guarded by > "if (timeout)". > > Also, spk_ttyio_in_nowait() should return 0 instead of 0xff on timeout, > since that's used for synth_insert_next_index() which takes 0 as "no new > value", not 0xff. > > I know, it's converging slowly, but we need to make sure we don't change > things, otherwise it'll bring regressions. Sure, I understand. These are also things I should have considered before submitting. Thanks, Okash