Re: [PATCH v2 2/4] staging: speakup: use native error codes

Re: [PATCH v2 2/4] staging: speakup: use native error codes

[Samuel Thibault]

Andy Shevchenko, le Thu 28 Mar 2013 11:02:44 +0200, a écrit :
> The mapping as follows:
> 	E_RANGE		-> ERANGE
> 	E_UNDEF		-> ENODATA
> 	E_TOOLONG	-> E2BIG
> 	SET_DEFAULT	-> ERESTART
> 
> As a side effect it fixes a bug in spk_var_store() where return code was
> mistakenly compared to negative value instead of positive.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Re: [PATCH v2 3/4] staging: speakup: reuse native hex2bin()

[Samuel Thibault]

Andy Shevchenko, le Thu 28 Mar 2013 11:02:45 +0200, a écrit :
> -		} else if (*p1 == 'x' &&
> -				strchr(hx, p1[1]) && strchr(hx, p1[2])) {
...
> -		} else
> -			*p++ = *p1++;
> +		} else {
> +			if (*p1 == 'x' && !hex2bin(&num, p1 + 1, 1)) {
...
> +			} else
> +				*p++ = *p1++;
> +		}

Why not keeping the same else if structure?  It looks nicer to me to
keep a series of else if.

> +			if (*p1 == 'x' && !hex2bin(&num, p1 + 1, 1)) {

Count should be 2, shouldn't it?

Samuel

Re: [PATCH v2 4/4] staging: speakup: fix a bug when translate octal numbers

[Samuel Thibault]

Andy Shevchenko, le Thu 28 Mar 2013 11:02:46 +0200, a écrit :
> There are actually overflow bug and typo. And bug was never happened due to the
> typo.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Re: [PATCH v2 3/4] staging: speakup: reuse native hex2bin()

[Samuel Thibault]

Andy Shevchenko, le Tue 09 Apr 2013 15:13:09 +0300, a écrit :
> > > +			if (*p1 == 'x' && !hex2bin(&num, p1 + 1, 1)) {
> > 
> > Count should be 2, shouldn't it?
> 
> Actually, no. It means bytes in the result.

Ah, right.

> If I got it correctly the original code translates '\xNN' into NN which
> is exactly one byte.

Yes.

Samuel