From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <samuel.thibault@ens-lyon.org>
Received: from speech.braille.uwo.ca (speech.braille.uwo.ca [129.100.249.132])
 by befuddled.reisers.ca (Postfix) with ESMTP id 5B4A41EF517
 for <speakup@linux-speakup.org>; Tue,  9 Apr 2013 15:01:55 -0400 (EDT)
Received: by speech.braille.uwo.ca (Postfix)
 id 68AC5C1A093; Tue,  9 Apr 2013 15:01:19 -0400 (EDT)
Received: from toccata.ens-lyon.org (toccata.ens-lyon.fr [140.77.166.68])
 by speech.braille.uwo.ca (Postfix) with ESMTP id 38E32C1A076
 for <speakup@braille.uwo.ca>; Tue,  9 Apr 2013 15:01:19 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])
 by toccata.ens-lyon.org (Postfix) with ESMTP id 27A518409C;
 Tue,  9 Apr 2013 21:01:08 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at toccata.ens-lyon.org
Received: from toccata.ens-lyon.org ([127.0.0.1])
 by localhost (toccata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id WxsB3wt8vJ-G; Tue,  9 Apr 2013 21:01:08 +0200 (CEST)
Received: from type.ipv6 (youpi.is-a-geek.org [80.67.176.89])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by toccata.ens-lyon.org (Postfix) with ESMTPSA id D245D8409B;
 Tue,  9 Apr 2013 21:01:07 +0200 (CEST)
Received: from samy by type.ipv6 with local (Exim 4.80)
 (envelope-from <samuel.thibault@ens-lyon.org>)
 id 1UPaZG-0001UN-38; Tue, 09 Apr 2013 17:34:42 +0200
Date: Tue, 9 Apr 2013 17:34:42 +0200
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 3/4] staging: speakup: reuse native hex2bin()
Message-ID: <20130409153442.GB5110@type>
References: 
 <1364461366-4939-1-git-send-email-andriy.shevchenko@linux.intel.com>
 <1364461366-4939-3-git-send-email-andriy.shevchenko@linux.intel.com>
 <20130329003819.GF13103@type.youpi.perso.aquilenet.fr>
 <1365509589.6652.130.camel@smile>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1365509589.6652.130.camel@smile>
User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)
Cc: devel@driverdev.osuosl.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 speakup@braille.uwo.ca
X-BeenThere: speakup@linux-speakup.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: "Speakup is a screen review system for Linux."
 <speakup@linux-speakup.org>
List-Id: "Speakup is a screen review system for Linux."
 <speakup.linux-speakup.org>
List-Unsubscribe: <http://linux-speakup.org/cgi-bin/mailman/options/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=unsubscribe>
List-Archive: <http://linux-speakup.org/pipermail/speakup/>
List-Post: <mailto:speakup@linux-speakup.org>
List-Help: <mailto:speakup-request@linux-speakup.org?subject=help>
List-Subscribe: <http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup>,
 <mailto:speakup-request@linux-speakup.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Apr 2013 19:01:55 -0000

Andy Shevchenko, le Tue 09 Apr 2013 15:13:09 +0300, a écrit :
> > > +			if (*p1 == 'x' && !hex2bin(&num, p1 + 1, 1)) {
> > 
> > Count should be 2, shouldn't it?
> 
> Actually, no. It means bytes in the result.

Ah, right.

> If I got it correctly the original code translates '\xNN' into NN which
> is exactly one byte.

Yes.

Samuel