Scroll lock bug

Scroll lock bug

[luke]

In the recent version, the scroll lock key does not actually freeze 
output.

For example, hitting it while doing an scp transfer, has no effect, and 
subsequent presses always result in "scroll lock on" phrases.

This is different from the old behavior, and as far as I know it is a bug.

If it matters, this is with kernel version 2.6.18, patched with the git 
source available on Wednesday.

Regards,

Luke

Re: Scroll lock bug

[Samuel Thibault]

luke, le Sun 15 Jun 2008 00:49:03 -0400, a écrit :
> In the recent version, the scroll lock key does not actually freeze 
> output.

Hermf, actually it does, but speakup unfreezes it immediately.  I guess
we can just catch the scroll lock key and manage it ourselves, per VT.

Samuel

Re: Scroll lock bug

[Samuel Thibault]

Samuel Thibault, le Sun 15 Jun 2008 14:18:50 +0100, a écrit :
> luke, le Sun 15 Jun 2008 00:49:03 -0400, a écrit :
> > In the recent version, the scroll lock key does not actually freeze 
> > output.
> 
> Hermf, actually it does, but speakup unfreezes it immediately.  I guess
> we can just catch the scroll lock key and manage it ourselves, per VT.

I pushed a fix, could you try it?

Samuel

Re: Scroll lock bug

[luke]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1208 bytes --]

On Sun, 15 Jun 2008, Samuel Thibault wrote:

> Samuel Thibault, le Sun 15 Jun 2008 14:18:50 +0100, a écrit :
> > luke, le Sun 15 Jun 2008 00:49:03 -0400, a écrit :
> > > In the recent version, the scroll lock key does not actually freeze 
> > > output.
> > 
> > Hermf, actually it does, but speakup unfreezes it immediately.  I guess
> > we can just catch the scroll lock key and manage it ourselves, per VT.
> 
> I pushed a fix, could you try it?

Tried it on kernel version 2.6.18.
It solves that problem, which creates another, far worse.

N.B. I have not previously updated speakup since, I think, Friday or 
possibly Saturday, so it may have been some other change which caused 
this.

Particularly, all review key functions behave with intolerable slowness.  
The reading of keys and such seems uneffected, but attempting to review 
the screen is painful--possibly half second delays between key presses and 
speech.

The side effect is not worth the cure, if in fact that is what caused it.

I will note that I did not try playing with any parameters--just the same 
ones I used on the version I pulled a couple days ago, which did not 
exibit this delay problem.

Luke

Re: Scroll lock bug

[Samuel Thibault]

Hello,

luke, le Mon 16 Jun 2008 04:17:15 -0400, a écrit :
> It solves that problem, which creates another, far worse.
> Particularly, all review key functions behave with intolerable slowness.  

Hum... Does it do so all the time, or only when you have stopped the
screen?

Could you try 
git checkout 28b0bfd7
to make sure that you are getting the fix for scroll lock, and not a
more recent change that involved flush?

Samuel

Re: Scroll lock bug

[luke]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 377 bytes --]

On Mon, 16 Jun 2008, Samuel Thibault wrote:

> Hello,
> 
> luke, le Mon 16 Jun 2008 04:17:15 -0400, a écrit :
> > It solves that problem, which creates another, far worse.
> > Particularly, all review key functions behave with intolerable slowness.  
> 
> Hum... Does it do so all the time, or only when you have stopped the
> screen?

It was all the time.

Luke

Re: Scroll lock bug

[luke]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 566 bytes --]

On Mon, 16 Jun 2008, Samuel Thibault wrote:

> luke, le Mon 16 Jun 2008 04:17:15 -0400, a écrit :
> > It solves that problem, which creates another, far worse.
> > Particularly, all review key functions behave with intolerable slowness.  
> 
> Could you try 
> git checkout 28b0bfd7
> to make sure that you are getting the fix for scroll lock, and not a
> more recent change that involved flush?

I'm working on that compile now.
Question: short of cloning again (which I'm fine with) how do I recover to 
the current version after this is over?

Luke

Re: Scroll lock bug

[Samuel Thibault]

luke, le Mon 16 Jun 2008 15:49:16 -0400, a écrit :
> On Mon, 16 Jun 2008, Samuel Thibault wrote:
> 
> > luke, le Mon 16 Jun 2008 04:17:15 -0400, a écrit :
> > > It solves that problem, which creates another, far worse.
> > > Particularly, all review key functions behave with intolerable slowness.  
> > 
> > Could you try 
> > git checkout 28b0bfd7
> > to make sure that you are getting the fix for scroll lock, and not a
> > more recent change that involved flush?
> 
> I'm working on that compile now.
> Question: short of cloning again (which I'm fine with) how do I recover to 
> the current version after this is over?

git checkout master

Samuel

Re: Scroll lock bug

[William Hubbs]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Luke,

On Mon, Jun 16, 2008 at 10:25:54PM +0100, Samuel Thibault wrote:
> luke, le Mon 16 Jun 2008 15:49:16 -0400, a ?crit :
> > On Mon, 16 Jun 2008, Samuel Thibault wrote:
> > 
> > > luke, le Mon 16 Jun 2008 04:17:15 -0400, a ?crit :
> > > > It solves that problem, which creates another, far worse.
> > > > Particularly, all review key functions behave with intolerable slowness.  
> > > 
> > > Could you try 
> > > git checkout 28b0bfd7
> > > to make sure that you are getting the fix for scroll lock, and not a
> > > more recent change that involved flush?
> > 
> > I'm working on that compile now.
> > Question: short of cloning again (which I'm fine with) how do I recover to 
> > the current version after this is over?
> 
> git checkout master
 
Also, can you send the .config file you used to build this kernel off
list to myself and Samuel?

Thanks,

William

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEARECAAYFAkhXBGIACgkQblQW9DDEZTh5zACfX7QMcIKodch3eLokxLlAJHPu
JqAAoLO59bJNRUog/ZX1DMu+np42Ray4
=vHjN
-----END PGP SIGNATURE-----

Re: Scroll lock bug

[luke]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 892 bytes --]

On Mon, 16 Jun 2008, Samuel Thibault wrote:

> luke, le Mon 16 Jun 2008 04:17:15 -0400, a écrit :
> > It solves that problem, which creates another, far worse.
> > Particularly, all review key functions behave with intolerable slowness.  
> 
> Could you try 
> git checkout 28b0bfd7
> to make sure that you are getting the fix for scroll lock, and not a
> more recent change that involved flush?

Having updated per your instructions, I find that the fix for scroll lock 
is working properly, and the delays in review functions are gone.
Perhaps it was the flush change that did it after all.

Sorry for the delay--my first compile failed because of stupidity on my 
part, and other things were going on that took my attention.

As for the flush change: is that ready for testing, or is it still in the 
state it was when I accidentally tried it before?

Regards,

Luke

Re: Scroll lock bug

[Samuel Thibault]

luke, le Tue 17 Jun 2008 04:40:42 -0400, a écrit :
> On Mon, 16 Jun 2008, Samuel Thibault wrote:
> > luke, le Mon 16 Jun 2008 04:17:15 -0400, a écrit :
> > > It solves that problem, which creates another, far worse.
> > > Particularly, all review key functions behave with intolerable slowness.  
> > 
> > Could you try 
> > git checkout 28b0bfd7
> > to make sure that you are getting the fix for scroll lock, and not a
> > more recent change that involved flush?
> 
> Having updated per your instructions, I find that the fix for scroll lock 
> is working properly, and the delays in review functions are gone.

Ok, thanks for testing, it's good to know.

> As for the flush change: is that ready for testing, or is it still in the 
> state it was when I accidentally tried it before?

Nothing happened yet because we weren't able to reproduce the issue.
We'll try to understand what happens now that we know it's the flush
move.

Samuel

Probable flush update problem in source

[luke]

On Tue, 17 Jun 2008, Samuel Thibault wrote:

> > As for the flush change: is that ready for testing, or is it still in the 
> > state it was when I accidentally tried it before?
> 
> Nothing happened yet because we weren't able to reproduce the issue.
> We'll try to understand what happens now that we know it's the flush
> move.

Okay.  I am using a DEC Express (old) running on a serial port of course.  
I can rebuild this, and give you a full kernel config if you want it; 
but I'll wait to hear whether there are any specific tests you want me to 
run (E.G. modular/non-modular, different premption models, etc.).

The config from when it happened last time is here:

http://suntzu.tacticus.com/config-2.6.18-speakup4

Having tested it again, I note that on all of these git speakup versions 
from the last week, after it says "DECTalk Express found" (first spoken 
message, now that I have changed speakup_synth to speakup.synth), there is 
a long delay, and we are into network card detection before it actually 
starts talking again.

That is important here, because for the flush modified version, I am 
unable to shut the speech up right away from my USB keyboard, and by the 
time I can, the thing has choked, and even after it does shut up, it 
takes me nearly 45 seconds of hitting review keys (between numpad 2 and 
numpad enter) before the speech will come back.  When it does, of course, 
it is sluggish as I have described.

Just for fun, I entered speakup help, and every key pressed was exhibiting 
that half second or so delay.

Not so outside of speakup help, when at least the non-speakup keys would 
speak at their normal responsiveness level.

HTH

Luke

Re: Scroll lock bug

[Samuel Thibault]

Hello,

luke, le Tue 17 Jun 2008 04:40:42 -0400, a écrit :
> As for the flush change: is that ready for testing, or is it still in the 
> state it was when I accidentally tried it before?

I've moved a few things, please test again.

Samuel

Re: Scroll lock bug

[luke]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 941 bytes --]

Working on it.  hubbs.homedns.org seems to have gone away for the time 
being, and linux-speakup.org's version is running dirt slow, so it may be 
 a few hours before I have a copy to test.

I have the following running while I go eat breakfast and find some 
coffee...:)

while [ 1 = 1 ]; do git-clone http://hubbs.homedns.org/speakup.git && 
break; rm -r speakup; done


On Thu, 19 Jun 2008, Samuel Thibault wrote:

> Hello,
> 
> luke, le Tue 17 Jun 2008 04:40:42 -0400, a écrit :
> > As for the flush change: is that ready for testing, or is it still in the 
> > state it was when I accidentally tried it before?
> 
> I've moved a few things, please test again.
> 
> Samuel
> _______________________________________________
> Speakup mailing list
> Speakup@braille.uwo.ca
> http://speech.braille.uwo.ca/mailman/listinfo/speakup
> 

-- 
"Fiat money and sustainable society are not compatible." - Peter Cajander

Re: Scroll lock bug

[luke]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 383 bytes --]

On Thu, 19 Jun 2008, Samuel Thibault wrote:

> luke, le Tue 17 Jun 2008 04:40:42 -0400, a écrit :
> > As for the flush change: is that ready for testing, or is it still in the 
> > state it was when I accidentally tried it before?
> 
> I've moved a few things, please test again.

No change unless it's even slightly less responsive, but not sure of that.

Regards,

Luke