public inbox for speakup@linux-speakup.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: speakup@linux-speakup.org, William Hubbs <w.d.hubbs@gmail.com>
Subject: Re: TODO file
Date: Thu, 14 Mar 2019 13:24:47 +0100	[thread overview]
Message-ID: <20190314122447.rn2mr47n3rpebbrp@function> (raw)
In-Reply-To: <20190314110726.3bcc7bcf@narunkot>

Okash Khawaja, le jeu. 14 mars 2019 11:07:26 +0000, a ecrit:
> I can't find any reference to in_atomic() in speakup code. According to
> "Atomic context and kernel API design" [1] lwn article, in_atomic()
> started being phased out of general kernel code around 2.6.26. I guess
> this commit removed remaining references to in_atomic: d7500135802c
> "Staging: speakup: Move pasting into a work item". Is there any more
> work to be done for this?

It seems there is no more indeed.

> Also can someone give a bit of a background or pointers regarding
> moving kobjects:
> 
> "The kobjects may have to move to a more proper place in /sys. The
> discussion on lkml resulted to putting speech synthesizers in the
> "speech" class, and the speakup screen reader itself into
> /sys/class/vtconsole/vtcon0/speakup, the nasty path being handled by
> userland tools."

I don't remember the discussion. I'm not sure what is best. Moving
synthesizers to a speech class and the screen reader to vtconsole makes
sense technically, less so in terms of users (and the userland tools
then have to adapt to the new path). I'd say try to find the discussions
where the location was discussed, to check whether this is really wanted
by kernel developers, otherwise I'd stay leave it where it is and focus
on items which are more useful.

Actually, perhaps the only item that remains for getting out of staging/
is the selection duplication. Perhaps it is time to check with Greg what
he sees needs to be done. Perhaps only codestyle remains at this point?
(getting out of staging is an important goal, both for settling the
driver, but also for getting included in distributions which build only
mainline drivers)

Samuel

  reply	other threads:[~ UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
 Okash Khawaja
 ` Samuel Thibault
   ` Okash Khawaja
     ` Samuel Thibault [this message]
       ` Okash Khawaja
         ` Samuel Thibault
           ` Okash Khawaja
             ` Samuel Thibault
               ` Okash Khawaja
               ` Gregory Nowak
                 ` Samuel Thibault
                   ` Gregory Nowak
                   ` Janina Sajka
                 ` Tom Fowle
                 ` Janina Sajka
                   ` doubletalks Tom Fowle
                     ` doubletalks Tom Fowle
                     ` doubletalks Janina Sajka
                       ` doubletalks Tom Fowle
               ` TODO file John Covici
                 ` John Covici
 Gregory Nowak
 ` Tom Fowle
 ` John Covici

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190314122447.rn2mr47n3rpebbrp@function \
    --to=samuel.thibault@ens-lyon.org \
    --cc=okash.khawaja@gmail.com \
    --cc=speakup@linux-speakup.org \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).