Re: [PATCH 1/4] staging: speakup: add a missing blank line after declaration

Re: [PATCH 1/4] staging: speakup: add a missing blank line after declaration

[Okash Khawaja]

On Mon, Jun 05, 2017 at 11:43:55PM -0400, Bo YU wrote:
> Fixed checkpatch warning by adding a blank line after declare
> expression
> 
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>

Reviewed-by: Okash Khawaja <okash.khawaja@gmail.com>

> ---
>  drivers/staging/speakup/serialio.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
> index 969373201356..8d2f7c672cc6 100644
> --- a/drivers/staging/speakup/serialio.c
> +++ b/drivers/staging/speakup/serialio.c
> @@ -162,6 +162,7 @@ static void spk_serial_send_xchar(char ch)
>  static void spk_serial_tiocmset(unsigned int set, unsigned int clear)
>  {
>  	int old = inb(speakup_info.port_tts + UART_MCR);
> +
>  	outb((old & ~clear) | set, speakup_info.port_tts + UART_MCR);
>  }
>  
> -- 
> 1.7.10.4
> 

Re: [PATCH 2/4] staging: speakup: add a space around '|'

[Okash Khawaja]

On Mon, Jun 05, 2017 at 11:44:11PM -0400, Bo YU wrote:
> Add a space around logical symbol '|' to wipe out checkpatch check
> 
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>

Reviewed-by: Okash Khawaja <okash.khawaja@gmail.com>

> ---
>  drivers/staging/speakup/serialio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
> index 8d2f7c672cc6..f38eb66943bf 100644
> --- a/drivers/staging/speakup/serialio.c
> +++ b/drivers/staging/speakup/serialio.c
> @@ -138,7 +138,7 @@ static void start_serial_interrupt(int irq)
>  	outb(UART_MCR_DTR | UART_MCR_RTS | UART_MCR_OUT2,
>  	     speakup_info.port_tts + UART_MCR);
>  	/* Turn on Interrupts */
> -	outb(UART_IER_MSI|UART_IER_RLSI|UART_IER_RDI,
> +	outb(UART_IER_MSI | UART_IER_RLSI | UART_IER_RDI,
>  			speakup_info.port_tts + UART_IER);
>  	inb(speakup_info.port_tts + UART_LSR);
>  	inb(speakup_info.port_tts + UART_RX);
> -- 
> 1.7.10.4
> 

Re: [PATCH 3/4] staging: speakup: in serialio.c no over 80 chars long

[Okash Khawaja]

On Mon, Jun 05, 2017 at 11:44:26PM -0400, Bo YU wrote:
> Fixed the checkpatch.pl warning:
> 
> WARNING: line over 80 characters
> 
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>

Reviewed-by: Okash Khawaja <okash.khawaja@gmail.com>

> ---
>  drivers/staging/speakup/serialio.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
> index f38eb66943bf..00b25d3591d2 100644
> --- a/drivers/staging/speakup/serialio.c
> +++ b/drivers/staging/speakup/serialio.c
> @@ -228,7 +228,8 @@ int spk_wait_for_xmitr(struct spk_synth *in_synth)
>  	}
>  	while (spk_serial_tx_busy()) {
>  		if (--tmout == 0) {
> -			pr_warn("%s: timed out (tx busy)\n", in_synth->long_name);
> +			pr_warn("%s: timed out (tx busy)\n",
> +				in_synth->long_name);
>  			timeouts++;
>  			return 0;
>  		}
> @@ -285,7 +286,8 @@ static int spk_serial_out(struct spk_synth *in_synth, const char ch)
>  	return 0;
>  }
>  
> -const char *spk_serial_synth_immediate(struct spk_synth *synth, const char *buff)
> +const char *spk_serial_synth_immediate(struct spk_synth *synth,
> +				       const char *buff)
>  {
>  	u_char ch;
>  
> -- 
> 1.7.10.4
> 

Re: [PATCH 4/4] staging: speakup: alignment match open parens

[Okash Khawaja]

On Mon, Jun 05, 2017 at 11:44:40PM -0400, Bo YU wrote:
> I have aligned argument with parenthesis, so checkpatch no check also.
> 
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>

Reviewed-by: Okash Khawaja <okash.khawaja@gmail.com>

> ---
>  drivers/staging/speakup/serialio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
> index 00b25d3591d2..9cfc8142a318 100644
> --- a/drivers/staging/speakup/serialio.c
> +++ b/drivers/staging/speakup/serialio.c
> @@ -139,7 +139,7 @@ static void start_serial_interrupt(int irq)
>  	     speakup_info.port_tts + UART_MCR);
>  	/* Turn on Interrupts */
>  	outb(UART_IER_MSI | UART_IER_RLSI | UART_IER_RDI,
> -			speakup_info.port_tts + UART_IER);
> +	     speakup_info.port_tts + UART_IER);
>  	inb(speakup_info.port_tts + UART_LSR);
>  	inb(speakup_info.port_tts + UART_RX);
>  	inb(speakup_info.port_tts + UART_IIR);
> -- 
> 1.7.10.4
> 

Re: [PATCH 0/4] staging: speakup: fix code style

[Okash Khawaja]

Hi,

On Mon, Jun 05, 2017 at 11:42:59PM -0400, Bo YU wrote:
> As checkpatch.pl reported, i fixed these complaint one by one. Maybe
> patch 04 depend on patch 02.

Thanks for the patches :) I've reviewed them all

Okash