* [patch] staging: speakup: remove unused code
@ Okash Khawaja
0 siblings, 0 replies; 3+ messages in thread
From: Okash Khawaja @ UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Samuel Thibault, linux-kernel
Cc: William Hubbs, Chris Brannon, Kirk Reiser, speakup, devel
In spk_ttyio_release we read tty's index but never do anything with it.
The patch removes this dead code.
Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
drivers/staging/speakup/spk_ttyio.c | 3 ---
1 file changed, 3 deletions(-)
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -247,13 +247,10 @@ EXPORT_SYMBOL_GPL(spk_ttyio_synth_probe)
void spk_ttyio_release(void)
{
- int idx;
-
if (!speakup_tty)
return;
tty_lock(speakup_tty);
- idx = speakup_tty->index;
if (speakup_tty->ops->close)
speakup_tty->ops->close(speakup_tty, NULL);
^ permalink raw reply [flat|nested] 3+ messages in thread* [patch] staging: speakup: remove unused code
@ Okash Khawaja
` Samuel Thibault
0 siblings, 1 reply; 3+ messages in thread
From: Okash Khawaja @ UTC (permalink / raw)
To: Samuel Thibault; +Cc: speakup
In spk_ttyio_release we read tty's index but never do anything with it.
The patch removes this dead code.
Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
---
drivers/staging/speakup/spk_ttyio.c | 3 ---
1 file changed, 3 deletions(-)
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -247,13 +247,10 @@ EXPORT_SYMBOL_GPL(spk_ttyio_synth_probe)
void spk_ttyio_release(void)
{
- int idx;
-
if (!speakup_tty)
return;
tty_lock(speakup_tty);
- idx = speakup_tty->index;
if (speakup_tty->ops->close)
speakup_tty->ops->close(speakup_tty, NULL);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] staging: speakup: remove unused code
Okash Khawaja
@ ` Samuel Thibault
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Thibault @ UTC (permalink / raw)
To: Okash Khawaja; +Cc: speakup
Okash Khawaja, on jeu. 01 juin 2017 13:17:19 +0100, wrote:
> In spk_ttyio_release we read tty's index but never do anything with it.
> The patch removes this dead code.
>
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/staging/speakup/spk_ttyio.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/speakup/spk_ttyio.c
> @@ -247,13 +247,10 @@ EXPORT_SYMBOL_GPL(spk_ttyio_synth_probe)
>
> void spk_ttyio_release(void)
> {
> - int idx;
> -
> if (!speakup_tty)
> return;
>
> tty_lock(speakup_tty);
> - idx = speakup_tty->index;
>
> if (speakup_tty->ops->close)
> speakup_tty->ops->close(speakup_tty, NULL);
>
--
Samuel
> Quelqu'un aurait-il une solution pour réinitialiser un MBR
Si tu veux qu'il soit complètement blanc (pas souhaitable, à mon avis) :
dd if=/dev/zero of=/dev/hda bs=512 count=1 (sous Linux)
-+- OT in Guide du linuxien (très) pervers - "Pour les K difficiles" -+-
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~ UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[patch] staging: speakup: remove unused code Okash Khawaja
-- strict thread matches above, loose matches on Subject: below --
Okash Khawaja
` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).