public inbox for speakup@linux-speakup.org
 help / color / mirror / Atom feed
From: Okash Khawaja <okash.khawaja@gmail.com>
To: John Covici <covici@ccs.covici.com>
Cc: "Speakup is a screen review system for Linux."
	<speakup@linux-speakup.org>
Subject: Re: speakup-r functionality
Date: Mon, 29 May 2017 10:50:33 +0100	[thread overview]
Message-ID: <20170529095033.GA781@sanghar> (raw)
In-Reply-To: <m3zidwk3o0.wl-covici@ccs.covici.com>

On Sun, May 28, 2017 at 06:38:39PM -0400, John Covici wrote:
> I just have one question -- how did it work with the old serial i/o
> system?
In main.c, handle_cursor_read_all calls spk_get_index_count which calls
spk_ttyio_in_nowait or spk_serial_in_nowait depending on whether TTY or
old serial i/o is in use. So the difference is in spk_serial_in_nowait
as the layers above that are identical. spk_serial_in_nowait returns 0
when there is no data on rx. spk_ttyio_in_nowait immitates that but due
to the signedness bug, it was returning 0xff instead of 0 when there
is no data.

With the fix, now both serial i/o and TTY stacks  should have same
behaviour.

  reply	other threads:[~ UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
 Okash Khawaja
 ` John Covici
   ` Okash Khawaja
     ` John Covici
       ` Okash Khawaja [this message]
         ` John Covici
           ` Okash Khawaja
         ` John Covici
           ` Okash Khawaja
             ` John Covici
               ` Okash Khawaja
                 ` John Covici
                   ` Okash Khawaja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529095033.GA781@sanghar \
    --to=okash.khawaja@gmail.com \
    --cc=covici@ccs.covici.com \
    --cc=speakup@linux-speakup.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).