From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 5F4841F02B7; Mon, 29 May 2017 05:50:38 -0400 (EDT) Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) by befuddled.reisers.ca (Postfix) with ESMTPS id C0D091F02B4 for ; Mon, 29 May 2017 05:50:36 -0400 (EDT) Received: by mail-wm0-x233.google.com with SMTP id 123so18192106wmg.1 for ; Mon, 29 May 2017 02:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LrDTyUAUadxb/fproyoRIHgPMdDVHir9IUGQBAiSVxk=; b=rSQvk3zOMElTj+GE04QT++EmJP/zOspTPTW/8KcEICbUzPacRXd6mkx9v5KjlgwnT8 yueDn2aeIZ2li3Y+a8cnhmG232GJC3aMLrWEJgJk4RP30463WCz8VmkPG85C9ZusXQHp EdDA0et0P7K8aNF5Dqlh3hje6VjD3qRecImt5361jmGjqpMa9bEguTWuyuizl8qmDJxy utt3RzXT0xXhjsC/gtu54StBnsdIR4Jvtb3XGk+xLr/DLhRHkC+MNNVoP0Ods8PIpbve HiZoUtKrOgaWnThrcet+aZWQCp0AMdWVQyBGB2jPJBnUiYP14R58Brh8WIQDOdHIlkko oG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LrDTyUAUadxb/fproyoRIHgPMdDVHir9IUGQBAiSVxk=; b=W+AX9ErM2v5qFk2EgvYvunWQ6rwtu9e+/xFRlGzjb5pMabK0O0gWvr1oCLlzVVuVGi xwG2LbgY/NcIKw/xVPi4H32nI04hB8AJSItYDXR3+MXGmH2xp8WkZqdVeVXQYEjr6PxJ Cqxp0qdHPwcxiuc0wI958kZeuPbRSnEy9VBH3RiA2c87x15+TXwc8Ew60SNgyUCKeUGo hIpDALPHYUNL5+whmwJAPiKcxWV9Cmn49FOpEXEVN8sDbic9JDbBrjLRJsmSZjWrMa05 YR0r36EdztYVeeaiyPpLXeai5OhN6QtiPGAuaVASfb5XMPL5+nK74ilFV2t3N9+/pfRD Z4OA== X-Gm-Message-State: AODbwcAzG2J/7hZfs9GSFNDF7ovJly1YZUX8kbNTMJ1iPE+etYCD0Ooo G92nHZ5zm6woIKLs X-Received: by 10.223.169.117 with SMTP id u108mr348358wrc.59.1496051435826; Mon, 29 May 2017 02:50:35 -0700 (PDT) Received: from sanghar (host81-157-247-88.range81-157.btcentralplus.com. [81.157.247.88]) by smtp.gmail.com with ESMTPSA id 17sm8744495wml.32.2017.05.29.02.50.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 May 2017 02:50:35 -0700 (PDT) Date: Mon, 29 May 2017 10:50:33 +0100 From: Okash Khawaja To: John Covici Cc: "Speakup is a screen review system for Linux." Subject: Re: speakup-r functionality Message-ID: <20170529095033.GA781@sanghar> References: <20170528204856.GA883@sanghar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2017 09:50:38 -0000 On Sun, May 28, 2017 at 06:38:39PM -0400, John Covici wrote: > I just have one question -- how did it work with the old serial i/o > system? In main.c, handle_cursor_read_all calls spk_get_index_count which calls spk_ttyio_in_nowait or spk_serial_in_nowait depending on whether TTY or old serial i/o is in use. So the difference is in spk_serial_in_nowait as the layers above that are identical. spk_serial_in_nowait returns 0 when there is no data on rx. spk_ttyio_in_nowait immitates that but due to the signedness bug, it was returning 0xff instead of 0 when there is no data. With the fix, now both serial i/o and TTY stacks should have same behaviour.