[patch 0/7] staging: speakup: migrate synths to use TTY-based comms

[patch 0/7] staging: speakup: migrate synths to use TTY-based comms

[Okash Khawaja]

Hi,

This patchset migrates synths to use TTY-based comms instead of directly using
serial i/o. The move doesn't cover those synths which do need direct access,
e.g. some which talk over ISA.

Please note that this patchset applies on top of current staging-next branch of
Greg Kroah-Hartman's tree as that contains some other changes to speakup and
tty drivers that have recently gone in. So the first patch makes ammendments to
TTY code which allows speakup to access and tty device. Next patch adds
spk_ttyio.c which contains TTY-based initialisation and output functionality.
Next patch migrates those synths which only use output: dummy, acntsa, bns and
txprt. Then we add xchar and tiocmset functions. Next we rearrange the code
such that input functionality is grouped under a few methods inside spk_synth
and spk_io_ops structs. That paves the way for simple migration of other synths
to TTY. The final patch does that for apollo, ltlk, audptr, decext, dectlk
and spkout.

Thanks,
Okash

[patch 1/7] tty: export tty_open_by_driver

[Okash Khawaja]

[-- Attachment #1: 01_export_tty_open_by_driver --]
[-- Type: text/plain, Size: 2035 bytes --]

This applies on top of the changes already in staging-next branch which allow
kernel access to TTY dev.

Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

Index: linux-staging/drivers/tty/tty_io.c
===================================================================
--- linux-staging.orig/drivers/tty/tty_io.c
+++ linux-staging/drivers/tty/tty_io.c
@@ -1369,7 +1369,10 @@ static struct tty_struct *tty_driver_loo
 	struct tty_struct *tty;
 
 	if (driver->ops->lookup)
-		tty = driver->ops->lookup(driver, file, idx);
+		if (!file)
+			tty = ERR_PTR(-EIO);
+		else
+			tty = driver->ops->lookup(driver, file, idx);
 	else
 		tty = driver->ttys[idx];
 
@@ -2001,7 +2004,7 @@ static struct tty_driver *tty_lookup_dri
 		struct tty_driver *console_driver = console_device(index);
 		if (console_driver) {
 			driver = tty_driver_kref_get(console_driver);
-			if (driver) {
+			if (driver && filp) {
 				/* Don't let /dev/console block */
 				filp->f_flags |= O_NONBLOCK;
 				break;
@@ -2034,7 +2037,7 @@ static struct tty_driver *tty_lookup_dri
  *	  - concurrent tty driver removal w/ lookup
  *	  - concurrent tty removal from driver table
  */
-static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
+struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
 					     struct file *filp)
 {
 	struct tty_struct *tty;
@@ -2079,6 +2082,7 @@ out:
 	tty_driver_kref_put(driver);
 	return tty;
 }
+EXPORT_SYMBOL(tty_open_by_driver);
 
 /**
  *	tty_open		-	open a tty device
Index: linux-staging/include/linux/tty.h
===================================================================
--- linux-staging.orig/include/linux/tty.h
+++ linux-staging/include/linux/tty.h
@@ -401,6 +401,8 @@ extern struct tty_struct *get_current_tt
 /* tty_io.c */
 extern int __init tty_init(void);
 extern const char *tty_name(const struct tty_struct *tty);
+extern struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
+		struct file *filp);
 #else
 static inline void console_init(void)
 { }

Re: [patch 1/7] tty: export tty_open_by_driver

[Samuel Thibault]

Hello,

Okash Khawaja, on lun. 03 avril 2017 21:21:24 +0100, wrote:
> This applies on top of the changes already in staging-next branch which allow
> kernel access to TTY dev.
> 
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

Well, you could have kept my

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

since there is actually no newer change :)

> Index: linux-staging/drivers/tty/tty_io.c
> ===================================================================
> --- linux-staging.orig/drivers/tty/tty_io.c
> +++ linux-staging/drivers/tty/tty_io.c
> @@ -1369,7 +1369,10 @@ static struct tty_struct *tty_driver_loo
>  	struct tty_struct *tty;
>  
>  	if (driver->ops->lookup)
> -		tty = driver->ops->lookup(driver, file, idx);
> +		if (!file)
> +			tty = ERR_PTR(-EIO);
> +		else
> +			tty = driver->ops->lookup(driver, file, idx);
>  	else
>  		tty = driver->ttys[idx];
>  
> @@ -2001,7 +2004,7 @@ static struct tty_driver *tty_lookup_dri
>  		struct tty_driver *console_driver = console_device(index);
>  		if (console_driver) {
>  			driver = tty_driver_kref_get(console_driver);
> -			if (driver) {
> +			if (driver && filp) {
>  				/* Don't let /dev/console block */
>  				filp->f_flags |= O_NONBLOCK;
>  				break;
> @@ -2034,7 +2037,7 @@ static struct tty_driver *tty_lookup_dri
>   *	  - concurrent tty driver removal w/ lookup
>   *	  - concurrent tty removal from driver table
>   */
> -static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
> +struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
>  					     struct file *filp)
>  {
>  	struct tty_struct *tty;
> @@ -2079,6 +2082,7 @@ out:
>  	tty_driver_kref_put(driver);
>  	return tty;
>  }
> +EXPORT_SYMBOL(tty_open_by_driver);
>  
>  /**
>   *	tty_open		-	open a tty device
> Index: linux-staging/include/linux/tty.h
> ===================================================================
> --- linux-staging.orig/include/linux/tty.h
> +++ linux-staging/include/linux/tty.h
> @@ -401,6 +401,8 @@ extern struct tty_struct *get_current_tt
>  /* tty_io.c */
>  extern int __init tty_init(void);
>  extern const char *tty_name(const struct tty_struct *tty);
> +extern struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
> +		struct file *filp);
>  #else
>  static inline void console_init(void)
>  { }
> 

[patch 2/7] staging: speakup: add tty-based comms functions

[Okash Khawaja]

[-- Attachment #1: 02_add_spk_ttyio --]
[-- Type: text/plain, Size: 6699 bytes --]

This adds spk_ttyio.c file. It contains a set of functions which implement
those methods in spk_synth struct which relate to sending bytes out using
serial comms. Implementations in this file perform the same function but
using TTY subsystem instead. Currently synths access serial ports, directly
poking standard ISA ports by trying to steal them from serial driver. Some ISA
cards actually need this way of doing it, but most other synthesizers don't,
and can actually work by using the proper TTY subsystem through a new N_SPEAKUP
line discipline. So this adds the methods for drivers to switch to accessing
serial ports through the TTY subsystem, whenever appropriate.

Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

Index: linux-staging/drivers/staging/speakup/Makefile
===================================================================
--- linux-staging.orig/drivers/staging/speakup/Makefile
+++ linux-staging/drivers/staging/speakup/Makefile
@@ -25,6 +25,7 @@ speakup-y := \
 	kobjects.o \
 	selection.o \
 	serialio.o \
+	spk_ttyio.o \
 	synth.o \
 	thread.o \
 	varhandlers.o
Index: linux-staging/drivers/staging/speakup/spk_priv.h
===================================================================
--- linux-staging.orig/drivers/staging/speakup/spk_priv.h
+++ linux-staging/drivers/staging/speakup/spk_priv.h
@@ -46,6 +46,7 @@ int spk_wait_for_xmitr(struct spk_synth
 unsigned char spk_serial_in(void);
 unsigned char spk_serial_in_nowait(void);
 void spk_serial_release(void);
+void spk_ttyio_release(void);
 
 void synth_buffer_skip_nonlatin1(void);
 u16 synth_buffer_getc(void);
@@ -58,7 +59,9 @@ ssize_t spk_var_store(struct kobject *ko
 		      const char *buf, size_t count);
 
 int spk_serial_synth_probe(struct spk_synth *synth);
+int spk_ttyio_synth_probe(struct spk_synth *synth);
 const char *spk_serial_synth_immediate(struct spk_synth *synth, const char *buff);
+const char *spk_ttyio_synth_immediate(struct spk_synth *synth, const char *buff);
 void spk_do_catch_up(struct spk_synth *synth);
 void spk_synth_flush(struct spk_synth *synth);
 int spk_synth_is_alive_nop(struct spk_synth *synth);
@@ -79,5 +82,6 @@ extern struct speakup_info_t speakup_inf
 extern struct var_t synth_time_vars[];
 
 extern struct spk_io_ops spk_serial_io_ops;
+extern struct spk_io_ops spk_ttyio_ops;
 
 #endif
Index: linux-staging/drivers/staging/speakup/spk_ttyio.c
===================================================================
--- /dev/null
+++ linux-staging/drivers/staging/speakup/spk_ttyio.c
@@ -0,0 +1,143 @@
+#include <linux/types.h>
+#include <linux/tty.h>
+
+#include "speakup.h"
+#include "spk_types.h"
+
+static struct tty_struct *speakup_tty;
+
+static int spk_ttyio_ldisc_open(struct tty_struct *tty)
+{
+	if (tty->ops->write == NULL)
+		return -EOPNOTSUPP;
+	speakup_tty = tty;
+
+	return 0;
+}
+
+static void spk_ttyio_ldisc_close(struct tty_struct *tty)
+{
+	speakup_tty = NULL;
+}
+
+static struct tty_ldisc_ops spk_ttyio_ldisc_ops = {
+	.owner          = THIS_MODULE,
+	.magic          = TTY_LDISC_MAGIC,
+	.name           = "speakup_ldisc",
+	.open           = spk_ttyio_ldisc_open,
+	.close          = spk_ttyio_ldisc_close,
+};
+
+static int spk_ttyio_out(struct spk_synth *in_synth, const char ch);
+struct spk_io_ops spk_ttyio_ops = {
+	.synth_out = spk_ttyio_out,
+};
+EXPORT_SYMBOL_GPL(spk_ttyio_ops);
+
+static int spk_ttyio_initialise_ldisc(int ser)
+{
+	int ret = 0;
+	struct tty_struct *tty;
+
+	ret = tty_register_ldisc(N_SPEAKUP, &spk_ttyio_ldisc_ops);
+	if (ret) {
+		pr_err("Error registering line discipline.\n");
+		return ret;
+	}
+
+	if (ser < 0 || ser > (255 - 64)) {
+		pr_err("speakup: Invalid ser param. Must be between 0 and 191 inclusive.\n");
+		return -EINVAL;
+	}
+
+	/* TODO: support more than ttyS* */
+	tty = tty_open_by_driver(MKDEV(4, (ser +  64)), NULL, NULL);
+	if (IS_ERR(tty))
+		return PTR_ERR(tty);
+
+	if (tty->ops->open)
+		ret = tty->ops->open(tty, NULL);
+	else
+		ret = -ENODEV;
+
+	if (ret) {
+		tty_unlock(tty);
+		return ret;
+	}
+
+	clear_bit(TTY_HUPPED, &tty->flags);
+	tty_unlock(tty);
+
+	ret = tty_set_ldisc(tty, N_SPEAKUP);
+
+	return ret;
+}
+
+static int spk_ttyio_out(struct spk_synth *in_synth, const char ch)
+{
+	if (in_synth->alive && speakup_tty && speakup_tty->ops->write) {
+		int ret = speakup_tty->ops->write(speakup_tty, &ch, 1);
+		if (ret == 0)
+			/* No room */
+			return 0;
+		if (ret < 0) {
+			pr_warn("%s: I/O error, deactivating speakup\n", in_synth->long_name);
+			/* No synth any more, so nobody will restart TTYs, and we thus
+			 * need to do it ourselves.  Now that there is no synth we can
+			 * let application flood anyway
+			 */
+			in_synth->alive = 0;
+			speakup_start_ttys();
+			return 0;
+		}
+		return 1;
+	}
+	return 0;
+}
+
+int spk_ttyio_synth_probe(struct spk_synth *synth)
+{
+	int rv = spk_ttyio_initialise_ldisc(synth->ser);
+
+	if (rv)
+		return rv;
+
+	synth->alive = 1;
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(spk_ttyio_synth_probe);
+
+void spk_ttyio_release(void)
+{
+	int idx;
+
+	if (!speakup_tty)
+		return;
+
+	tty_lock(speakup_tty);
+	idx = speakup_tty->index;
+
+	if (speakup_tty->ops->close)
+		speakup_tty->ops->close(speakup_tty, NULL);
+
+	tty_ldisc_flush(speakup_tty);
+	tty_unlock(speakup_tty);
+	tty_ldisc_release(speakup_tty);
+}
+EXPORT_SYMBOL_GPL(spk_ttyio_release);
+
+const char *spk_ttyio_synth_immediate(struct spk_synth *synth, const char *buff)
+{
+	u_char ch;
+
+	while ((ch = *buff)) {
+		if (ch == '\n')
+			ch = synth->procspeech;
+		if (tty_write_room(speakup_tty) < 1 || !synth->io_ops->synth_out(synth, ch))
+			return buff;
+		buff++;
+	}
+	return NULL;
+}
+EXPORT_SYMBOL_GPL(spk_ttyio_synth_immediate);
Index: linux-staging/drivers/tty/tty_ldisc.c
===================================================================
--- linux-staging.orig/drivers/tty/tty_ldisc.c
+++ linux-staging/drivers/tty/tty_ldisc.c
@@ -556,6 +556,7 @@ err:
 	tty_unlock(tty);
 	return retval;
 }
+EXPORT_SYMBOL(tty_set_ldisc);
 
 /**
  *	tty_ldisc_kill	-	teardown ldisc
@@ -744,6 +745,7 @@ void tty_ldisc_release(struct tty_struct
 
 	tty_ldisc_debug(tty, "released\n");
 }
+EXPORT_SYMBOL(tty_ldisc_release);
 
 /**
  *	tty_ldisc_init		-	ldisc setup for new tty
Index: linux-staging/include/uapi/linux/tty.h
===================================================================
--- linux-staging.orig/include/uapi/linux/tty.h
+++ linux-staging/include/uapi/linux/tty.h
@@ -35,5 +35,6 @@
 #define N_TRACESINK	23	/* Trace data routing for MIPI P1149.7 */
 #define N_TRACEROUTER	24	/* Trace data routing for MIPI P1149.7 */
 #define N_NCI		25	/* NFC NCI UART */
+#define N_SPEAKUP	26	/* Speakup communication with synths*/
 
 #endif /* _UAPI_LINUX_TTY_H */

Re: [patch 2/7] staging: speakup: add tty-based comms functions

[Samuel Thibault]

Okash Khawaja, on lun. 03 avril 2017 21:21:25 +0100, wrote:
> This adds spk_ttyio.c file. It contains a set of functions which implement
> those methods in spk_synth struct which relate to sending bytes out using
> serial comms. Implementations in this file perform the same function but
> using TTY subsystem instead. Currently synths access serial ports, directly
> poking standard ISA ports by trying to steal them from serial driver. Some ISA
> cards actually need this way of doing it, but most other synthesizers don't,
> and can actually work by using the proper TTY subsystem through a new N_SPEAKUP
> line discipline. So this adds the methods for drivers to switch to accessing
> serial ports through the TTY subsystem, whenever appropriate.
> 
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

Ditto.

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> 
> Index: linux-staging/drivers/staging/speakup/Makefile
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/Makefile
> +++ linux-staging/drivers/staging/speakup/Makefile
> @@ -25,6 +25,7 @@ speakup-y := \
>  	kobjects.o \
>  	selection.o \
>  	serialio.o \
> +	spk_ttyio.o \
>  	synth.o \
>  	thread.o \
>  	varhandlers.o
> Index: linux-staging/drivers/staging/speakup/spk_priv.h
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/spk_priv.h
> +++ linux-staging/drivers/staging/speakup/spk_priv.h
> @@ -46,6 +46,7 @@ int spk_wait_for_xmitr(struct spk_synth
>  unsigned char spk_serial_in(void);
>  unsigned char spk_serial_in_nowait(void);
>  void spk_serial_release(void);
> +void spk_ttyio_release(void);
>  
>  void synth_buffer_skip_nonlatin1(void);
>  u16 synth_buffer_getc(void);
> @@ -58,7 +59,9 @@ ssize_t spk_var_store(struct kobject *ko
>  		      const char *buf, size_t count);
>  
>  int spk_serial_synth_probe(struct spk_synth *synth);
> +int spk_ttyio_synth_probe(struct spk_synth *synth);
>  const char *spk_serial_synth_immediate(struct spk_synth *synth, const char *buff);
> +const char *spk_ttyio_synth_immediate(struct spk_synth *synth, const char *buff);
>  void spk_do_catch_up(struct spk_synth *synth);
>  void spk_synth_flush(struct spk_synth *synth);
>  int spk_synth_is_alive_nop(struct spk_synth *synth);
> @@ -79,5 +82,6 @@ extern struct speakup_info_t speakup_inf
>  extern struct var_t synth_time_vars[];
>  
>  extern struct spk_io_ops spk_serial_io_ops;
> +extern struct spk_io_ops spk_ttyio_ops;
>  
>  #endif
> Index: linux-staging/drivers/staging/speakup/spk_ttyio.c
> ===================================================================
> --- /dev/null
> +++ linux-staging/drivers/staging/speakup/spk_ttyio.c
> @@ -0,0 +1,143 @@
> +#include <linux/types.h>
> +#include <linux/tty.h>
> +
> +#include "speakup.h"
> +#include "spk_types.h"
> +
> +static struct tty_struct *speakup_tty;
> +
> +static int spk_ttyio_ldisc_open(struct tty_struct *tty)
> +{
> +	if (tty->ops->write == NULL)
> +		return -EOPNOTSUPP;
> +	speakup_tty = tty;
> +
> +	return 0;
> +}
> +
> +static void spk_ttyio_ldisc_close(struct tty_struct *tty)
> +{
> +	speakup_tty = NULL;
> +}
> +
> +static struct tty_ldisc_ops spk_ttyio_ldisc_ops = {
> +	.owner          = THIS_MODULE,
> +	.magic          = TTY_LDISC_MAGIC,
> +	.name           = "speakup_ldisc",
> +	.open           = spk_ttyio_ldisc_open,
> +	.close          = spk_ttyio_ldisc_close,
> +};
> +
> +static int spk_ttyio_out(struct spk_synth *in_synth, const char ch);
> +struct spk_io_ops spk_ttyio_ops = {
> +	.synth_out = spk_ttyio_out,
> +};
> +EXPORT_SYMBOL_GPL(spk_ttyio_ops);
> +
> +static int spk_ttyio_initialise_ldisc(int ser)
> +{
> +	int ret = 0;
> +	struct tty_struct *tty;
> +
> +	ret = tty_register_ldisc(N_SPEAKUP, &spk_ttyio_ldisc_ops);
> +	if (ret) {
> +		pr_err("Error registering line discipline.\n");
> +		return ret;
> +	}
> +
> +	if (ser < 0 || ser > (255 - 64)) {
> +		pr_err("speakup: Invalid ser param. Must be between 0 and 191 inclusive.\n");
> +		return -EINVAL;
> +	}
> +
> +	/* TODO: support more than ttyS* */
> +	tty = tty_open_by_driver(MKDEV(4, (ser +  64)), NULL, NULL);
> +	if (IS_ERR(tty))
> +		return PTR_ERR(tty);
> +
> +	if (tty->ops->open)
> +		ret = tty->ops->open(tty, NULL);
> +	else
> +		ret = -ENODEV;
> +
> +	if (ret) {
> +		tty_unlock(tty);
> +		return ret;
> +	}
> +
> +	clear_bit(TTY_HUPPED, &tty->flags);
> +	tty_unlock(tty);
> +
> +	ret = tty_set_ldisc(tty, N_SPEAKUP);
> +
> +	return ret;
> +}
> +
> +static int spk_ttyio_out(struct spk_synth *in_synth, const char ch)
> +{
> +	if (in_synth->alive && speakup_tty && speakup_tty->ops->write) {
> +		int ret = speakup_tty->ops->write(speakup_tty, &ch, 1);
> +		if (ret == 0)
> +			/* No room */
> +			return 0;
> +		if (ret < 0) {
> +			pr_warn("%s: I/O error, deactivating speakup\n", in_synth->long_name);
> +			/* No synth any more, so nobody will restart TTYs, and we thus
> +			 * need to do it ourselves.  Now that there is no synth we can
> +			 * let application flood anyway
> +			 */
> +			in_synth->alive = 0;
> +			speakup_start_ttys();
> +			return 0;
> +		}
> +		return 1;
> +	}
> +	return 0;
> +}
> +
> +int spk_ttyio_synth_probe(struct spk_synth *synth)
> +{
> +	int rv = spk_ttyio_initialise_ldisc(synth->ser);
> +
> +	if (rv)
> +		return rv;
> +
> +	synth->alive = 1;
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(spk_ttyio_synth_probe);
> +
> +void spk_ttyio_release(void)
> +{
> +	int idx;
> +
> +	if (!speakup_tty)
> +		return;
> +
> +	tty_lock(speakup_tty);
> +	idx = speakup_tty->index;
> +
> +	if (speakup_tty->ops->close)
> +		speakup_tty->ops->close(speakup_tty, NULL);
> +
> +	tty_ldisc_flush(speakup_tty);
> +	tty_unlock(speakup_tty);
> +	tty_ldisc_release(speakup_tty);
> +}
> +EXPORT_SYMBOL_GPL(spk_ttyio_release);
> +
> +const char *spk_ttyio_synth_immediate(struct spk_synth *synth, const char *buff)
> +{
> +	u_char ch;
> +
> +	while ((ch = *buff)) {
> +		if (ch == '\n')
> +			ch = synth->procspeech;
> +		if (tty_write_room(speakup_tty) < 1 || !synth->io_ops->synth_out(synth, ch))
> +			return buff;
> +		buff++;
> +	}
> +	return NULL;
> +}
> +EXPORT_SYMBOL_GPL(spk_ttyio_synth_immediate);
> Index: linux-staging/drivers/tty/tty_ldisc.c
> ===================================================================
> --- linux-staging.orig/drivers/tty/tty_ldisc.c
> +++ linux-staging/drivers/tty/tty_ldisc.c
> @@ -556,6 +556,7 @@ err:
>  	tty_unlock(tty);
>  	return retval;
>  }
> +EXPORT_SYMBOL(tty_set_ldisc);
>  
>  /**
>   *	tty_ldisc_kill	-	teardown ldisc
> @@ -744,6 +745,7 @@ void tty_ldisc_release(struct tty_struct
>  
>  	tty_ldisc_debug(tty, "released\n");
>  }
> +EXPORT_SYMBOL(tty_ldisc_release);
>  
>  /**
>   *	tty_ldisc_init		-	ldisc setup for new tty
> Index: linux-staging/include/uapi/linux/tty.h
> ===================================================================
> --- linux-staging.orig/include/uapi/linux/tty.h
> +++ linux-staging/include/uapi/linux/tty.h
> @@ -35,5 +35,6 @@
>  #define N_TRACESINK	23	/* Trace data routing for MIPI P1149.7 */
>  #define N_TRACEROUTER	24	/* Trace data routing for MIPI P1149.7 */
>  #define N_NCI		25	/* NFC NCI UART */
> +#define N_SPEAKUP	26	/* Speakup communication with synths*/
>  
>  #endif /* _UAPI_LINUX_TTY_H */
> 

-- 
Samuel
 >bah moi j'aime bien le flash et je cherche plus a comprendre
 >crosoft. Ca plante : je reinstalle
 Ca à le mérite de créer des emplois jeunes : "réinstalleur de crosoft"
 -+- BD in NPC : Bill Gates au secours de l'emploi -+-

[patch 3/7] staging: speakup: migrate acntsa, bns, dummy and txprt to ttyio

[Okash Khawaja]

[-- Attachment #1: 03_migrate_dummy_acntsa_bns_txprt_to_ttyio --]
[-- Type: text/plain, Size: 2781 bytes --]

This changes the above five synths to TTY-based comms. They were chosen as a
first pass because their serial comms are straightforward, i.e. they don't use
serial input and don't do internal port knocking.

Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

Index: linux-staging/drivers/staging/speakup/speakup_dummy.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_dummy.c
+++ linux-staging/drivers/staging/speakup/speakup_dummy.c
@@ -98,10 +98,10 @@ static struct spk_synth synth_dummy = {
 	.startup = SYNTH_START,
 	.checkval = SYNTH_CHECK,
 	.vars = vars,
-	.io_ops = &spk_serial_io_ops,
-	.probe = spk_serial_synth_probe,
-	.release = spk_serial_release,
-	.synth_immediate = spk_serial_synth_immediate,
+	.io_ops = &spk_ttyio_ops,
+	.probe = spk_ttyio_synth_probe,
+	.release = spk_ttyio_release,
+	.synth_immediate = spk_ttyio_synth_immediate,
 	.catch_up = spk_do_catch_up,
 	.flush = spk_synth_flush,
 	.is_alive = spk_synth_is_alive_restart,
Index: linux-staging/drivers/staging/speakup/speakup_acntsa.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_acntsa.c
+++ linux-staging/drivers/staging/speakup/speakup_acntsa.c
@@ -99,10 +99,10 @@ static struct spk_synth synth_acntsa = {
 	.startup = SYNTH_START,
 	.checkval = SYNTH_CHECK,
 	.vars = vars,
-	.io_ops = &spk_serial_io_ops,
+	.io_ops = &spk_ttyio_ops,
 	.probe = synth_probe,
-	.release = spk_serial_release,
-	.synth_immediate = spk_serial_synth_immediate,
+	.release = spk_ttyio_release,
+	.synth_immediate = spk_ttyio_synth_immediate,
 	.catch_up = spk_do_catch_up,
 	.flush = spk_synth_flush,
 	.is_alive = spk_synth_is_alive_restart,
@@ -125,7 +125,7 @@ static int synth_probe(struct spk_synth
 {
 	int failed;
 
-	failed = spk_serial_synth_probe(synth);
+	failed = spk_ttyio_synth_probe(synth);
 	if (failed == 0) {
 		synth->synth_immediate(synth, "\033=R\r");
 		mdelay(100);
Index: linux-staging/drivers/staging/speakup/speakup_txprt.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_txprt.c
+++ linux-staging/drivers/staging/speakup/speakup_txprt.c
@@ -95,10 +95,10 @@ static struct spk_synth synth_txprt = {
 	.startup = SYNTH_START,
 	.checkval = SYNTH_CHECK,
 	.vars = vars,
-	.io_ops = &spk_serial_io_ops,
-	.probe = spk_serial_synth_probe,
-	.release = spk_serial_release,
-	.synth_immediate = spk_serial_synth_immediate,
+	.io_ops = &spk_ttyio_ops,
+	.probe = spk_ttyio_synth_probe,
+	.release = spk_ttyio_release,
+	.synth_immediate = spk_ttyio_synth_immediate,
 	.catch_up = spk_do_catch_up,
 	.flush = spk_synth_flush,
 	.is_alive = spk_synth_is_alive_restart,

Re: [patch 3/7] staging: speakup: migrate acntsa, bns, dummy and txprt to ttyio

[Samuel Thibault]

Okash Khawaja, on lun. 03 avril 2017 21:21:26 +0100, wrote:
> This changes the above five synths to TTY-based comms. They were chosen as a
> first pass because their serial comms are straightforward, i.e. they don't use
> serial input and don't do internal port knocking.
> 
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> Index: linux-staging/drivers/staging/speakup/speakup_dummy.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_dummy.c
> +++ linux-staging/drivers/staging/speakup/speakup_dummy.c
> @@ -98,10 +98,10 @@ static struct spk_synth synth_dummy = {
>  	.startup = SYNTH_START,
>  	.checkval = SYNTH_CHECK,
>  	.vars = vars,
> -	.io_ops = &spk_serial_io_ops,
> -	.probe = spk_serial_synth_probe,
> -	.release = spk_serial_release,
> -	.synth_immediate = spk_serial_synth_immediate,
> +	.io_ops = &spk_ttyio_ops,
> +	.probe = spk_ttyio_synth_probe,
> +	.release = spk_ttyio_release,
> +	.synth_immediate = spk_ttyio_synth_immediate,
>  	.catch_up = spk_do_catch_up,
>  	.flush = spk_synth_flush,
>  	.is_alive = spk_synth_is_alive_restart,
> Index: linux-staging/drivers/staging/speakup/speakup_acntsa.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_acntsa.c
> +++ linux-staging/drivers/staging/speakup/speakup_acntsa.c
> @@ -99,10 +99,10 @@ static struct spk_synth synth_acntsa = {
>  	.startup = SYNTH_START,
>  	.checkval = SYNTH_CHECK,
>  	.vars = vars,
> -	.io_ops = &spk_serial_io_ops,
> +	.io_ops = &spk_ttyio_ops,
>  	.probe = synth_probe,
> -	.release = spk_serial_release,
> -	.synth_immediate = spk_serial_synth_immediate,
> +	.release = spk_ttyio_release,
> +	.synth_immediate = spk_ttyio_synth_immediate,
>  	.catch_up = spk_do_catch_up,
>  	.flush = spk_synth_flush,
>  	.is_alive = spk_synth_is_alive_restart,
> @@ -125,7 +125,7 @@ static int synth_probe(struct spk_synth
>  {
>  	int failed;
>  
> -	failed = spk_serial_synth_probe(synth);
> +	failed = spk_ttyio_synth_probe(synth);
>  	if (failed == 0) {
>  		synth->synth_immediate(synth, "\033=R\r");
>  		mdelay(100);
> Index: linux-staging/drivers/staging/speakup/speakup_txprt.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_txprt.c
> +++ linux-staging/drivers/staging/speakup/speakup_txprt.c
> @@ -95,10 +95,10 @@ static struct spk_synth synth_txprt = {
>  	.startup = SYNTH_START,
>  	.checkval = SYNTH_CHECK,
>  	.vars = vars,
> -	.io_ops = &spk_serial_io_ops,
> -	.probe = spk_serial_synth_probe,
> -	.release = spk_serial_release,
> -	.synth_immediate = spk_serial_synth_immediate,
> +	.io_ops = &spk_ttyio_ops,
> +	.probe = spk_ttyio_synth_probe,
> +	.release = spk_ttyio_release,
> +	.synth_immediate = spk_ttyio_synth_immediate,
>  	.catch_up = spk_do_catch_up,
>  	.flush = spk_synth_flush,
>  	.is_alive = spk_synth_is_alive_restart,
> 

-- 
Samuel
<L> pour moi le seul qui est autorisé à fasciser, c moi :-)

[patch 4/7] staging: speakup: add send_xchar and tiocmset methods

[Okash Khawaja]

[-- Attachment #1: 04_add_send_xchar_and_tiocmset_methods --]
[-- Type: text/plain, Size: 5405 bytes --]

This adds two methods to spk_synth struct: send_xchar and tiocmset, and
creates serial and tty implementations for each of them. For serial
implementation it takes existing code in apollo, audptr and spkout which
already fits the behaviour of send_xchar and tiocmset. For tty implementation,
it simply delegates to corresponding methods in tty->ops.

Rest of the changes simply make use of serial implementation of these two
functions.

Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

Index: linux-staging/drivers/staging/speakup/serialio.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/serialio.c
+++ linux-staging/drivers/staging/speakup/serialio.c
@@ -26,8 +26,13 @@ static const struct old_serial_port *ser
 static int timeouts;
 
 static int spk_serial_out(struct spk_synth *in_synth, const char ch);
+static void spk_serial_send_xchar(char ch);
+static void spk_serial_tiocmset(unsigned int set, unsigned int clear);
+
 struct spk_io_ops spk_serial_io_ops = {
 	.synth_out = spk_serial_out,
+	.send_xchar = spk_serial_send_xchar,
+	.tiocmset = spk_serial_tiocmset,
 };
 EXPORT_SYMBOL_GPL(spk_serial_io_ops);
 
@@ -136,6 +141,24 @@ static void start_serial_interrupt(int i
 	outb(1, speakup_info.port_tts + UART_FCR);	/* Turn FIFO On */
 }
 
+static void spk_serial_send_xchar(char ch)
+{
+	int timeout = SPK_XMITR_TIMEOUT;
+
+	while (spk_serial_tx_busy()) {
+		if (!--timeout)
+			break;
+		udelay(1);
+	}
+	outb(ch, speakup_info.port_tts);
+}
+
+static void spk_serial_tiocmset(unsigned int set, unsigned int clear)
+{
+	int old = inb(speakup_info.port_tts + UART_MCR);
+	outb((old & ~clear) | set, speakup_info.port_tts + UART_MCR);
+}
+
 int spk_serial_synth_probe(struct spk_synth *synth)
 {
 	const struct old_serial_port *ser;
Index: linux-staging/drivers/staging/speakup/speakup_apollo.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_apollo.c
+++ linux-staging/drivers/staging/speakup/speakup_apollo.c
@@ -171,9 +171,8 @@ static void do_catch_up(struct spk_synth
 		full_time_val = full_time->u.n.value;
 		spin_unlock_irqrestore(&speakup_info.spinlock, flags);
 		if (!synth->io_ops->synth_out(synth, ch)) {
-			outb(UART_MCR_DTR, speakup_info.port_tts + UART_MCR);
-			outb(UART_MCR_DTR | UART_MCR_RTS,
-			     speakup_info.port_tts + UART_MCR);
+			synth->io_ops->tiocmset(0, UART_MCR_RTS);
+			synth->io_ops->tiocmset(UART_MCR_RTS, 0);
 			schedule_timeout(msecs_to_jiffies(full_time_val));
 			continue;
 		}
Index: linux-staging/drivers/staging/speakup/speakup_audptr.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_audptr.c
+++ linux-staging/drivers/staging/speakup/speakup_audptr.c
@@ -128,14 +128,7 @@ static struct spk_synth synth_audptr = {
 
 static void synth_flush(struct spk_synth *synth)
 {
-	int timeout = SPK_XMITR_TIMEOUT;
-
-	while (spk_serial_tx_busy()) {
-		if (!--timeout)
-			break;
-		udelay(1);
-	}
-	outb(SYNTH_CLEAR, speakup_info.port_tts);
+	synth->io_ops->send_xchar(SYNTH_CLEAR);
 	synth->io_ops->synth_out(synth, PROCSPEECH);
 }
 
Index: linux-staging/drivers/staging/speakup/speakup_spkout.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_spkout.c
+++ linux-staging/drivers/staging/speakup/speakup_spkout.c
@@ -126,14 +126,7 @@ static struct spk_synth synth_spkout = {
 
 static void synth_flush(struct spk_synth *synth)
 {
-	int timeout = SPK_XMITR_TIMEOUT;
-
-	while (spk_serial_tx_busy()) {
-		if (!--timeout)
-			break;
-		udelay(1);
-	}
-	outb(SYNTH_CLEAR, speakup_info.port_tts);
+	synth->io_ops->send_xchar(SYNTH_CLEAR);
 }
 
 module_param_named(ser, synth_spkout.ser, int, 0444);
Index: linux-staging/drivers/staging/speakup/spk_ttyio.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/spk_ttyio.c
+++ linux-staging/drivers/staging/speakup/spk_ttyio.c
@@ -29,8 +29,13 @@ static struct tty_ldisc_ops spk_ttyio_ld
 };
 
 static int spk_ttyio_out(struct spk_synth *in_synth, const char ch);
+static void spk_ttyio_send_xchar(char ch);
+static void spk_ttyio_tiocmset(unsigned int set, unsigned int clear);
+
 struct spk_io_ops spk_ttyio_ops = {
 	.synth_out = spk_ttyio_out,
+	.send_xchar = spk_ttyio_send_xchar,
+	.tiocmset = spk_ttyio_tiocmset,
 };
 EXPORT_SYMBOL_GPL(spk_ttyio_ops);
 
@@ -95,6 +100,16 @@ static int spk_ttyio_out(struct spk_synt
 	return 0;
 }
 
+static void spk_ttyio_send_xchar(char ch)
+{
+	speakup_tty->ops->send_xchar(speakup_tty, ch);
+}
+
+static void spk_ttyio_tiocmset(unsigned int set, unsigned int clear)
+{
+	speakup_tty->ops->tiocmset(speakup_tty, set, clear);
+}
+
 int spk_ttyio_synth_probe(struct spk_synth *synth)
 {
 	int rv = spk_ttyio_initialise_ldisc(synth->ser);
Index: linux-staging/drivers/staging/speakup/spk_types.h
===================================================================
--- linux-staging.orig/drivers/staging/speakup/spk_types.h
+++ linux-staging/drivers/staging/speakup/spk_types.h
@@ -150,6 +150,8 @@ struct spk_synth;
 
 struct spk_io_ops {
 	int (*synth_out)(struct spk_synth *synth, const char ch);
+	void (*send_xchar)(char ch);
+	void (*tiocmset)(unsigned int set, unsigned int clear);
 };
 
 struct spk_synth {

Re: [patch 4/7] staging: speakup: add send_xchar and tiocmset methods

[Samuel Thibault]

Okash Khawaja, on lun. 03 avril 2017 21:21:27 +0100, wrote:
> This adds two methods to spk_synth struct: send_xchar and tiocmset, and
> creates serial and tty implementations for each of them. For serial
> implementation it takes existing code in apollo, audptr and spkout which
> already fits the behaviour of send_xchar and tiocmset. For tty implementation,
> it simply delegates to corresponding methods in tty->ops.
> 
> Rest of the changes simply make use of serial implementation of these two
> functions.
> 
> Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

This is so straight-forward :)

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

That said, you'll want to split this patch into the part that makes
serialio and existing drivers on the one hand (so that it can be moved
to the top of the series, and already submitted upstream), and the part
that adds tty support, which can be folded into the patch adding tty
support.

Samuel

> Index: linux-staging/drivers/staging/speakup/serialio.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/serialio.c
> +++ linux-staging/drivers/staging/speakup/serialio.c
> @@ -26,8 +26,13 @@ static const struct old_serial_port *ser
>  static int timeouts;
>  
>  static int spk_serial_out(struct spk_synth *in_synth, const char ch);
> +static void spk_serial_send_xchar(char ch);
> +static void spk_serial_tiocmset(unsigned int set, unsigned int clear);
> +
>  struct spk_io_ops spk_serial_io_ops = {
>  	.synth_out = spk_serial_out,
> +	.send_xchar = spk_serial_send_xchar,
> +	.tiocmset = spk_serial_tiocmset,
>  };
>  EXPORT_SYMBOL_GPL(spk_serial_io_ops);
>  
> @@ -136,6 +141,24 @@ static void start_serial_interrupt(int i
>  	outb(1, speakup_info.port_tts + UART_FCR);	/* Turn FIFO On */
>  }
>  
> +static void spk_serial_send_xchar(char ch)
> +{
> +	int timeout = SPK_XMITR_TIMEOUT;
> +
> +	while (spk_serial_tx_busy()) {
> +		if (!--timeout)
> +			break;
> +		udelay(1);
> +	}
> +	outb(ch, speakup_info.port_tts);
> +}
> +
> +static void spk_serial_tiocmset(unsigned int set, unsigned int clear)
> +{
> +	int old = inb(speakup_info.port_tts + UART_MCR);
> +	outb((old & ~clear) | set, speakup_info.port_tts + UART_MCR);
> +}
> +
>  int spk_serial_synth_probe(struct spk_synth *synth)
>  {
>  	const struct old_serial_port *ser;
> Index: linux-staging/drivers/staging/speakup/speakup_apollo.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_apollo.c
> +++ linux-staging/drivers/staging/speakup/speakup_apollo.c
> @@ -171,9 +171,8 @@ static void do_catch_up(struct spk_synth
>  		full_time_val = full_time->u.n.value;
>  		spin_unlock_irqrestore(&speakup_info.spinlock, flags);
>  		if (!synth->io_ops->synth_out(synth, ch)) {
> -			outb(UART_MCR_DTR, speakup_info.port_tts + UART_MCR);
> -			outb(UART_MCR_DTR | UART_MCR_RTS,
> -			     speakup_info.port_tts + UART_MCR);
> +			synth->io_ops->tiocmset(0, UART_MCR_RTS);
> +			synth->io_ops->tiocmset(UART_MCR_RTS, 0);
>  			schedule_timeout(msecs_to_jiffies(full_time_val));
>  			continue;
>  		}
> Index: linux-staging/drivers/staging/speakup/speakup_audptr.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_audptr.c
> +++ linux-staging/drivers/staging/speakup/speakup_audptr.c
> @@ -128,14 +128,7 @@ static struct spk_synth synth_audptr = {
>  
>  static void synth_flush(struct spk_synth *synth)
>  {
> -	int timeout = SPK_XMITR_TIMEOUT;
> -
> -	while (spk_serial_tx_busy()) {
> -		if (!--timeout)
> -			break;
> -		udelay(1);
> -	}
> -	outb(SYNTH_CLEAR, speakup_info.port_tts);
> +	synth->io_ops->send_xchar(SYNTH_CLEAR);
>  	synth->io_ops->synth_out(synth, PROCSPEECH);
>  }
>  
> Index: linux-staging/drivers/staging/speakup/speakup_spkout.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_spkout.c
> +++ linux-staging/drivers/staging/speakup/speakup_spkout.c
> @@ -126,14 +126,7 @@ static struct spk_synth synth_spkout = {
>  
>  static void synth_flush(struct spk_synth *synth)
>  {
> -	int timeout = SPK_XMITR_TIMEOUT;
> -
> -	while (spk_serial_tx_busy()) {
> -		if (!--timeout)
> -			break;
> -		udelay(1);
> -	}
> -	outb(SYNTH_CLEAR, speakup_info.port_tts);
> +	synth->io_ops->send_xchar(SYNTH_CLEAR);
>  }
>  
>  module_param_named(ser, synth_spkout.ser, int, 0444);
> Index: linux-staging/drivers/staging/speakup/spk_ttyio.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/spk_ttyio.c
> +++ linux-staging/drivers/staging/speakup/spk_ttyio.c
> @@ -29,8 +29,13 @@ static struct tty_ldisc_ops spk_ttyio_ld
>  };
>  
>  static int spk_ttyio_out(struct spk_synth *in_synth, const char ch);
> +static void spk_ttyio_send_xchar(char ch);
> +static void spk_ttyio_tiocmset(unsigned int set, unsigned int clear);
> +
>  struct spk_io_ops spk_ttyio_ops = {
>  	.synth_out = spk_ttyio_out,
> +	.send_xchar = spk_ttyio_send_xchar,
> +	.tiocmset = spk_ttyio_tiocmset,
>  };
>  EXPORT_SYMBOL_GPL(spk_ttyio_ops);
>  
> @@ -95,6 +100,16 @@ static int spk_ttyio_out(struct spk_synt
>  	return 0;
>  }
>  
> +static void spk_ttyio_send_xchar(char ch)
> +{
> +	speakup_tty->ops->send_xchar(speakup_tty, ch);
> +}
> +
> +static void spk_ttyio_tiocmset(unsigned int set, unsigned int clear)
> +{
> +	speakup_tty->ops->tiocmset(speakup_tty, set, clear);
> +}
> +
>  int spk_ttyio_synth_probe(struct spk_synth *synth)
>  {
>  	int rv = spk_ttyio_initialise_ldisc(synth->ser);
> Index: linux-staging/drivers/staging/speakup/spk_types.h
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/spk_types.h
> +++ linux-staging/drivers/staging/speakup/spk_types.h
> @@ -150,6 +150,8 @@ struct spk_synth;
>  
>  struct spk_io_ops {
>  	int (*synth_out)(struct spk_synth *synth, const char ch);
> +	void (*send_xchar)(char ch);
> +	void (*tiocmset)(unsigned int set, unsigned int clear);
>  };
>  
>  struct spk_synth {
> 

-- 
Samuel
<S> KK1 a 1 conseil de comment s'attaquer a du code java ou ya plus de 50 classes ? par kel bout ?
<B> le troisième
 -+- #ens-mim en stage -+-

[patch 5/7] staging: speakup: make input functionality swappable

[Okash Khawaja]

[-- Attachment #1: 05_make_input_functionality_swappable --]
[-- Type: text/plain, Size: 11222 bytes --]

This moves functions which take input from external synth, into struct
spk_io_ops. The calling code then uses serial implementation of those methods
through spk_io_ops. That way we can add a parallel TTY-based implementation and
simply replace serial with TTY. That is what the next patch in this series does.

speakup_decext.c has get_last_char function which reads the most recent
available character from the synth. This patch changes that by defining
read_buff_add callback method of spk_syth and letting that update the last_char
global character read from the synth. read_buff_add is called from ISR, so
there is a possibility for last_char to be stale. Therefore it is marked as
volatile.

Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>

Index: linux-staging/drivers/staging/speakup/serialio.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/serialio.c
+++ linux-staging/drivers/staging/speakup/serialio.c
@@ -28,11 +28,15 @@ static int timeouts;
 static int spk_serial_out(struct spk_synth *in_synth, const char ch);
 static void spk_serial_send_xchar(char ch);
 static void spk_serial_tiocmset(unsigned int set, unsigned int clear);
+static unsigned char spk_serial_in(void);
+static unsigned char spk_serial_in_nowait(void);
 
 struct spk_io_ops spk_serial_io_ops = {
 	.synth_out = spk_serial_out,
 	.send_xchar = spk_serial_send_xchar,
 	.tiocmset = spk_serial_tiocmset,
+	.synth_in = spk_serial_in,
+	.synth_in_nowait = spk_serial_in_nowait,
 };
 EXPORT_SYMBOL_GPL(spk_serial_io_ops);
 
@@ -240,7 +244,7 @@ int spk_wait_for_xmitr(struct spk_synth
 	return 1;
 }
 
-unsigned char spk_serial_in(void)
+static unsigned char spk_serial_in(void)
 {
 	int tmout = SPK_SERIAL_TIMEOUT;
 
@@ -253,9 +257,8 @@ unsigned char spk_serial_in(void)
 	}
 	return inb_p(speakup_info.port_tts + UART_RX);
 }
-EXPORT_SYMBOL_GPL(spk_serial_in);
 
-unsigned char spk_serial_in_nowait(void)
+static unsigned char spk_serial_in_nowait(void)
 {
 	unsigned char lsr;
 
@@ -264,7 +267,6 @@ unsigned char spk_serial_in_nowait(void)
 		return 0;
 	return inb_p(speakup_info.port_tts + UART_RX);
 }
-EXPORT_SYMBOL_GPL(spk_serial_in_nowait);
 
 static int spk_serial_out(struct spk_synth *in_synth, const char ch)
 {
Index: linux-staging/drivers/staging/speakup/speakup_audptr.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_audptr.c
+++ linux-staging/drivers/staging/speakup/speakup_audptr.c
@@ -138,11 +138,11 @@ static void synth_version(struct spk_syn
 	char synth_id[40] = "";
 
 	synth->synth_immediate(synth, "\x05[Q]");
-	synth_id[test] = spk_serial_in();
+	synth_id[test] = synth->io_ops->synth_in();
 	if (synth_id[test] == 'A') {
 		do {
 			/* read version string from synth */
-			synth_id[++test] = spk_serial_in();
+			synth_id[++test] = synth->io_ops->synth_in();
 		} while (synth_id[test] != '\n' && test < 32);
 		synth_id[++test] = 0x00;
 	}
Index: linux-staging/drivers/staging/speakup/speakup_dectlk.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_dectlk.c
+++ linux-staging/drivers/staging/speakup/speakup_dectlk.c
@@ -42,7 +42,7 @@ static inline int synth_full(void)
 static void do_catch_up(struct spk_synth *synth);
 static void synth_flush(struct spk_synth *synth);
 static void read_buff_add(u_char c);
-static unsigned char get_index(void);
+static unsigned char get_index(struct spk_synth *synth);
 
 static int in_escape;
 static int is_flushing;
@@ -163,7 +163,7 @@ static int is_indnum(u_char *ch)
 
 static u_char lastind;
 
-static unsigned char get_index(void)
+static unsigned char get_index(struct spk_synth *synth)
 {
 	u_char rv;
 
Index: linux-staging/drivers/staging/speakup/spk_priv.h
===================================================================
--- linux-staging.orig/drivers/staging/speakup/spk_priv.h
+++ linux-staging/drivers/staging/speakup/spk_priv.h
@@ -43,8 +43,6 @@
 const struct old_serial_port *spk_serial_init(int index);
 void spk_stop_serial_interrupt(void);
 int spk_wait_for_xmitr(struct spk_synth *in_synth);
-unsigned char spk_serial_in(void);
-unsigned char spk_serial_in_nowait(void);
 void spk_serial_release(void);
 void spk_ttyio_release(void);
 
Index: linux-staging/drivers/staging/speakup/spk_types.h
===================================================================
--- linux-staging.orig/drivers/staging/speakup/spk_types.h
+++ linux-staging/drivers/staging/speakup/spk_types.h
@@ -152,6 +152,8 @@ struct spk_io_ops {
 	int (*synth_out)(struct spk_synth *synth, const char ch);
 	void (*send_xchar)(char ch);
 	void (*tiocmset)(unsigned int set, unsigned int clear);
+	unsigned char (*synth_in)(void);
+	unsigned char (*synth_in_nowait)(void);
 };
 
 struct spk_synth {
@@ -182,7 +184,7 @@ struct spk_synth {
 	int (*is_alive)(struct spk_synth *synth);
 	int (*synth_adjust)(struct st_var_header *var);
 	void (*read_buff_add)(u_char);
-	unsigned char (*get_index)(void);
+	unsigned char (*get_index)(struct spk_synth *synth);
 	struct synth_indexing indexing;
 	int alive;
 	struct attribute_group attributes;
Index: linux-staging/drivers/staging/speakup/speakup_decext.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_decext.c
+++ linux-staging/drivers/staging/speakup/speakup_decext.c
@@ -30,20 +30,16 @@
 #define DRV_VERSION "2.14"
 #define SYNTH_CLEAR 0x03
 #define PROCSPEECH 0x0b
-static unsigned char last_char;
+static volatile unsigned char last_char;
 
-static inline u_char get_last_char(void)
+static void read_buff_add(u_char ch)
 {
-	u_char avail = inb_p(speakup_info.port_tts + UART_LSR) & UART_LSR_DR;
-
-	if (avail)
-		last_char = inb_p(speakup_info.port_tts + UART_RX);
-	return last_char;
+	last_char = ch;
 }
 
 static inline bool synth_full(void)
 {
-	return get_last_char() == 0x13;
+	return last_char == 0x13;
 }
 
 static void do_catch_up(struct spk_synth *synth);
@@ -135,7 +131,7 @@ static struct spk_synth synth_decext = {
 	.flush = synth_flush,
 	.is_alive = spk_synth_is_alive_restart,
 	.synth_adjust = NULL,
-	.read_buff_add = NULL,
+	.read_buff_add = read_buff_add,
 	.get_index = NULL,
 	.indexing = {
 		.command = NULL,
Index: linux-staging/drivers/staging/speakup/speakup_dtlk.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_dtlk.c
+++ linux-staging/drivers/staging/speakup/speakup_dtlk.c
@@ -37,6 +37,7 @@ static void dtlk_release(void);
 static const char *synth_immediate(struct spk_synth *synth, const char *buf);
 static void do_catch_up(struct spk_synth *synth);
 static void synth_flush(struct spk_synth *synth);
+static unsigned char get_index(struct spk_synth *synth);
 
 static int synth_lpc;
 static int port_forced;
@@ -138,7 +139,7 @@ static struct spk_synth synth_dtlk = {
 	.is_alive = spk_synth_is_alive_nop,
 	.synth_adjust = NULL,
 	.read_buff_add = NULL,
-	.get_index = spk_serial_in_nowait,
+	.get_index = get_index,
 	.indexing = {
 		.command = "\x01%di",
 		.lowindex = 1,
@@ -169,6 +170,11 @@ static inline bool synth_full(void)
 	return (synth_status & TTS_ALMOST_FULL) != 0;
 }
 
+static unsigned char get_index(struct spk_synth *synth)
+{
+	return synth->io_ops->synth_in_nowait();
+}
+
 static void spk_out(const char ch)
 {
 	int timeout = SPK_XMITR_TIMEOUT;
Index: linux-staging/drivers/staging/speakup/speakup_ltlk.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_ltlk.c
+++ linux-staging/drivers/staging/speakup/speakup_ltlk.c
@@ -27,6 +27,7 @@
 #define PROCSPEECH 0x0d
 
 static int synth_probe(struct spk_synth *synth);
+static unsigned char get_index(struct spk_synth *synth);
 
 static struct var_t vars[] = {
 	{ CAPS_START, .u.s = {"\x01+35p" } },
@@ -120,7 +121,7 @@ static struct spk_synth synth_ltlk = {
 	.is_alive = spk_synth_is_alive_restart,
 	.synth_adjust = NULL,
 	.read_buff_add = NULL,
-	.get_index = spk_serial_in_nowait,
+	.get_index = get_index,
 	.indexing = {
 		.command = "\x01%di",
 		.lowindex = 1,
@@ -133,6 +134,11 @@ static struct spk_synth synth_ltlk = {
 	},
 };
 
+static unsigned char get_index(struct spk_synth *synth)
+{
+	return synth->io_ops->synth_in_nowait();
+}
+
 /* interrogate the LiteTalk and print its settings */
 static void synth_interrogate(struct spk_synth *synth)
 {
@@ -141,7 +147,7 @@ static void synth_interrogate(struct spk
 
 	synth->synth_immediate(synth, "\x18\x01?");
 	for (i = 0; i < 50; i++) {
-		buf[i] = spk_serial_in();
+		buf[i] = synth->io_ops->synth_in();
 		if (i > 2 && buf[i] == 0x7f)
 			break;
 	}
Index: linux-staging/drivers/staging/speakup/speakup_soft.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_soft.c
+++ linux-staging/drivers/staging/speakup/speakup_soft.c
@@ -36,7 +36,7 @@
 static int softsynth_probe(struct spk_synth *synth);
 static void softsynth_release(void);
 static int softsynth_is_alive(struct spk_synth *synth);
-static unsigned char get_index(void);
+static unsigned char get_index(struct spk_synth *synth);
 
 static struct miscdevice synth_device, synthu_device;
 static int init_pos;
@@ -340,7 +340,7 @@ static unsigned int softsynth_poll(struc
 	return ret;
 }
 
-static unsigned char get_index(void)
+static unsigned char get_index(struct spk_synth *synth)
 {
 	int rv;
 
Index: linux-staging/drivers/staging/speakup/speakup_spkout.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_spkout.c
+++ linux-staging/drivers/staging/speakup/speakup_spkout.c
@@ -27,6 +27,7 @@
 #define PROCSPEECH '\r'
 
 static void synth_flush(struct spk_synth *synth);
+static unsigned char get_index(struct spk_synth *synth);
 
 static struct var_t vars[] = {
 	{ CAPS_START, .u.s = {"\x05P+" } },
@@ -111,7 +112,7 @@ static struct spk_synth synth_spkout = {
 	.is_alive = spk_synth_is_alive_restart,
 	.synth_adjust = NULL,
 	.read_buff_add = NULL,
-	.get_index = spk_serial_in_nowait,
+	.get_index = get_index,
 	.indexing = {
 		.command = "\x05[%c",
 		.lowindex = 1,
@@ -124,6 +125,11 @@ static struct spk_synth synth_spkout = {
 	},
 };
 
+static unsigned char get_index(struct spk_synth *synth)
+{
+	return synth->io_ops->synth_in_nowait();
+}
+
 static void synth_flush(struct spk_synth *synth)
 {
 	synth->io_ops->send_xchar(SYNTH_CLEAR);
Index: linux-staging/drivers/staging/speakup/synth.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/synth.c
+++ linux-staging/drivers/staging/speakup/synth.c
@@ -249,7 +249,7 @@ void spk_reset_index_count(int sc)
 	if (first)
 		first = 0;
 	else
-		synth->get_index();
+		synth->get_index(synth);
 	index_count = 0;
 	sentence_count = sc;
 }
@@ -282,7 +282,7 @@ void synth_insert_next_index(int sent_nu
 
 void spk_get_index_count(int *linecount, int *sentcount)
 {
-	int ind = synth->get_index();
+	int ind = synth->get_index(synth);
 
 	if (ind) {
 		sentence_count = ind % 10;

Re: [patch 5/7] staging: speakup: make input functionality swappable

[Samuel Thibault]

Hello,

Okash Khawaja, on lun. 03 avril 2017 21:21:28 +0100, wrote:
> Index: linux-staging/drivers/staging/speakup/speakup_decext.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_decext.c
> +++ linux-staging/drivers/staging/speakup/speakup_decext.c
> @@ -30,20 +30,16 @@
>  #define DRV_VERSION "2.14"
>  #define SYNTH_CLEAR 0x03
>  #define PROCSPEECH 0x0b
> -static unsigned char last_char;
> +static volatile unsigned char last_char;
>  
> -static inline u_char get_last_char(void)
> +static void read_buff_add(u_char ch)
>  {
> -	u_char avail = inb_p(speakup_info.port_tts + UART_LSR) & UART_LSR_DR;
> -
> -	if (avail)
> -		last_char = inb_p(speakup_info.port_tts + UART_RX);
> -	return last_char;
> +	last_char = ch;
>  }
>  
>  static inline bool synth_full(void)
>  {
> -	return get_last_char() == 0x13;
> +	return last_char == 0x13;
>  }
>  
>  static void do_catch_up(struct spk_synth *synth);
> @@ -135,7 +131,7 @@ static struct spk_synth synth_decext = {
>  	.flush = synth_flush,
>  	.is_alive = spk_synth_is_alive_restart,
>  	.synth_adjust = NULL,
> -	.read_buff_add = NULL,
> +	.read_buff_add = read_buff_add,
>  	.get_index = NULL,
>  	.indexing = {
>  		.command = NULL,

Ideally we'd have somebody test this. Perhaps write a separate mail
on speakup@linux-speakup.org with subject "decext testers wanted!" to
arrange with somebody who knows one for testing this.

> @@ -169,6 +170,11 @@ static inline bool synth_full(void)
>  	return (synth_status & TTS_ALMOST_FULL) != 0;
>  }
>  
> +static unsigned char get_index(struct spk_synth *synth)
> +{
> +	return synth->io_ops->synth_in_nowait();
> +}

This repeats several times and is already completely generic.  I would
say make this function a helper exported from synth.c, that drivers can
then just reference.

Samuel

[patch 6/7] staging: speakup: add TTY-based input functionality

[Okash Khawaja]

[-- Attachment #1: 06_add_tty_based_input --]
[-- Type: text/plain, Size: 5497 bytes --]

This patch introduces TTY-based input functionality. It does this by
introducing struct spk_ldisc_data. buf_free is used to prevent the last
read character from being overwritten before it is read. The semaphore is
used to signal to calling to that there is a new byte to be read, so the
calling code doesn't have to busy-wait for new bytes. All input comes in
through ldisc's receive_buf2 callback. This method calls read_buff_add method
of struct spk_synth if it is defined. Otherwise it stores one byte in a buffer
and signals the receivers. Memory barrier calls prevent any race conditions.

Signed-off by: Okash Khawaja <okash.khawaja@gmail.com>

Index: linux-staging/drivers/staging/speakup/spk_ttyio.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/spk_ttyio.c
+++ linux-staging/drivers/staging/speakup/spk_ttyio.c
@@ -1,41 +1,95 @@
 #include <linux/types.h>
 #include <linux/tty.h>
+#include <linux/tty_flip.h>
+#include <linux/slab.h>
 
 #include "speakup.h"
 #include "spk_types.h"
+#include "spk_priv.h"
 
+struct spk_ldisc_data {
+	char buf;
+	struct semaphore sem;
+	int buf_free;
+};
+
+static struct spk_synth *spk_ttyio_synth;
+/* TODO: make this part of synth and remove the global */
 static struct tty_struct *speakup_tty;
 
 static int spk_ttyio_ldisc_open(struct tty_struct *tty)
 {
+	struct spk_ldisc_data *ldisc_data;
+
 	if (tty->ops->write == NULL)
 		return -EOPNOTSUPP;
 	speakup_tty = tty;
 
+	ldisc_data = kmalloc(sizeof(struct spk_ldisc_data), GFP_KERNEL);
+	if (!ldisc_data) {
+		pr_err("speakup: Failed to allocate ldisc_data.\n");
+		return -ENOMEM;
+	}
+
+	sema_init(&ldisc_data->sem, 0);
+	ldisc_data->buf_free = 1;
+	speakup_tty->disc_data = ldisc_data;
+
 	return 0;
 }
 
 static void spk_ttyio_ldisc_close(struct tty_struct *tty)
 {
+	kfree(speakup_tty->disc_data);
 	speakup_tty = NULL;
 }
 
+static int spk_ttyio_receive_buf2(struct tty_struct *tty,
+		const unsigned char *cp, char *fp, int count)
+{
+	struct spk_ldisc_data *ldisc_data = (struct spk_ldisc_data *)tty->disc_data;
+
+	if (spk_ttyio_synth->read_buff_add) {
+		int i;
+		for (i = 0; i < count; i++)
+			spk_ttyio_synth->read_buff_add(cp[i]);
+
+		return count;
+	}
+
+	if (ldisc_data->buf_free == 0)
+		return 0;
+
+	mb();
+
+	ldisc_data->buf = cp[0];
+	ldisc_data->buf_free--;
+	up(&ldisc_data->sem);
+
+	return 1;
+}
+
 static struct tty_ldisc_ops spk_ttyio_ldisc_ops = {
 	.owner          = THIS_MODULE,
 	.magic          = TTY_LDISC_MAGIC,
 	.name           = "speakup_ldisc",
 	.open           = spk_ttyio_ldisc_open,
 	.close          = spk_ttyio_ldisc_close,
+	.receive_buf2	= spk_ttyio_receive_buf2,
 };
 
 static int spk_ttyio_out(struct spk_synth *in_synth, const char ch);
 static void spk_ttyio_send_xchar(char ch);
 static void spk_ttyio_tiocmset(unsigned int set, unsigned int clear);
+static unsigned char spk_ttyio_in(void);
+static unsigned char spk_ttyio_in_nowait(void);
 
 struct spk_io_ops spk_ttyio_ops = {
 	.synth_out = spk_ttyio_out,
 	.send_xchar = spk_ttyio_send_xchar,
 	.tiocmset = spk_ttyio_tiocmset,
+	.synth_in = spk_ttyio_in,
+	.synth_in_nowait = spk_ttyio_in_nowait,
 };
 EXPORT_SYMBOL_GPL(spk_ttyio_ops);
 
@@ -46,7 +100,7 @@
 
 	ret = tty_register_ldisc(N_SPEAKUP, &spk_ttyio_ldisc_ops);
 	if (ret) {
-		pr_err("Error registering line discipline.\n");
+		pr_err("speakup: Error registering line discipline.\n");
 		return ret;
 	}
 
@@ -110,6 +164,37 @@
 	speakup_tty->ops->tiocmset(speakup_tty, set, clear);
 }
 
+static unsigned char ttyio_in(int timeout)
+{
+	struct spk_ldisc_data *ldisc_data =
+		(struct spk_ldisc_data *)speakup_tty->disc_data;
+	char rv;
+
+	if (!down_timeout(&ldisc_data->sem, usecs_to_jiffies(timeout))) {
+		pr_warn("spk_ttyio: timeout (%d)  while waiting for input\n",
+				timeout);
+		return 0xff;
+	}
+
+	rv = ldisc_data->buf;
+	mb();
+	ldisc_data->buf_free = 1;
+	tty_schedule_flip(speakup_tty->port);
+	up(&ldisc_data->sem);
+
+	return rv;
+}
+
+static unsigned char spk_ttyio_in(void)
+{
+	return ttyio_in(SPK_SYNTH_TIMEOUT);
+}
+
+static unsigned char spk_ttyio_in_nowait(void)
+{
+	return ttyio_in(0);
+}
+
 int spk_ttyio_synth_probe(struct spk_synth *synth)
 {
 	int rv = spk_ttyio_initialise_ldisc(synth->ser);
@@ -118,6 +203,7 @@
 		return rv;
 
 	synth->alive = 1;
+	spk_ttyio_synth = synth;
 
 	return 0;
 }
Index: linux-staging/drivers/staging/speakup/serialio.h
===================================================================
--- linux-staging.orig/drivers/staging/speakup/serialio.h
+++ linux-staging/drivers/staging/speakup/serialio.h
@@ -8,6 +8,8 @@
 #endif
 #include <linux/serial_core.h>
 
+#include "spk_priv.h"
+
 /*
  * this is cut&paste from 8250.h. Get rid of the structure, the definitions
  * and this whole broken driver.
@@ -21,7 +23,7 @@
 };
 
 /* countdown values for serial timeouts in us */
-#define SPK_SERIAL_TIMEOUT 100000
+#define SPK_SERIAL_TIMEOUT SPK_SYNTH_TIMEOUT
 /* countdown values transmitter/dsr timeouts in us */
 #define SPK_XMITR_TIMEOUT 100000
 /* countdown values cts timeouts in us */
Index: linux-staging/drivers/staging/speakup/spk_priv.h
===================================================================
--- linux-staging.orig/drivers/staging/speakup/spk_priv.h
+++ linux-staging/drivers/staging/speakup/spk_priv.h
@@ -39,6 +39,7 @@
 #endif
 
 #define KT_SPKUP 15
+#define SPK_SYNTH_TIMEOUT 100000
 
 const struct old_serial_port *spk_serial_init(int index);
 void spk_stop_serial_interrupt(void);

Re: [patch 6/7] staging: speakup: add TTY-based input functionality

[Samuel Thibault]

Hello,

We need to add comments about the synchronization, added inline:

Okash Khawaja, on lun. 03 avril 2017 21:21:29 +0100, wrote:
> +static int spk_ttyio_receive_buf2(struct tty_struct *tty,
> +		const unsigned char *cp, char *fp, int count)
> +{
> +	struct spk_ldisc_data *ldisc_data = (struct spk_ldisc_data *)tty->disc_data;
> +
> +	if (spk_ttyio_synth->read_buff_add) {
> +		int i;
> +		for (i = 0; i < count; i++)
> +			spk_ttyio_synth->read_buff_add(cp[i]);
> +
> +		return count;
> +	}
> +
> +	if (ldisc_data->buf_free == 0)
                /* ttyio_in will tty_schedule_flip */
> +		return 0;
> +
        /* Make sure the consumer has read buf before we have seen
         * buf_free == 1 and overwrite buf */
> +	mb();
> +
> +	ldisc_data->buf = cp[0];
> +	ldisc_data->buf_free--;

Don't decrement, set to 0. Decrementing would make the reader think
that there is potential for multi-character support, but with such a
lightweight synchronization there can't be. The fact that buf_free is 1
allows the tty part to set it to 0, but not more.

> +static unsigned char ttyio_in(int timeout)
> +{
> +	struct spk_ldisc_data *ldisc_data =
> +		(struct spk_ldisc_data *)speakup_tty->disc_data;
> +	char rv;
> +
> +	if (!down_timeout(&ldisc_data->sem, usecs_to_jiffies(timeout))) {
> +		pr_warn("spk_ttyio: timeout (%d)  while waiting for input\n",
> +				timeout);
> +		return 0xff;
> +	}
> +
> +	rv = ldisc_data->buf;
        /* Make sure we have read buf before we set buf_free to let
	 * the producer overwrite it */
> +	mb();
> +	ldisc_data->buf_free = 1;
> +	tty_schedule_flip(speakup_tty->port);
> +	up(&ldisc_data->sem);

> Index: linux-staging/drivers/staging/speakup/spk_priv.h
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/spk_priv.h
> +++ linux-staging/drivers/staging/speakup/spk_priv.h
> @@ -39,6 +39,7 @@
>  #endif
>  
>  #define KT_SPKUP 15
> +#define SPK_SYNTH_TIMEOUT 100000

Please document the unit.

Samuel

Re: [patch 6/7] staging: speakup: add TTY-based input functionality

[Okash Khawaja]

On Mon, Apr 10, 2017 at 12:53:37AM +0200, Samuel Thibault wrote:
> Hello,
> 
> We need to add comments about the synchronization, added inline:
> 
> Okash Khawaja, on lun. 03 avril 2017 21:21:29 +0100, wrote:
> > +static int spk_ttyio_receive_buf2(struct tty_struct *tty,
> > +		const unsigned char *cp, char *fp, int count)
> > +{
> > +	struct spk_ldisc_data *ldisc_data = (struct spk_ldisc_data *)tty->disc_data;
> > +
> > +	if (spk_ttyio_synth->read_buff_add) {
> > +		int i;
> > +		for (i = 0; i < count; i++)
> > +			spk_ttyio_synth->read_buff_add(cp[i]);
> > +
> > +		return count;
> > +	}
> > +
> > +	if (ldisc_data->buf_free == 0)
>                 /* ttyio_in will tty_schedule_flip */
> > +		return 0;
> > +
>         /* Make sure the consumer has read buf before we have seen
>          * buf_free == 1 and overwrite buf */
> > +	mb();
> > +
> > +	ldisc_data->buf = cp[0];
> > +	ldisc_data->buf_free--;
> 
> Don't decrement, set to 0. Decrementing would make the reader think
> that there is potential for multi-character support, but with such a
> lightweight synchronization there can't be. The fact that buf_free is 1
> allows the tty part to set it to 0, but not more.
How about changing the type to bool and switching between true and false
only?

Re: [patch 6/7] staging: speakup: add TTY-based input functionality

[Samuel Thibault]

Okash Khawaja, on lun. 10 avril 2017 21:17:17 +0100, wrote:
> On Mon, Apr 10, 2017 at 12:53:37AM +0200, Samuel Thibault wrote:
> > We need to add comments about the synchronization, added inline:
> > 
> > Okash Khawaja, on lun. 03 avril 2017 21:21:29 +0100, wrote:
> > > +static int spk_ttyio_receive_buf2(struct tty_struct *tty,
> > > +		const unsigned char *cp, char *fp, int count)
> > > +{
> > > +	struct spk_ldisc_data *ldisc_data = (struct spk_ldisc_data *)tty->disc_data;
> > > +
> > > +	if (spk_ttyio_synth->read_buff_add) {
> > > +		int i;
> > > +		for (i = 0; i < count; i++)
> > > +			spk_ttyio_synth->read_buff_add(cp[i]);
> > > +
> > > +		return count;
> > > +	}
> > > +
> > > +	if (ldisc_data->buf_free == 0)
> >                 /* ttyio_in will tty_schedule_flip */
> > > +		return 0;
> > > +
> >         /* Make sure the consumer has read buf before we have seen
> >          * buf_free == 1 and overwrite buf */
> > > +	mb();
> > > +
> > > +	ldisc_data->buf = cp[0];
> > > +	ldisc_data->buf_free--;
> > 
> > Don't decrement, set to 0. Decrementing would make the reader think
> > that there is potential for multi-character support, but with such a
> > lightweight synchronization there can't be. The fact that buf_free is 1
> > allows the tty part to set it to 0, but not more.
> How about changing the type to bool and switching between true and false
> only?

Why not indeed.

Samuel

[patch 7/7] staging: speakup: migrate apollo, ltlk, audptr, decext, dectlk and spkout

[Okash Khawaja]

[-- Attachment #1: 07_migrate_apollo_ltlk_audptr_decext_dectlk_spkout --]
[-- Type: text/plain, Size: 6159 bytes --]

This patch simply uses the changes introduced in previous patches and migrates
apollo, ltlk, audptr, decext, spkout and dectlk. Migrations are straightforward
function pointer updates.

Signed-off by: Okash Khawaja <okash.khawaja@gmail.com>

Index: linux-staging/drivers/staging/speakup/speakup_apollo.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_apollo.c
+++ linux-staging/drivers/staging/speakup/speakup_apollo.c
@@ -22,9 +22,9 @@
 #include <linux/sched.h>
 #include <linux/timer.h>
 #include <linux/kthread.h>
+#include <linux/serial_reg.h>	/* for UART_MCR* constants */
 
 #include "spk_priv.h"
-#include "serialio.h"
 #include "speakup.h"
 
 #define DRV_VERSION "2.21"
@@ -108,10 +108,10 @@
 	.startup = SYNTH_START,
 	.checkval = SYNTH_CHECK,
 	.vars = vars,
-	.io_ops = &spk_serial_io_ops,
-	.probe = spk_serial_synth_probe,
-	.release = spk_serial_release,
-	.synth_immediate = spk_serial_synth_immediate,
+	.io_ops = &spk_ttyio_ops,
+	.probe = spk_ttyio_synth_probe,
+	.release = spk_ttyio_release,
+	.synth_immediate = spk_ttyio_synth_immediate,
 	.catch_up = do_catch_up,
 	.flush = spk_synth_flush,
 	.is_alive = spk_synth_is_alive_restart,
Index: linux-staging/drivers/staging/speakup/speakup_ltlk.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_ltlk.c
+++ linux-staging/drivers/staging/speakup/speakup_ltlk.c
@@ -20,7 +20,6 @@
  */
 #include "speakup.h"
 #include "spk_priv.h"
-#include "serialio.h"
 #include "speakup_dtlk.h" /* local header file for LiteTalk values */
 
 #define DRV_VERSION "2.11"
@@ -112,10 +111,10 @@
 	.startup = SYNTH_START,
 	.checkval = SYNTH_CHECK,
 	.vars = vars,
-	.io_ops = &spk_serial_io_ops,
+	.io_ops = &spk_ttyio_ops,
 	.probe = synth_probe,
-	.release = spk_serial_release,
-	.synth_immediate = spk_serial_synth_immediate,
+	.release = spk_ttyio_release,
+	.synth_immediate = spk_ttyio_synth_immediate,
 	.catch_up = spk_do_catch_up,
 	.flush = spk_synth_flush,
 	.is_alive = spk_synth_is_alive_restart,
@@ -165,7 +164,7 @@
 {
 	int failed = 0;
 
-	failed = spk_serial_synth_probe(synth);
+	failed = spk_ttyio_synth_probe(synth);
 	if (failed == 0)
 		synth_interrogate(synth);
 	synth->alive = !failed;
Index: linux-staging/drivers/staging/speakup/speakup_audptr.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_audptr.c
+++ linux-staging/drivers/staging/speakup/speakup_audptr.c
@@ -20,7 +20,6 @@
  */
 #include "spk_priv.h"
 #include "speakup.h"
-#include "serialio.h"
 
 #define DRV_VERSION "2.11"
 #define SYNTH_CLEAR 0x18 /* flush synth buffer */
@@ -104,10 +103,10 @@
 	.startup = SYNTH_START,
 	.checkval = SYNTH_CHECK,
 	.vars = vars,
-	.io_ops = &spk_serial_io_ops,
+	.io_ops = &spk_ttyio_ops,
 	.probe = synth_probe,
-	.release = spk_serial_release,
-	.synth_immediate = spk_serial_synth_immediate,
+	.release = spk_ttyio_release,
+	.synth_immediate = spk_ttyio_synth_immediate,
 	.catch_up = spk_do_catch_up,
 	.flush = synth_flush,
 	.is_alive = spk_synth_is_alive_restart,
@@ -154,7 +153,7 @@
 {
 	int failed;
 
-	failed = spk_serial_synth_probe(synth);
+	failed = spk_ttyio_synth_probe(synth);
 	if (failed == 0)
 		synth_version(synth);
 	synth->alive = !failed;
Index: linux-staging/drivers/staging/speakup/speakup_decext.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_decext.c
+++ linux-staging/drivers/staging/speakup/speakup_decext.c
@@ -24,12 +24,12 @@
 #include <linux/kthread.h>
 
 #include "spk_priv.h"
-#include "serialio.h"
 #include "speakup.h"
 
 #define DRV_VERSION "2.14"
 #define SYNTH_CLEAR 0x03
 #define PROCSPEECH 0x0b
+
 static volatile unsigned char last_char;
 
 static void read_buff_add(u_char ch)
@@ -123,10 +123,10 @@
 	.startup = SYNTH_START,
 	.checkval = SYNTH_CHECK,
 	.vars = vars,
-	.io_ops = &spk_serial_io_ops,
-	.probe = spk_serial_synth_probe,
-	.release = spk_serial_release,
-	.synth_immediate = spk_serial_synth_immediate,
+	.io_ops = &spk_ttyio_ops,
+	.probe = spk_ttyio_synth_probe,
+	.release = spk_ttyio_release,
+	.synth_immediate = spk_ttyio_synth_immediate,
 	.catch_up = do_catch_up,
 	.flush = synth_flush,
 	.is_alive = spk_synth_is_alive_restart,
Index: linux-staging/drivers/staging/speakup/speakup_spkout.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_spkout.c
+++ linux-staging/drivers/staging/speakup/speakup_spkout.c
@@ -20,7 +20,6 @@
  */
 #include "spk_priv.h"
 #include "speakup.h"
-#include "serialio.h"
 
 #define DRV_VERSION "2.11"
 #define SYNTH_CLEAR 0x18
@@ -103,10 +102,10 @@
 	.startup = SYNTH_START,
 	.checkval = SYNTH_CHECK,
 	.vars = vars,
-	.io_ops = &spk_serial_io_ops,
-	.probe = spk_serial_synth_probe,
-	.release = spk_serial_release,
-	.synth_immediate = spk_serial_synth_immediate,
+	.io_ops = &spk_ttyio_ops,
+	.probe = spk_ttyio_synth_probe,
+	.release = spk_ttyio_release,
+	.synth_immediate = spk_ttyio_synth_immediate,
 	.catch_up = spk_do_catch_up,
 	.flush = synth_flush,
 	.is_alive = spk_synth_is_alive_restart,
Index: linux-staging/drivers/staging/speakup/speakup_dectlk.c
===================================================================
--- linux-staging.orig/drivers/staging/speakup/speakup_dectlk.c
+++ linux-staging/drivers/staging/speakup/speakup_dectlk.c
@@ -27,7 +27,6 @@
 #include <linux/kthread.h>
 #include "speakup.h"
 #include "spk_priv.h"
-#include "serialio.h"
 
 #define DRV_VERSION "2.20"
 #define SYNTH_CLEAR 0x03
@@ -130,10 +129,10 @@
 	.vars = vars,
 	.default_pitch = ap_defaults,
 	.default_vol = g5_defaults,
-	.io_ops = &spk_serial_io_ops,
-	.probe = spk_serial_synth_probe,
-	.release = spk_serial_release,
-	.synth_immediate = spk_serial_synth_immediate,
+	.io_ops = &spk_ttyio_ops,
+	.probe = spk_ttyio_synth_probe,
+	.release = spk_ttyio_release,
+	.synth_immediate = spk_ttyio_synth_immediate,
 	.catch_up = do_catch_up,
 	.flush = synth_flush,
 	.is_alive = spk_synth_is_alive_restart,

Re: [patch 7/7] staging: speakup: migrate apollo, ltlk, audptr, decext, dectlk and spkout

[Samuel Thibault]

Okash Khawaja, on lun. 03 avril 2017 21:21:30 +0100, wrote:
> This patch simply uses the changes introduced in previous patches and migrates
> apollo, ltlk, audptr, decext, spkout and dectlk. Migrations are straightforward
> function pointer updates.
> 
> Signed-off by: Okash Khawaja <okash.khawaja@gmail.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

So that migrates the last drivers which we can (i.e. non-internal
synthesizers), right?  Congrats :)

> Index: linux-staging/drivers/staging/speakup/speakup_apollo.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_apollo.c
> +++ linux-staging/drivers/staging/speakup/speakup_apollo.c
> @@ -22,9 +22,9 @@
>  #include <linux/sched.h>
>  #include <linux/timer.h>
>  #include <linux/kthread.h>
> +#include <linux/serial_reg.h>	/* for UART_MCR* constants */
>  
>  #include "spk_priv.h"
> -#include "serialio.h"
>  #include "speakup.h"
>  
>  #define DRV_VERSION "2.21"
> @@ -108,10 +108,10 @@
>  	.startup = SYNTH_START,
>  	.checkval = SYNTH_CHECK,
>  	.vars = vars,
> -	.io_ops = &spk_serial_io_ops,
> -	.probe = spk_serial_synth_probe,
> -	.release = spk_serial_release,
> -	.synth_immediate = spk_serial_synth_immediate,
> +	.io_ops = &spk_ttyio_ops,
> +	.probe = spk_ttyio_synth_probe,
> +	.release = spk_ttyio_release,
> +	.synth_immediate = spk_ttyio_synth_immediate,
>  	.catch_up = do_catch_up,
>  	.flush = spk_synth_flush,
>  	.is_alive = spk_synth_is_alive_restart,
> Index: linux-staging/drivers/staging/speakup/speakup_ltlk.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_ltlk.c
> +++ linux-staging/drivers/staging/speakup/speakup_ltlk.c
> @@ -20,7 +20,6 @@
>   */
>  #include "speakup.h"
>  #include "spk_priv.h"
> -#include "serialio.h"
>  #include "speakup_dtlk.h" /* local header file for LiteTalk values */
>  
>  #define DRV_VERSION "2.11"
> @@ -112,10 +111,10 @@
>  	.startup = SYNTH_START,
>  	.checkval = SYNTH_CHECK,
>  	.vars = vars,
> -	.io_ops = &spk_serial_io_ops,
> +	.io_ops = &spk_ttyio_ops,
>  	.probe = synth_probe,
> -	.release = spk_serial_release,
> -	.synth_immediate = spk_serial_synth_immediate,
> +	.release = spk_ttyio_release,
> +	.synth_immediate = spk_ttyio_synth_immediate,
>  	.catch_up = spk_do_catch_up,
>  	.flush = spk_synth_flush,
>  	.is_alive = spk_synth_is_alive_restart,
> @@ -165,7 +164,7 @@
>  {
>  	int failed = 0;
>  
> -	failed = spk_serial_synth_probe(synth);
> +	failed = spk_ttyio_synth_probe(synth);
>  	if (failed == 0)
>  		synth_interrogate(synth);
>  	synth->alive = !failed;
> Index: linux-staging/drivers/staging/speakup/speakup_audptr.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_audptr.c
> +++ linux-staging/drivers/staging/speakup/speakup_audptr.c
> @@ -20,7 +20,6 @@
>   */
>  #include "spk_priv.h"
>  #include "speakup.h"
> -#include "serialio.h"
>  
>  #define DRV_VERSION "2.11"
>  #define SYNTH_CLEAR 0x18 /* flush synth buffer */
> @@ -104,10 +103,10 @@
>  	.startup = SYNTH_START,
>  	.checkval = SYNTH_CHECK,
>  	.vars = vars,
> -	.io_ops = &spk_serial_io_ops,
> +	.io_ops = &spk_ttyio_ops,
>  	.probe = synth_probe,
> -	.release = spk_serial_release,
> -	.synth_immediate = spk_serial_synth_immediate,
> +	.release = spk_ttyio_release,
> +	.synth_immediate = spk_ttyio_synth_immediate,
>  	.catch_up = spk_do_catch_up,
>  	.flush = synth_flush,
>  	.is_alive = spk_synth_is_alive_restart,
> @@ -154,7 +153,7 @@
>  {
>  	int failed;
>  
> -	failed = spk_serial_synth_probe(synth);
> +	failed = spk_ttyio_synth_probe(synth);
>  	if (failed == 0)
>  		synth_version(synth);
>  	synth->alive = !failed;
> Index: linux-staging/drivers/staging/speakup/speakup_decext.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_decext.c
> +++ linux-staging/drivers/staging/speakup/speakup_decext.c
> @@ -24,12 +24,12 @@
>  #include <linux/kthread.h>
>  
>  #include "spk_priv.h"
> -#include "serialio.h"
>  #include "speakup.h"
>  
>  #define DRV_VERSION "2.14"
>  #define SYNTH_CLEAR 0x03
>  #define PROCSPEECH 0x0b
> +
>  static volatile unsigned char last_char;
>  
>  static void read_buff_add(u_char ch)
> @@ -123,10 +123,10 @@
>  	.startup = SYNTH_START,
>  	.checkval = SYNTH_CHECK,
>  	.vars = vars,
> -	.io_ops = &spk_serial_io_ops,
> -	.probe = spk_serial_synth_probe,
> -	.release = spk_serial_release,
> -	.synth_immediate = spk_serial_synth_immediate,
> +	.io_ops = &spk_ttyio_ops,
> +	.probe = spk_ttyio_synth_probe,
> +	.release = spk_ttyio_release,
> +	.synth_immediate = spk_ttyio_synth_immediate,
>  	.catch_up = do_catch_up,
>  	.flush = synth_flush,
>  	.is_alive = spk_synth_is_alive_restart,
> Index: linux-staging/drivers/staging/speakup/speakup_spkout.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_spkout.c
> +++ linux-staging/drivers/staging/speakup/speakup_spkout.c
> @@ -20,7 +20,6 @@
>   */
>  #include "spk_priv.h"
>  #include "speakup.h"
> -#include "serialio.h"
>  
>  #define DRV_VERSION "2.11"
>  #define SYNTH_CLEAR 0x18
> @@ -103,10 +102,10 @@
>  	.startup = SYNTH_START,
>  	.checkval = SYNTH_CHECK,
>  	.vars = vars,
> -	.io_ops = &spk_serial_io_ops,
> -	.probe = spk_serial_synth_probe,
> -	.release = spk_serial_release,
> -	.synth_immediate = spk_serial_synth_immediate,
> +	.io_ops = &spk_ttyio_ops,
> +	.probe = spk_ttyio_synth_probe,
> +	.release = spk_ttyio_release,
> +	.synth_immediate = spk_ttyio_synth_immediate,
>  	.catch_up = spk_do_catch_up,
>  	.flush = synth_flush,
>  	.is_alive = spk_synth_is_alive_restart,
> Index: linux-staging/drivers/staging/speakup/speakup_dectlk.c
> ===================================================================
> --- linux-staging.orig/drivers/staging/speakup/speakup_dectlk.c
> +++ linux-staging/drivers/staging/speakup/speakup_dectlk.c
> @@ -27,7 +27,6 @@
>  #include <linux/kthread.h>
>  #include "speakup.h"
>  #include "spk_priv.h"
> -#include "serialio.h"
>  
>  #define DRV_VERSION "2.20"
>  #define SYNTH_CLEAR 0x03
> @@ -130,10 +129,10 @@
>  	.vars = vars,
>  	.default_pitch = ap_defaults,
>  	.default_vol = g5_defaults,
> -	.io_ops = &spk_serial_io_ops,
> -	.probe = spk_serial_synth_probe,
> -	.release = spk_serial_release,
> -	.synth_immediate = spk_serial_synth_immediate,
> +	.io_ops = &spk_ttyio_ops,
> +	.probe = spk_ttyio_synth_probe,
> +	.release = spk_ttyio_release,
> +	.synth_immediate = spk_ttyio_synth_immediate,
>  	.catch_up = do_catch_up,
>  	.flush = synth_flush,
>  	.is_alive = spk_synth_is_alive_restart,
> 

-- 
Samuel
<i> ben oui ce serait idiot, mais osb
  -+- m'en fous de faire un truc débile ! -+-

Re: [patch 7/7] staging: speakup: migrate apollo, ltlk, audptr, decext, dectlk and spkout

[Okash Khawaja]

On Sun, Apr 09, 2017 at 11:46:16PM +0200, Samuel Thibault wrote:
> Okash Khawaja, on lun. 03 avril 2017 21:21:30 +0100, wrote:
> > This patch simply uses the changes introduced in previous patches and migrates
> > apollo, ltlk, audptr, decext, spkout and dectlk. Migrations are straightforward
> > function pointer updates.
> > 
> > Signed-off by: Okash Khawaja <okash.khawaja@gmail.com>
> 
> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> 
> So that migrates the last drivers which we can (i.e. non-internal
> synthesizers), right?  Congrats :)
Yes :) The ones not migrated are acntpc, decpc, keypc and dtlk

Re: [patch 0/7] staging: speakup: migrate synths to use TTY-based comms

[Okash Khawaja]

[-- Attachment #1: Type: text/plain, Size: 1780 bytes --]

On Mon, Apr 03, 2017 at 09:21:23PM +0100, Okash Khawaja wrote:
> Hi,
> 
> This patchset migrates synths to use TTY-based comms instead of directly using
> serial i/o. The move doesn't cover those synths which do need direct access,
> e.g. some which talk over ISA.
> 
> Please note that this patchset applies on top of current staging-next branch of
> Greg Kroah-Hartman's tree as that contains some other changes to speakup and
> tty drivers that have recently gone in. So the first patch makes ammendments to
> TTY code which allows speakup to access and tty device. Next patch adds
> spk_ttyio.c which contains TTY-based initialisation and output functionality.
> Next patch migrates those synths which only use output: dummy, acntsa, bns and
> txprt. Then we add xchar and tiocmset functions. Next we rearrange the code
> such that input functionality is grouped under a few methods inside spk_synth
> and spk_io_ops structs. That paves the way for simple migration of other synths
> to TTY. The final patch does that for apollo, ltlk, audptr, decext, dectlk
> and spkout.
> 
> Thanks,
> Okash


Hi,

The staging-next tree wasn't working for me, specially the usb modules.
So I took following steps:

1. Switch to kernel versio 4.10.0 (I guess others upto 4.10.8 will be
fine)

2. Copy drivers/staging/speakup directory from staging-next tree to
overwrite the one in 4.10.0.

3. Use the patch I have attached as the first patch instead of the one
in this email series ([patch 1/7] staging: speakup: export
tty_open_by_driver).

4. Apply rest of the patches in this patchset.

That worked for me. As I have mentioned before, apollo and double talk
lt worked fine but I haven't done thorough testing. If you have
questions about applying patches, do let me know.

Thanks,
Okash

[-- Attachment #2: 01_enable_kernel_access_to_tty_device --]
[-- Type: text/plain, Size: 3191 bytes --]

^[[32mIndex: linux-stable/drivers/tty/tty_io.c^[[00m
===================================================================
^[[32m--- linux-stable.orig/drivers/tty/tty_io.c^[[00m
^[[32m+++ linux-stable/drivers/tty/tty_io.c^[[00m
^[[33m@@ -855,7 +855,7 @@^[[00m^[[35m^[[00m
 
 int tty_hung_up_p(struct file *filp)
 {
^[[35m-	return (filp->f_op == &hung_up_tty_fops);^[[00m
^[[36m+	return (filp && filp->f_op == &hung_up_tty_fops);^[[00m
 }
 
 EXPORT_SYMBOL(tty_hung_up_p);
^[[33m@@ -1368,7 +1368,10 @@^[[00m^[[35m^[[00m
 	struct tty_struct *tty;
 
 	if (driver->ops->lookup)
^[[35m-		tty = driver->ops->lookup(driver, file, idx);^[[00m
^[[36m+		if (!file)^[[00m
^[[36m+			tty = ERR_PTR(-EIO);^[[00m
^[[36m+		else^[[00m
^[[36m+			tty = driver->ops->lookup(driver, file, idx);^[[00m
 	else
 		tty = driver->ttys[idx];
 
^[[33m@@ -1986,7 +1989,7 @@^[[00m^[[35m^[[00m
 		struct tty_driver *console_driver = console_device(index);
 		if (console_driver) {
 			driver = tty_driver_kref_get(console_driver);
^[[35m-			if (driver) {^[[00m
^[[36m+			if (driver && filp) {^[[00m
 				/* Don't let /dev/console block */
 				filp->f_flags |= O_NONBLOCK;
 				break;
^[[33m@@ -2019,7 +2022,7 @@^[[00m^[[35m^[[00m
  *	  - concurrent tty driver removal w/ lookup
  *	  - concurrent tty removal from driver table
  */
^[[35m-static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,^[[00m
^[[36m+struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,^[[00m
 					     struct file *filp)
 {
 	struct tty_struct *tty;
^[[33m@@ -2064,6 +2067,7 @@^[[00m^[[35m^[[00m
 	tty_driver_kref_put(driver);
 	return tty;
 }
^[[36m+EXPORT_SYMBOL(tty_open_by_driver);^[[00m
 
 /**
  *	tty_open		-	open a tty device
^[[32mIndex: linux-stable/drivers/tty/tty_port.c^[[00m
===================================================================
^[[32m--- linux-stable.orig/drivers/tty/tty_port.c^[[00m
^[[32m+++ linux-stable/drivers/tty/tty_port.c^[[00m
^[[33m@@ -335,7 +335,7 @@^[[00m^[[35m^[[00m
  *	tty_port_block_til_ready	-	Waiting logic for tty open
  *	@port: the tty port being opened
  *	@tty: the tty device being bound
^[[35m- *	@filp: the file pointer of the opener^[[00m
^[[36m+ *	@filp: the file pointer of the opener or NULL^[[00m
  *
  *	Implement the core POSIX/SuS tty behaviour when opening a tty device.
  *	Handles:
^[[33m@@ -369,7 +369,7 @@^[[00m^[[35m^[[00m
 		tty_port_set_active(port, 1);
 		return 0;
 	}
^[[35m-	if (filp->f_flags & O_NONBLOCK) {^[[00m
^[[36m+	if (filp ==  NULL || filp->f_flags & O_NONBLOCK) {^[[00m
 		/* Indicate we are open */
 		if (C_BAUD(tty))
 			tty_port_raise_dtr_rts(port);
^[[32mIndex: linux-stable/include/linux/tty.h^[[00m
===================================================================
^[[32m--- linux-stable.orig/include/linux/tty.h^[[00m
^[[32m+++ linux-stable/include/linux/tty.h^[[00m
^[[33m@@ -394,6 +394,8 @@^[[00m^[[35m^[[00m
 /* tty_io.c */
 extern int __init tty_init(void);
 extern const char *tty_name(const struct tty_struct *tty);
^[[36m+extern struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,^[[00m
^[[36m+					     struct file *filp);^[[00m
 #else
 static inline void console_init(void)
 { }

Re: [patch 0/7] staging: speakup: migrate synths to use TTY-based comms

[Okash Khawaja]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

Patch correctly re-attached. Sorry about the trouble.

On Mon, Apr 03, 2017 at 09:39:25PM +0100, Okash Khawaja wrote:
> 
> 
> Hi,
> 
> The staging-next tree wasn't working for me, specially the usb modules.
> So I took following steps:
> 
> 1. Switch to kernel versio 4.10.0 (I guess others upto 4.10.8 will be
> fine)
> 
> 2. Copy drivers/staging/speakup directory from staging-next tree to
> overwrite the one in 4.10.0.
> 
> 3. Use the patch I have attached as the first patch instead of the one
> in this email series ([patch 1/7] staging: speakup: export
> tty_open_by_driver).
> 
> 4. Apply rest of the patches in this patchset.
> 
> That worked for me. As I have mentioned before, apollo and double talk
> lt worked fine but I haven't done thorough testing. If you have
> questions about applying patches, do let me know.
> 
> Thanks,
> Okash

[-- Attachment #2: 01_enable_kernel_access_to_tty_device --]
[-- Type: text/plain, Size: 2675 bytes --]

Index: linux-4.10.1/drivers/tty/tty_io.c
===================================================================
--- linux-4.10.1.orig/drivers/tty/tty_io.c
+++ linux-4.10.1/drivers/tty/tty_io.c
@@ -855,7 +855,7 @@
 
 int tty_hung_up_p(struct file *filp)
 {
-	return (filp->f_op == &hung_up_tty_fops);
+	return (filp && filp->f_op == &hung_up_tty_fops);
 }
 
 EXPORT_SYMBOL(tty_hung_up_p);
@@ -1368,7 +1368,10 @@
 	struct tty_struct *tty;
 
 	if (driver->ops->lookup)
-		tty = driver->ops->lookup(driver, file, idx);
+		if (!file)
+			tty = ERR_PTR(-EIO);
+		else
+			tty = driver->ops->lookup(driver, file, idx);
 	else
 		tty = driver->ttys[idx];
 
@@ -1986,7 +1989,7 @@
 		struct tty_driver *console_driver = console_device(index);
 		if (console_driver) {
 			driver = tty_driver_kref_get(console_driver);
-			if (driver) {
+			if (driver && filp) {
 				/* Don't let /dev/console block */
 				filp->f_flags |= O_NONBLOCK;
 				break;
@@ -2019,7 +2022,7 @@
  *	  - concurrent tty driver removal w/ lookup
  *	  - concurrent tty removal from driver table
  */
-static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
+struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
 					     struct file *filp)
 {
 	struct tty_struct *tty;
@@ -2064,6 +2067,7 @@
 	tty_driver_kref_put(driver);
 	return tty;
 }
+EXPORT_SYMBOL(tty_open_by_driver);
 
 /**
  *	tty_open		-	open a tty device
Index: linux-4.10.1/drivers/tty/tty_port.c
===================================================================
--- linux-4.10.1.orig/drivers/tty/tty_port.c
+++ linux-4.10.1/drivers/tty/tty_port.c
@@ -335,7 +335,7 @@
  *	tty_port_block_til_ready	-	Waiting logic for tty open
  *	@port: the tty port being opened
  *	@tty: the tty device being bound
- *	@filp: the file pointer of the opener
+ *	@filp: the file pointer of the opener or NULL
  *
  *	Implement the core POSIX/SuS tty behaviour when opening a tty device.
  *	Handles:
@@ -369,7 +369,7 @@
 		tty_port_set_active(port, 1);
 		return 0;
 	}
-	if (filp->f_flags & O_NONBLOCK) {
+	if (filp ==  NULL || filp->f_flags & O_NONBLOCK) {
 		/* Indicate we are open */
 		if (C_BAUD(tty))
 			tty_port_raise_dtr_rts(port);
Index: linux-4.10.1/include/linux/tty.h
===================================================================
--- linux-4.10.1.orig/include/linux/tty.h
+++ linux-4.10.1/include/linux/tty.h
@@ -394,6 +394,8 @@
 /* tty_io.c */
 extern int __init tty_init(void);
 extern const char *tty_name(const struct tty_struct *tty);
+extern struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode,
+					     struct file *filp);
 #else
 static inline void console_init(void)
 { }