From: Okash Khawaja <okash.khawaja@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: speakup@linux-speakup.org
Subject: Re: [patch 6/6] staging: speakup: Migrate acntsa, bns, dectlk and txprt to ttyio
Date: Fri, 24 Mar 2017 19:40:42 +0000 [thread overview]
Message-ID: <20170324194042.GA2809@sanghar> (raw)
In-Reply-To: <20170324192422.24csr5vel3lyh7a7@var.youpi.perso.aquilenet.fr>
On Fri, Mar 24, 2017 at 08:24:22PM +0100, Samuel Thibault wrote:
> Okash Khawaja, on ven. 24 mars 2017 19:21:54 +0000, wrote:
> > On Sun, Feb 26, 2017 at 03:59:30AM +0100, Samuel Thibault wrote:
> > > and then in speakup_apollo.c, instead of
> > >
> > > outb(UART_MCR_DTR, speakup_info.port_tts + UART_MCR);
> > > outb(UART_MCR_DTR | UART_MCR_RTS,
> > > speakup_info.port_tts + UART_MCR);
> >
> > Is there a specific reason for keeping DTR set all the time? Or is it
> > just a defensive measure?
>
> I guess the device requires it. That's normal RS232 signaling anyway.
> With tiocmset, however, you won't have to care: the generic code will
> already have enabled DTR, and you will only want to clear and set RTS.
I noticed that spk_serial_init sets it and other places keep it set. By
generic code, do you mean that when migrated to TTY, we don't have to
explicitly set DTR?
>
> Samuel
next prev parent reply other threads:[~ UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
[patch 0/6] staging: speakup: Introduce TTY-based comms Okash Khawaja
` [patch 1/6] tty_port: allow a port to be opened with a tty that has no file handle Okash Khawaja
` Samuel Thibault
` Samuel Thibault
` John Covici
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
[not found] ` <20170225192358.GA4499@sanghar>
` [patch 3/6] staging: speakup: refactor spk_stop_serial_interrupt Okash Khawaja
` [patch 4/6] staging: speakup: Add spk_ttyio Okash Khawaja
` [patch 5/6] staging: speakup: Make speakup_dummy use ttyio Okash Khawaja
` [patch 6/6] staging: speakup: Migrate acntsa, bns, dectlk and txprt to ttyio Okash Khawaja
` Samuel Thibault
` Samuel Thibault
` Samuel Thibault
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` Samuel Thibault
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja [this message]
` Samuel Thibault
` Samuel Thibault
` Samuel Thibault
` [patch 4/6] staging: speakup: Add spk_ttyio Samuel Thibault
` Samuel Thibault
` [patch 3/6] staging: speakup: refactor spk_stop_serial_interrupt Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` [patch 2/6] staging: speakup: Add serial_out method Samuel Thibault
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` [patch 0/6] staging: speakup: Introduce TTY-based comms Trevor Astrope
` Okash Khawaja
` Samuel Thibault
` Samuel Thibault
` Samuel Thibault
` Read this first :) " Samuel Thibault
` Okash Khawaja
` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324194042.GA2809@sanghar \
--to=okash.khawaja@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).