From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 71EEA1F0561; Fri, 24 Mar 2017 15:40:50 -0400 (EDT) Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) by befuddled.reisers.ca (Postfix) with ESMTPS id ED0B21F0533 for ; Fri, 24 Mar 2017 15:40:48 -0400 (EDT) Received: by mail-wr0-x242.google.com with SMTP id u1so1861905wra.3 for ; Fri, 24 Mar 2017 12:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Dr2rK8eBrE8yhf09dGL2Z67mgnWZvRew22YLLwmmmxI=; b=QlpCVa5Ue4nssQbNsUwodSzEQ5h1yWAWL7H+Tx6uOWQpNm1QDhCPqJV95GD8kZnzkJ ikf8/sx+jWVh0a1DoO1Q7hFxjL8kJ24k1BiZENfSE6rKWiKryXFd4dV2kqOaDTXbOShF N0PbXB5PFTK7fKDHpZHK0BPGLyXaB0tQDfGOML/yADvZBteWt3YSnEqTSAj92+ZVnXq5 CZgJg914atv9ywsm8PUWpQdNXTajgBu5O14zoMt3JQ4tF6I93F7UbG6MX/l2sL96yYOd zoA2WGJN9cAcu7boD/HZHjhk4e3W9KFaxvZ16Ba1TCiRuZdnwTgu99CLp8jr4auerIR2 Ejhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Dr2rK8eBrE8yhf09dGL2Z67mgnWZvRew22YLLwmmmxI=; b=lH9qar4c7w33w61+/YUHkNcW9scfu19t/mwwdRycvtobGDI4R3clNwaGp0w07D2dGX ScY/0RVRN6I23iezzTl2ImqxLyU8eiTSQ8fJrSgtU9WboGNXsoTw1kRVdiXokkbXnZ/c 4wQSeZdl1TFpeBzLKDaXu+78YVwRrB4+ccjbk+7Udz9bgobdMNIqlosqMfJe94Cgyo3d 9E+GNi2yqDBv6ib1frcNnrzVxkIU6h5yn8ZTr/ibVV/TjvfW5DKnfWjmxl3NLOQuqP/O Q2nCepBR5AFllOkZcZssevzDLEmrEoNerE96DumOTtueFpRHxFgAjhdmv+VG446LWEBU CB6w== X-Gm-Message-State: AFeK/H0vIDKQTJWLwlNQjWgPZgtUQQA0UkQ+iQpURpcX6rrjziLiKJR1v6yd/atcaf5XFQ== X-Received: by 10.223.161.78 with SMTP id r14mr9553833wrr.101.1490384444437; Fri, 24 Mar 2017 12:40:44 -0700 (PDT) Received: from sanghar (92.40.249.83.threembb.co.uk. [92.40.249.83]) by smtp.gmail.com with ESMTPSA id z79sm4059941wrc.2.2017.03.24.12.40.43 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Mar 2017 12:40:43 -0700 (PDT) Date: Fri, 24 Mar 2017 19:40:42 +0000 From: Okash Khawaja To: Samuel Thibault Cc: speakup@linux-speakup.org Subject: Re: [patch 6/6] staging: speakup: Migrate acntsa, bns, dectlk and txprt to ttyio Message-ID: <20170324194042.GA2809@sanghar> References: <20170225192842.GA4519@sanghar> <20170225193031.GA4525@sanghar> <20170226025930.ftr43ridqfg3az5r@var.youpi.perso.aquilenet.fr> <20170324192154.GA2484@sanghar> <20170324192422.24csr5vel3lyh7a7@var.youpi.perso.aquilenet.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170324192422.24csr5vel3lyh7a7@var.youpi.perso.aquilenet.fr> User-Agent: Mutt/1.7.2 (2016-11-26) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 19:40:50 -0000 On Fri, Mar 24, 2017 at 08:24:22PM +0100, Samuel Thibault wrote: > Okash Khawaja, on ven. 24 mars 2017 19:21:54 +0000, wrote: > > On Sun, Feb 26, 2017 at 03:59:30AM +0100, Samuel Thibault wrote: > > > and then in speakup_apollo.c, instead of > > > > > > outb(UART_MCR_DTR, speakup_info.port_tts + UART_MCR); > > > outb(UART_MCR_DTR | UART_MCR_RTS, > > > speakup_info.port_tts + UART_MCR); > > > > Is there a specific reason for keeping DTR set all the time? Or is it > > just a defensive measure? > > I guess the device requires it. That's normal RS232 signaling anyway. > With tiocmset, however, you won't have to care: the generic code will > already have enabled DTR, and you will only want to clear and set RTS. I noticed that spk_serial_init sets it and other places keep it set. By generic code, do you mean that when migrated to TTY, we don't have to explicitly set DTR? > > Samuel