* [patch 0/8] staging: speakup: introduce tty-based comms
@ okash.khawaja
` Okash Khawaja
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: okash.khawaja @ UTC (permalink / raw)
To: speakup
Hi,
This patchset introduces a TTY-based way for the synths to communicate
with devices as an alternate for direct serial comms used by the synths
at the moment. It then migrates some of the synths to the TTY-based
comms. Synths migrated in this patchset are dummy, acntsa, bns and
txprt.
The last patch also migrates ltlk with some temporary modification which
means that initial info from synth won't be retried. This shouldn't affect
normal functionality of the synth. We won't be sending lkml migration
to LKML, however it will be good to test it here.
I have also added the "TODO: support more than ttyS*" next to MKDEV line in
spk_ttyio.c, which was discussed last time but I hadn't put in.
Finally, please note that these apply cleanly on top of the latest staging
tree, which includes unicode changes recently merged.
Thanks,
Okash
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch 0/8] staging: speakup: introduce tty-based comms
[patch 0/8] staging: speakup: introduce tty-based comms okash.khawaja
@ ` Okash Khawaja
` John Covici
` Samuel Thibault
2 siblings, 0 replies; 8+ messages in thread
From: Okash Khawaja @ UTC (permalink / raw)
To: speakup
Couple of typos corrected below..
On Sun, Mar 12, 2017 at 12:16:44PM +0000, okash.khawaja@gmail.com wrote:
> Hi,
>
> This patchset introduces a TTY-based way for the synths to communicate
> with devices as an alternate for direct serial comms used by the synths
> at the moment. It then migrates some of the synths to the TTY-based
> comms. Synths migrated in this patchset are dummy, acntsa, bns and
> txprt.
>
> The last patch also migrates ltlk with some temporary modification which
> means that initial info from synth won't be retried. This shouldn't affect
means that initial info from synth won't be retrieved**.
> normal functionality of the synth. We won't be sending lkml migration
We won't be sending ltlk** migration
> to LKML, however it will be good to test it here.
>
> I have also added the "TODO: support more than ttyS*" next to MKDEV line in
> spk_ttyio.c, which was discussed last time but I hadn't put in.
>
> Finally, please note that these apply cleanly on top of the latest staging
> tree, which includes unicode changes recently merged.
>
> Thanks,
> Okash
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch 0/8] staging: speakup: introduce tty-based comms
[patch 0/8] staging: speakup: introduce tty-based comms okash.khawaja
` Okash Khawaja
@ ` John Covici
` Samuel Thibault
` Samuel Thibault
2 siblings, 1 reply; 8+ messages in thread
From: John Covici @ UTC (permalink / raw)
To: Speakup is a screen review system for Linux.
The one thing that will not work under these patches is indexing,
which I use all the time, so I hope you can integrate that soon. I
use the speakout synth.
On Sun, 12 Mar 2017 08:16:44 -0400,
okash.khawaja@gmail.com wrote:
>
> Hi,
>
> This patchset introduces a TTY-based way for the synths to communicate
> with devices as an alternate for direct serial comms used by the synths
> at the moment. It then migrates some of the synths to the TTY-based
> comms. Synths migrated in this patchset are dummy, acntsa, bns and
> txprt.
>
> The last patch also migrates ltlk with some temporary modification which
> means that initial info from synth won't be retried. This shouldn't affect
> normal functionality of the synth. We won't be sending lkml migration
> to LKML, however it will be good to test it here.
>
> I have also added the "TODO: support more than ttyS*" next to MKDEV line in
> spk_ttyio.c, which was discussed last time but I hadn't put in.
>
> Finally, please note that these apply cleanly on top of the latest staging
> tree, which includes unicode changes recently merged.
>
> Thanks,
> Okash
> _______________________________________________
> Speakup mailing list
> Speakup@linux-speakup.org
> http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
>
--
Your life is like a penny. You're going to lose it. The question is:
How do
you spend it?
John Covici
covici@ccs.covici.com
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch 0/8] staging: speakup: introduce tty-based comms
` John Covici
@ ` Samuel Thibault
0 siblings, 0 replies; 8+ messages in thread
From: Samuel Thibault @ UTC (permalink / raw)
To: covici, Speakup is a screen review system for Linux.
John Covici, on dim. 12 mars 2017 08:38:00 -0400, wrote:
> The one thing that will not work under these patches is indexing,
Sure, we know :)
We just start the TTY ball rolling with output for now, while we work on
input (which will not pose more questions from linux maintainers) :)
Samuel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch 0/8] staging: speakup: introduce tty-based comms
[patch 0/8] staging: speakup: introduce tty-based comms okash.khawaja
` Okash Khawaja
` John Covici
@ ` Samuel Thibault
` Okash Khawaja
2 siblings, 1 reply; 8+ messages in thread
From: Samuel Thibault @ UTC (permalink / raw)
To: okash.khawaja; +Cc: speakup
Hello,
okash.khawaja@gmail.com, on dim. 12 mars 2017 12:16:44 +0000, wrote:
> This patchset introduces a TTY-based way for the synths to communicate
> with devices
Ok, this looks good to me. Now you need to submit it. The
./scripts/get_maintainer.pl script applied to the various patches gives
the following list of recipients:
For the tty stuff:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:TTY LAYER)
Jiri Slaby <jslaby@suse.com> (supporter:TTY LAYER)
linux-kernel@vger.kernel.org (open list)
For the speakup stuff:
William Hubbs <w.d.hubbs@gmail.com> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
Chris Brannon <chris@the-brannons.com> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
Kirk Reiser <kirk@reisers.ca> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
Samuel Thibault <samuel.thibault@ens-lyon.org> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:STAGING SUBSYSTEM)
speakup@linux-speakup.org (open list:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
That looks reasonable to me, give these as Cc to quilt, and Greg & Jiri
as To to catch their attention.
About the non-threaded thing, I believe that's because you didn't use
the --reply-to option. So the idea would be to prepare your quilt
command, then write your "patch 0/7" mail, and once you have posted it,
pass the Message-Id to the --reply-to parameter of your quilt command.
In your "patch 0/7" mail, mention that this patch series is meant to
open the discussion about the changes proposed in patch 1 and how they
are used in patch 6.
Thanks!
Samuel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch 0/8] staging: speakup: introduce tty-based comms
` Samuel Thibault
@ ` Okash Khawaja
` Samuel Thibault
0 siblings, 1 reply; 8+ messages in thread
From: Okash Khawaja @ UTC (permalink / raw)
To: Samuel Thibault; +Cc: Speakup is a screen review system for Linux.
On Sun, Mar 12, 2017 at 12:42 PM, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
> Hello,
>
> okash.khawaja@gmail.com, on dim. 12 mars 2017 12:16:44 +0000, wrote:
>> This patchset introduces a TTY-based way for the synths to communicate
>> with devices
>
> Ok, this looks good to me. Now you need to submit it. The
> ./scripts/get_maintainer.pl script applied to the various patches gives
> the following list of recipients:
Thanks! I'll also cc Alan Cox for the first patch, as you suggested earlier.
>
> For the tty stuff:
>
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:TTY LAYER)
> Jiri Slaby <jslaby@suse.com> (supporter:TTY LAYER)
> linux-kernel@vger.kernel.org (open list)
>
> For the speakup stuff:
>
> William Hubbs <w.d.hubbs@gmail.com> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
> Chris Brannon <chris@the-brannons.com> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
> Kirk Reiser <kirk@reisers.ca> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
> Samuel Thibault <samuel.thibault@ens-lyon.org> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:STAGING SUBSYSTEM)
> speakup@linux-speakup.org (open list:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
> devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
>
> That looks reasonable to me, give these as Cc to quilt, and Greg & Jiri
> as To to catch their attention.
>
> About the non-threaded thing, I believe that's because you didn't use
> the --reply-to option.
Yes, I didn't use --reply-to but according to /usr/share/doc/quilt/README.MAIL:
"Each message is assigned a unique Message-Id header, and all messages
other than the introduction are made to refer to the introduction (using
a References header) for proper message threading in mail clients."
> So the idea would be to prepare your quilt
> command, then write your "patch 0/7" mail, and once you have posted it,
> pass the Message-Id to the --reply-to parameter of your quilt command.
For --reply-to we need to pass in the file containing the introduction email?
Thanks,
Okash
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch 0/8] staging: speakup: introduce tty-based comms
` Okash Khawaja
@ ` Samuel Thibault
` Okash Khawaja
0 siblings, 1 reply; 8+ messages in thread
From: Samuel Thibault @ UTC (permalink / raw)
To: Okash Khawaja; +Cc: Speakup is a screen review system for Linux.
Okash Khawaja, on lun. 13 mars 2017 08:38:47 +0000, wrote:
> On Sun, Mar 12, 2017 at 12:42 PM, Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> > okash.khawaja@gmail.com, on dim. 12 mars 2017 12:16:44 +0000, wrote:
> >> This patchset introduces a TTY-based way for the synths to communicate
> >> with devices
> >
> > Ok, this looks good to me. Now you need to submit it. The
> > ./scripts/get_maintainer.pl script applied to the various patches gives
> > the following list of recipients:
>
> Thanks! I'll also cc Alan Cox for the first patch, as you suggested earlier.
Oh, right, he needs to be in the loop indeed.
> according to /usr/share/doc/quilt/README.MAIL:
>
> "Each message is assigned a unique Message-Id header, and all messages
> other than the introduction are made to refer to the introduction (using
> a References header) for proper message threading in mail clients."
Ok, so it should have worked.
> > So the idea would be to prepare your quilt
> > command, then write your "patch 0/7" mail, and once you have posted it,
> > pass the Message-Id to the --reply-to parameter of your quilt command.
>
> For --reply-to we need to pass in the file containing the introduction email?
I guess when using --reply-to one shouldn't provide an introduction text
at all, that'd be spurious.
Samuel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch 0/8] staging: speakup: introduce tty-based comms
` Samuel Thibault
@ ` Okash Khawaja
0 siblings, 0 replies; 8+ messages in thread
From: Okash Khawaja @ UTC (permalink / raw)
To: Samuel Thibault; +Cc: Speakup is a screen review system for Linux.
On Mon, Mar 13, 2017 at 8:43 AM, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
> Okash Khawaja, on lun. 13 mars 2017 08:38:47 +0000, wrote:
>> On Sun, Mar 12, 2017 at 12:42 PM, Samuel Thibault
>> <samuel.thibault@ens-lyon.org> wrote:
>> > okash.khawaja@gmail.com, on dim. 12 mars 2017 12:16:44 +0000, wrote:
>> >> This patchset introduces a TTY-based way for the synths to communicate
>> >> with devices
>> >
>> > Ok, this looks good to me. Now you need to submit it. The
>> > ./scripts/get_maintainer.pl script applied to the various patches gives
>> > the following list of recipients:
>>
>> Thanks! I'll also cc Alan Cox for the first patch, as you suggested earlier.
>
> Oh, right, he needs to be in the loop indeed.
>
>> according to /usr/share/doc/quilt/README.MAIL:
>>
>> "Each message is assigned a unique Message-Id header, and all messages
>> other than the introduction are made to refer to the introduction (using
>> a References header) for proper message threading in mail clients."
>
> Ok, so it should have worked.
>
>> > So the idea would be to prepare your quilt
>> > command, then write your "patch 0/7" mail, and once you have posted it,
>> > pass the Message-Id to the --reply-to parameter of your quilt command.
>>
>> For --reply-to we need to pass in the file containing the introduction email?
>
> I guess when using --reply-to one shouldn't provide an introduction text
> at all, that'd be spurious.
Of course. I mean the 0/7 email from sent folder.
But I should be able to work it out myself :)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~ UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[patch 0/8] staging: speakup: introduce tty-based comms okash.khawaja
` Okash Khawaja
` John Covici
` Samuel Thibault
` Samuel Thibault
` Okash Khawaja
` Samuel Thibault
` Okash Khawaja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).