* using system serial tty drivers
@ David
` Samuel Thibault
0 siblings, 1 reply; 3+ messages in thread
From: David @ UTC (permalink / raw)
To: speakup
The purpose of defines is that all drivers will dump the old serial stuff
eventually. Just wrappping serial_out to do one character transfers
is a performance hit big time. that is why I refactored the buffer handlers
so you can do.
while ( (bytes = synth_buffer_status(true) ) != 0) {
if (bytes < 0) {
// flush code goes here
// drain tty buffers etc. and break loop
}
// we have something to write to synth
this_write = synth_buffer_gets(my_buff, 256 );
written = write_serial(fd, my_buff, this_write);
if (written < this_write)
synth_buffer_ungets(this_write-written);
// synth is full so push back unwritten chars and wait ...
}
} // do_catchup
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: using system serial tty drivers
using system serial tty drivers David
@ ` Samuel Thibault
` Samuel Thibault
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Thibault @ UTC (permalink / raw)
To: Speakup is a screen review system for Linux.
David, on Fri 18 Nov 2016 12:02:44 -0500, wrote:
> The purpose of defines is that all drivers will dump the old serial stuff
> eventually.
Yes, but we don't want to do that without testing.
> Just wrappping serial_out to do one character transfers is a
> performance hit big time.
No. We are talking about serial ports, which are very slow anyway.
> that is why I refactored the buffer handlers
> so you can do.
Did you measure any actual performance improvement ?
A function call is at most like a few instructions, i.e. the order of a
nanosecond. On serial ports, at the very very best, characters take an
order of a microsecond to transfer.
Again, complex code is really not what you want in the end if it doesn't
bring much improvement.
Samuel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: using system serial tty drivers
` Samuel Thibault
@ ` Samuel Thibault
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Thibault @ UTC (permalink / raw)
To: Speakup is a screen review system for Linux.
Samuel Thibault, on Fri 18 Nov 2016 18:30:16 +0100, wrote:
> David, on Fri 18 Nov 2016 12:02:44 -0500, wrote:
> > The purpose of defines is that all drivers will dump the old serial stuff
> > eventually.
>
> Yes, but we don't want to do that without testing.
One thing you may not know: some drivers can only work with an ISA card,
because they poke ports outside the standard serial ports. They will
not work with the new serial access method, and that's fine, since they
don't exist as non-ISA cards.
Samuel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~ UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
using system serial tty drivers David
` Samuel Thibault
` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).