* Re: [PATCH v3 1/2] staging: speakup: reuse native hex2bin()
[not found] <1365510136-15288-1-git-send-email-andriy.shevchenko@linux.intel.com>
@ ` Samuel Thibault
[not found] ` <1365510136-15288-2-git-send-email-andriy.shevchenko@linux.intel.com>
1 sibling, 0 replies; 2+ messages in thread
From: Samuel Thibault @ UTC (permalink / raw)
To: Andy Shevchenko; +Cc: devel, Greg Kroah-Hartman, speakup
Andy Shevchenko, le Tue 09 Apr 2013 15:22:15 +0300, a écrit :
> @@ -349,21 +349,8 @@ char *spk_xlate(char *s)
> num = (*p1++)&7;
> }
> *p++ = num;
> - } else if (*p1 == 'x' &&
> - strchr(hx, p1[1]) && strchr(hx, p1[2])) {
...
> + } else if (*p1 == 'x' && !hex2bin(&num, p1 + 1, 1)) {
> + p1 += 3;
Checking it again, I realize that this does not check p1[1]!=0 and
p1[2]!=0 any more ; it has to because hex2bin does not perform the
check (and could thus erroneously dereference p1[2]).
Samuel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3 2/2] staging: speakup: fix a bug when translate octal numbers
[not found] ` <1365510136-15288-2-git-send-email-andriy.shevchenko@linux.intel.com>
@ ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ UTC (permalink / raw)
To: Andy Shevchenko; +Cc: devel, Greg Kroah-Hartman, speakup
Andy Shevchenko, le Tue 09 Apr 2013 15:22:16 +0300, a écrit :
> There are actually overflow bug and typo. And bug was never happened due to the
> typo.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Maybe reorder these two patches so this one gets applied without waiting
for another iteration of the other, if any? (they are actually
independent)
Samuel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~ UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1365510136-15288-1-git-send-email-andriy.shevchenko@linux.intel.com>
` [PATCH v3 1/2] staging: speakup: reuse native hex2bin() Samuel Thibault
[not found] ` <1365510136-15288-2-git-send-email-andriy.shevchenko@linux.intel.com>
` [PATCH v3 2/2] staging: speakup: fix a bug when translate octal numbers Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).