From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f182.google.com (mail-yw0-f182.google.com [209.85.211.182]) by speech.braille.uwo.ca (Postfix) with ESMTP id B6D2CC1A5A2 for ; Wed, 21 Apr 2010 16:10:04 -0400 (EDT) Received: by ywh12 with SMTP id 12so3740556ywh.23 for ; Wed, 21 Apr 2010 13:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:content-type; bh=vTQUWZ6Krv04YowKLvwk6tc1WU+k4gtlw/ln7hvq6io=; b=fhJUPuwCtphGovEw6v+jLmNVwm1O9i+jBY++f/TX9MDXJG6tYuoDxFXLSnSz4crqAF fL9V20Q93OHo1J8dSEzK3XdjoQXqhQOxr3XWPWgqMA0Gm29Q3k48L0qv6SDyMzA1elTr sXwu2jitFJCcvm1UCcXCjfT18ejcb4UHJ8/po= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=jIuXG8wVd7tOud4jP2SJleSWUco9Ol9nf/owsupK7prXxnMJO6ARRls5u5xPYWIokz 7BtjKlAvy4M/m6lq/WViXaAw75alcATssN556tmokw3qI3jFERCFmJ9iVMXriyLFtgLq gzyItnGG02iVVuoVWGLriQiwpBcXdXTHw88Bo= MIME-Version: 1.0 Received: by 10.100.135.7 with HTTP; Wed, 21 Apr 2010 13:09:37 -0700 (PDT) In-Reply-To: References: <4bcf1286.0a5b8d0a.2549.ffff9971@mx.google.com> Date: Wed, 21 Apr 2010 16:09:37 -0400 Received: by 10.100.50.12 with SMTP id x12mr22561412anx.217.1271880577793; Wed, 21 Apr 2010 13:09:37 -0700 (PDT) Message-ID: Subject: Re: Newbie question about punctuation From: Bill Cox To: "Speakup is a screen review system for Linux." Content-Type: multipart/mixed; boundary=001485f87c2c09415b0484c4c67d X-BeenThere: speakup@braille.uwo.ca X-Mailman-Version: 2.1.13 Precedence: list Reply-To: "Speakup is a screen review system for Linux." List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2010 20:10:05 -0000 --001485f87c2c09415b0484c4c67d Content-Type: text/plain; charset=ISO-8859-1 Hi, Chris. I'm replying on this list rather than opentts-dev, since my e-mails seem not to be coming through on opentts-dev today. I've tracked down three issues in ospeakup.c, and I've attached the output of "git diff". With these changes, ospeakup acts like espeakup, saying capital letters in a higher voice, not saying 'capital', and not reading all punctuation unless reviewing by character. This seems to be how espeakup works, and speakup users on the Vinux list have stated they prefer how espeakup works. These changes makes espeakup and ospeakup nearly equivalent. The first change in the diff is a bugfix, IMO. When ospeakup writes chartab values, it uses ALPHA for upper case letters, overwriting the default of A_CAP. I've changed it to A_CAP for uppercase characters, which enables uppercase letters to be spoken in a higher pitch. The second change causes 0 to mean no punctuation, 1 to mean some, and 2 to mean all. This seems to be the intent of the speakup code, and it makes ospeakup easier to listen to, IMO. Certainly there was a mismatch between speakup and ospeakup in that the valid range in speakup is defined to be 0-2, not 0-4. The final change is to detect that we're trying to speak a capital letter, and to call speak_string rather than say_single_character. This causes speech-dispatcher to avoid saying "capital". Alternatively, we could track down the bug that causes capital to be spoken instead of changing pitch. I'm still looking into this. Bill --001485f87c2c09415b0484c4c67d Content-Type: text/x-patch; charset=US-ASCII; name="ospeakup.patch" Content-Disposition: attachment; filename="ospeakup.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g8akuaa40 ZGlmZiAtLWdpdCBhL29zcGVha3VwLmMgYi9vc3BlYWt1cC5jCmluZGV4IDJjODEwMjMuLmYyYWMx MTkgMTAwNjQ0Ci0tLSBhL29zcGVha3VwLmMKKysrIGIvb3NwZWFrdXAuYwpAQCAtMTI5LDcgKzEy OSw3IEBAIGludCBpbml0X3NwZWFrdXBfdGFibGVzKCkKIAkJCWZwcmludGYoZnBfY2hhciwgIiVk XHRBTFBIQVxuIiwgaSk7CiAJCX0KIAkJZm9yIChpID0gJ0EnOyBpIDw9ICdaJzsgaSsrKSB7Ci0J CQlmcHJpbnRmKGZwX2NoYXIsICIlZFx0QUxQSEFcbiIsIGkpOworCQkJZnByaW50ZihmcF9jaGFy LCAiJWRcdEFfQ0FQXG4iLCBpKTsKIAkJfQogCQlmb3IgKGkgPSAxMjg7IGkgPCAyNTY7IGkrKykg ewogCQkJZnByaW50ZihmcF9jaGFyLCAiJWRcdEFMUEhBXG4iLCBpKTsKQEAgLTE2MCwxNyArMTYw LDE2IEBAIHZvaWQgcHJvY2Vzc19jb21tYW5kKGNoYXIgY29tbWFuZCwgdW5zaWduZWQgaW50IHBh cmFtLCBpbnQgcG0pCiAJY2FzZSAnYic6CQkvKiBzZXQgcHVuY3R1YXRpb24gbGV2ZWwgKi8KIAkJ c3dpdGNoIChwYXJhbSkgewogCQljYXNlIDA6Ci0JCQlMT0coNSwgIltwdW5jdHVhdGlvbiBhbGxd Iik7Ci0JCQlyZXQgPSBzcGRfc2V0X3B1bmN0dWF0aW9uKGNvbm4sIFNQRF9QVU5DVF9BTEwpOwor CQkJTE9HKDUsICJbcHVuY3R1YXRpb24gbm9uZV0iKTsKKwkJCXJldCA9IHNwZF9zZXRfcHVuY3R1 YXRpb24oY29ubiwgU1BEX1BVTkNUX05PTkUpOwogCQkJYnJlYWs7CiAJCWNhc2UgMToKLQkJY2Fz ZSAyOgogCQkJTE9HKDUsICJbcHVuY3R1YXRpb24gc29tZV0iKTsKIAkJCXJldCA9IHNwZF9zZXRf cHVuY3R1YXRpb24oY29ubiwgU1BEX1BVTkNUX1NPTUUpOwogCQkJYnJlYWs7Ci0JCWNhc2UgMzoK LQkJCUxPRyg1LCAiW3B1bmN0dWF0aW9uIG5vbmVdIik7Ci0JCQlyZXQgPSBzcGRfc2V0X3B1bmN0 dWF0aW9uKGNvbm4sIFNQRF9QVU5DVF9OT05FKTsKKwkJY2FzZSAyOgorCQkJTE9HKDUsICJbcHVu Y3R1YXRpb24gYWxsXSIpOworCQkJcmV0ID0gc3BkX3NldF9wdW5jdHVhdGlvbihjb25uLCBTUERf UFVOQ1RfQUxMKTsKIAkJCWJyZWFrOwogCQlkZWZhdWx0OgogCQkJTE9HKDEsICJFUlJPUjogSW52 YWxpZCBwdW5jdHVhdGlvbiBtb2RlISIpOwpAQCAtNDI0LDExICs0MjMsMTEgQEAgaW50IHNwZWFr KGNoYXIgKnRleHQpCiAKIAlMT0coNSwgIlRleHQgYmVmb3JlIHJlY29kaW5nOiB8JXN8IiwgdGV4 dCk7CiAKLQlpZiAocHJpbnRhYmxlcyA9PSAxKSB7CisJaWYgKHByaW50YWJsZXMgPT0gMSAmJiAh aXN1cHBlcigqY2hhcmFjdGVyKSkgewogCQl1dGY4X3RleHQgPSByZWNvZGVfdGV4dChjaGFyYWN0 ZXIpOwogCQlMT0coNSwgIlNlbmRpbmcgdG8gc3BlZWNoZCBhcyBjaGFyYWN0ZXI6IHwlc3wiLCB1 dGY4X3RleHQpOwogCQlzcGRfcmV0ID0gc2F5X3NpbmdsZV9jaGFyYWN0ZXIodXRmOF90ZXh0KTsK LQl9IGVsc2UgaWYgKHByaW50YWJsZXMgPiAxKSB7CisJfSBlbHNlIGlmIChwcmludGFibGVzID49 IDEpIHsKIAkJc3BkX3JldCA9IHNwZWFrX3N0cmluZyh0ZXh0KTsKIAl9CiAJLyogRWxzZSBwcmlu dGFibGVzIGlzIDAsIG5vdGhpbmcgdG8gZG8uICovCg== --001485f87c2c09415b0484c4c67d--