From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 4CFDB1EFAF2; Sun, 20 Aug 2017 23:33:14 -0400 (EDT) Received: from a2-out-001.smtp25.com (a2-out-001.smtp25.com [50.201.66.168]) by befuddled.reisers.ca (Postfix) with ESMTPS id 1428B1EF962 for ; Sun, 20 Aug 2017 23:33:13 -0400 (EDT) Received: from ccs.covici.com (localhost [127.0.0.1]) by ccs.covici.com (8.14.9/8.14.8) with ESMTP id v7L3X7Ce004514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 20 Aug 2017 23:33:07 -0400 Received: (from covici@localhost) by ccs.covici.com (8.14.9/8.13.7/Submit) id v7L3X6od004513; Sun, 20 Aug 2017 23:33:06 -0400 Date: Sun, 20 Aug 2017 23:33:06 -0400 Message-ID: From: John Covici To: Okash Khawaja Cc: "Speakup is a screen review system for Linux." Subject: Re: speakup-r functionality In-Reply-To: <20170820214527.GA464@sanghar> References: <20170820214527.GA464@sanghar> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Reply-To: covici@ccs.covici.com Organization: Covici Computer Systems MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SpamH-Filter: a2-out-001.smtp25.com-v7L3X8wh014532 X-SpamH-OriginatingIP: 70.109.53.110 X-MIMEDefang-Relay-ca7e395729062400c36e9cbcb508575aec105509: 70.109.53.110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2017 03:33:15 -0000 I tried the new patch, but no joy. I hope you can fix your serial synth to test. Thanks for trying. On Sun, 20 Aug 2017 17:45:27 -0400, Okash Khawaja wrote: > > Hi, > > Here's one thing I think worth trying. I have updated the patch so that > the net difference between before and after the patch is that > speakup_fake_down_arrow() is not called when inside interrupt context. > > Calling speakup_fake_down_arrow() inside interrupt causes the kernel > lock up because this itself generates same interrupt, leading to > infinite recursion. > > I didn't think this code was triggered outside of interrupt context, but > it possibly is when using a serial console - which is the only > explanation I can think of for the behaviour you've described. > > Thanks > > > --- > drivers/staging/speakup/main.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -1408,7 +1408,10 @@ static void read_all_doc(struct vc_data > cursor_track = read_all_mode; > spk_reset_index_count(0); > if (get_sentence_buf(vc, 0) == -1) { > - kbd_fakekey2(vc, RA_DOWN_ARROW); > + del_timer(&cursor_timer); > + if (!in_interrupt()) > + speakup_fake_down_arrow(); > + start_read_all_timer(vc, RA_DOWN_ARROW); > } else { > say_sentence_num(0, 0); > synth_insert_next_index(0); -- Your life is like a penny. You're going to lose it. The question is: How do you spend it? John Covici covici@ccs.covici.com