From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 7E3501F0394; Mon, 29 May 2017 08:08:50 -0400 (EDT) Received: from a2-out-001.smtp25.com (a2-out-001.smtp25.com [50.201.66.168]) by befuddled.reisers.ca (Postfix) with ESMTPS id 393EA1F0386 for ; Mon, 29 May 2017 08:08:49 -0400 (EDT) Received: from ccs.covici.com (localhost [127.0.0.1]) by ccs.covici.com (8.14.9/8.14.8) with ESMTP id v4TC8jLS024291 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 May 2017 08:08:45 -0400 Received: (from covici@localhost) by ccs.covici.com (8.14.9/8.13.7/Submit) id v4TC8jsa024289; Mon, 29 May 2017 08:08:45 -0400 Date: Mon, 29 May 2017 08:08:45 -0400 Message-ID: From: John Covici To: Okash Khawaja Cc: "Speakup is a screen review system for Linux." Subject: Re: speakup-r functionality In-Reply-To: <20170529095033.GA781@sanghar> References: <20170528204856.GA883@sanghar> <20170529095033.GA781@sanghar> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Reply-To: covici@ccs.covici.com Organization: Covici Computer Systems MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SpamH-Filter: a2-out-001.smtp25.com-v4TC8kq4004822 X-SpamH-OriginatingIP: 70.109.53.110 X-MIMEDefang-Relay-ca7e395729062400c36e9cbcb508575aec105509: 70.109.53.110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2017 12:08:50 -0000 OK, I will test as soon as I can. On Mon, 29 May 2017 05:50:33 -0400, Okash Khawaja wrote: > > On Sun, May 28, 2017 at 06:38:39PM -0400, John Covici wrote: > > I just have one question -- how did it work with the old serial i/o > > system? > In main.c, handle_cursor_read_all calls spk_get_index_count which calls > spk_ttyio_in_nowait or spk_serial_in_nowait depending on whether TTY or > old serial i/o is in use. So the difference is in spk_serial_in_nowait > as the layers above that are identical. spk_serial_in_nowait returns 0 > when there is no data on rx. spk_ttyio_in_nowait immitates that but due > to the signedness bug, it was returning 0xff instead of 0 when there > is no data. > > With the fix, now both serial i/o and TTY stacks should have same > behaviour. -- Your life is like a penny. You're going to lose it. The question is: How do you spend it? John Covici covici@ccs.covici.com