From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id BE66E1EF962; Sun, 20 Aug 2017 15:00:36 -0400 (EDT) Received: from mail0205.smtp25.com (mail0205.smtp25.com [174.37.170.205]) by befuddled.reisers.ca (Postfix) with ESMTPS id 5489E1EF114 for ; Sun, 20 Aug 2017 15:00:35 -0400 (EDT) Received: from ccs.covici.com (localhost [127.0.0.1]) by ccs.covici.com (8.14.9/8.14.8) with ESMTP id v7KJ0Wb7026939 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 20 Aug 2017 15:00:32 -0400 Received: (from covici@localhost) by ccs.covici.com (8.14.9/8.13.7/Submit) id v7KJ0WnN026938; Sun, 20 Aug 2017 15:00:32 -0400 Date: Sun, 20 Aug 2017 15:00:32 -0400 Message-ID: From: John Covici To: Okash Khawaja Cc: "Speakup is a screen review system for Linux." Subject: Re: speakup-r functionality In-Reply-To: References: <20170528204856.GA883@sanghar> <20170529095033.GA781@sanghar> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Reply-To: covici@ccs.covici.com Organization: Covici Computer Systems MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SpamH-Filter: s-out-001.smtp25.com-v7KJ0XBS020786 X-SpamH-OriginatingIP: 70.109.53.110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Aug 2017 19:00:36 -0000 I think speech dispatch/speechd-up do something different with regard to indexing -- they don't actually use index marks like a serial synth, so my guess is that it works differently. On Sun, 20 Aug 2017 13:26:50 -0400, Okash Khawaja wrote: > > Okay I tested with the file you sent and as you described, but > couldn't replicate. If it does behave differently with serial synth > then it _could_ be that another issue has been exposed by this change. > I don't have a functional serial synth which supports indexing. I will > look into fixing my doubletalk lt. > > Just to be sure, following is the patch which breaks speakup-r? > > --- > drivers/staging/speakup/main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -1408,7 +1408,8 @@ static void read_all_doc(struct vc_data > cursor_track = read_all_mode; > spk_reset_index_count(0); > if (get_sentence_buf(vc, 0) == -1) { > - kbd_fakekey2(vc, RA_DOWN_ARROW); > + del_timer(&cursor_timer); > + start_read_all_timer(vc, RA_DOWN_ARROW); > } else { > say_sentence_num(0, 0); > synth_insert_next_index(0); > > Thanks, > Okash > > On Sun, Aug 20, 2017 at 5:12 PM, John Covici wrote: > > In my latest test, it still did not work. I will send you a file to > > test with. I started at the beginning of the file, went to line 25 > > and hit control and the cursor was at line 198. Now it might work > > differently with speech dispatcher, you probably should use a serial > > synth to test. Without the speakup-r empty line fix, it does work. > > > > On Mon, 29 May 2017 05:50:33 -0400, > > Okash Khawaja wrote: > >> > >> On Sun, May 28, 2017 at 06:38:39PM -0400, John Covici wrote: > >> > I just have one question -- how did it work with the old serial i/o > >> > system? > >> In main.c, handle_cursor_read_all calls spk_get_index_count which calls > >> spk_ttyio_in_nowait or spk_serial_in_nowait depending on whether TTY or > >> old serial i/o is in use. So the difference is in spk_serial_in_nowait > >> as the layers above that are identical. spk_serial_in_nowait returns 0 > >> when there is no data on rx. spk_ttyio_in_nowait immitates that but due > >> to the signedness bug, it was returning 0xff instead of 0 when there > >> is no data. > >> > >> With the fix, now both serial i/o and TTY stacks should have same > >> behaviour. > > > > -- > > Your life is like a penny. You're going to lose it. The question is: > > How do > > you spend it? > > > > John Covici > > covici@ccs.covici.com -- Your life is like a penny. You're going to lose it. The question is: How do you spend it? John Covici covici@ccs.covici.com