From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp110.sbc.mail.mud.yahoo.com (smtp110.sbc.mail.mud.yahoo.com [68.142.198.209]) by speech.braille.uwo.ca (Postfix) with SMTP id 55322109F9 for ; Mon, 22 Jun 2009 21:26:01 -0400 (EDT) Received: (qmail 97369 invoked from network); 23 Jun 2009 01:26:00 -0000 Received: from unknown (HELO localhost) (myrowa@72.155.204.153 with plain) by smtp110.sbc.mail.mud.yahoo.com with SMTP; 23 Jun 2009 01:26:00 -0000 X-YMail-OSG: HX5ScoAVM1kkdenAqJfmwUQGHux03.1ckDyHPYGOFjW7hNVBL7UHNl7SjD_Gs5ni1AMDTBh.OPegVioA9cFd62oyeNd6hxG3KFChMgUdYl4CZtySe4X5hYQlXGLVb4YQmPsxltwfqrZ8lAn3qw7wocblqZburBOJ7rc4g.iEc5qrB0Az5UNZGXd4Cr5o7D.UGCWcqW.OJH3lKwatt.8I6lKLXVjBM5hwLEjbLmFiU.QTP2ytfQHqClswcTEcXFjEsMUOnFD725jaGoqe X-Yahoo-Newman-Property: ymail-3 Date: Mon, 22 Jun 2009 20:25:59 -0500 (CDT) From: Adam Myrow To: speakup@braille.uwo.ca Subject: speakupconf problem and fix Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII X-BeenThere: speakup@braille.uwo.ca X-Mailman-Version: 2.1.12 Precedence: list Reply-To: "Speakup is a screen review system for Linux." List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2009 01:26:01 -0000 Hi. I just updated Speakup with GIT to check out some of the changes. I found a problem with speakupconf right off. It was failing to save parameters because it was giving the "find" command invalid options. A little investigation showed that the problem was in this line of code. SAVELIST=`find . -readable -writable -type f |sed 's/..//'` The problem is, the version of find in Slackware 12.2 does not recognize the "-readable" and "-writable" options. I suspect that they are in some newer version of find. The "find --version" command gives the following on my system. GNU find version 4.2.31 Built using GNU gnulib version 2007-02-24 Features enabled: D_TYPE O_NOFOLLOW(enabled) LEAF_OPTIMISATION I quickly found the solution. I modified the problem line to look like this. SAVELIST=`find . -perm -u+rw -type f |sed 's/..//'` I believe this accomplishes the same thing as the original line, using the "-perm" flag which is a part of find on just about any Unix system in existence. Does anybody see any problem with having this change made to the GIT version of speakupconf? It is probably best to use the most portable syntax where possible to avoid future problems like this. Thanks.