From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 5F7211EFB1A; Sun, 20 Aug 2017 13:26:53 -0400 (EDT) Received: from mail-oi0-x22b.google.com (mail-oi0-x22b.google.com [IPv6:2607:f8b0:4003:c06::22b]) by befuddled.reisers.ca (Postfix) with ESMTPS id B10781EFAF2 for ; Sun, 20 Aug 2017 13:26:51 -0400 (EDT) Received: by mail-oi0-x22b.google.com with SMTP id e124so136131448oig.2 for ; Sun, 20 Aug 2017 10:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3dTY/s7zIKbf6XVa1eyuO+Obc57nrvtTV+wysgjHbTs=; b=Z+uen2eV3odql3OAsClgfT2/gy7mFfLzqKt19ZhwI53LDsYMXCayKEgy1LPIAXpgsK g9n7iq5F1f68fsJ2Tts5jEPb+6TYPLwaNh+M17zok13THmyJvt9cXVoFvNB83tvmVh0s Wz717gVR3jBSd7T+gywgJGa92LVmnTgMmmyXamajlcPppeCH2xv/bqMLzR0oxahgiVEg bhZUG1QIlj2I3z85ztx2eItDNUoQXlszUemfQEhgkvVYfcOdqzLhxkJ2+B7Q7+HdJfE4 A/SjkeIHgCVPFgHsTR3dszU9TeUUoyGsgqtpz9MpY/Y13NvhTZGLq4F3Bdp0pcpGu0EO nerg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3dTY/s7zIKbf6XVa1eyuO+Obc57nrvtTV+wysgjHbTs=; b=EPo5pd0D2OAD1BRyMNrr2+MvebKPI8YUIFN6dFczn/+D2e/3e9K3wQhd9yWxh0gtPU eKXzgB90QRTDKVgUjw9SzWq7oS867LgvDc90qyXf/L3t77U8JBzzo/OBZvSrJB71U5gD tw9mFFhb9dZN0bgqRFtcoa5J7JD6md++1+7XxqxyDQiwZPySB5FHKQNKBtoT6HnTzgWd wY0dU3D9m2PYbQU4ehYuWdPoihglIF8NROD8rDbJXtbZUJ4LZbKr4s+SnQITXejCQVlQ ZUA86BI2vRUspGPfGheOzslCI0+D+UNRQYms+XTpYizXIGArTLBpV22RguUcsHhJfbpO T7/g== X-Gm-Message-State: AHYfb5hYbe9atOtVjxL9k/KTIVKFlwrps92qvrT2FKoeMfp/qi7rn19P G7oZs+YcTh8nn2Secbp4MggXDkoML0H8 X-Received: by 10.202.179.137 with SMTP id c131mr19488972oif.298.1503250010918; Sun, 20 Aug 2017 10:26:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.26.53 with HTTP; Sun, 20 Aug 2017 10:26:50 -0700 (PDT) In-Reply-To: References: <20170528204856.GA883@sanghar> <20170529095033.GA781@sanghar> From: Okash Khawaja Date: Sun, 20 Aug 2017 18:26:50 +0100 Message-ID: Subject: Re: speakup-r functionality To: John Covici Cc: "Speakup is a screen review system for Linux." Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Aug 2017 17:26:53 -0000 Okay I tested with the file you sent and as you described, but couldn't replicate. If it does behave differently with serial synth then it _could_ be that another issue has been exposed by this change. I don't have a functional serial synth which supports indexing. I will look into fixing my doubletalk lt. Just to be sure, following is the patch which breaks speakup-r? --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/staging/speakup/main.c +++ b/drivers/staging/speakup/main.c @@ -1408,7 +1408,8 @@ static void read_all_doc(struct vc_data cursor_track = read_all_mode; spk_reset_index_count(0); if (get_sentence_buf(vc, 0) == -1) { - kbd_fakekey2(vc, RA_DOWN_ARROW); + del_timer(&cursor_timer); + start_read_all_timer(vc, RA_DOWN_ARROW); } else { say_sentence_num(0, 0); synth_insert_next_index(0); Thanks, Okash On Sun, Aug 20, 2017 at 5:12 PM, John Covici wrote: > In my latest test, it still did not work. I will send you a file to > test with. I started at the beginning of the file, went to line 25 > and hit control and the cursor was at line 198. Now it might work > differently with speech dispatcher, you probably should use a serial > synth to test. Without the speakup-r empty line fix, it does work. > > On Mon, 29 May 2017 05:50:33 -0400, > Okash Khawaja wrote: >> >> On Sun, May 28, 2017 at 06:38:39PM -0400, John Covici wrote: >> > I just have one question -- how did it work with the old serial i/o >> > system? >> In main.c, handle_cursor_read_all calls spk_get_index_count which calls >> spk_ttyio_in_nowait or spk_serial_in_nowait depending on whether TTY or >> old serial i/o is in use. So the difference is in spk_serial_in_nowait >> as the layers above that are identical. spk_serial_in_nowait returns 0 >> when there is no data on rx. spk_ttyio_in_nowait immitates that but due >> to the signedness bug, it was returning 0xff instead of 0 when there >> is no data. >> >> With the fix, now both serial i/o and TTY stacks should have same >> behaviour. > > -- > Your life is like a penny. You're going to lose it. The question is: > How do > you spend it? > > John Covici > covici@ccs.covici.com