From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 80BDC1EFDA7; Fri, 18 Nov 2016 02:07:38 -0500 (EST) Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) by befuddled.reisers.ca (Postfix) with ESMTPS id 7D4EC1EFD96 for ; Fri, 18 Nov 2016 02:07:36 -0500 (EST) Received: by mail-it0-x22d.google.com with SMTP id c20so14780150itb.0 for ; Thu, 17 Nov 2016 23:07:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc; bh=kJgNY3/K0wihVBF5JY84X1pOyShn99esXkjJeWLW8Nk=; b=IbxndZX9uOrb8j9EOh3IJT3I8M6qOHGQTAcC9R400kyMNzGMsE+YaCVcBmyC5UjuFc frAhzd9e0llTIp9Ldg6xKDlJ4yFxhvW08bxaUPNcdBzhKL3HpM1qBhnDDgxncQP879Sl TJr7yI7wGA8F4GQAxrak9F0f6FCKvgX2M8OPi7LfzDDe+uCR8cbfUlx1PHsHEYWTv1FX UChKHcq/dFxUdLiEhcP1dinVG8CbaykowSh8w3+izAflYzXsY0wP1wkqBcIjMXURlDrA Dv4q9aGB47jOJ7TaaX7Fim7RpV3BbLJ/J9AyZAS4PxA6N97KjI/krqe4qYbOcBDv+Bzh hPkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=kJgNY3/K0wihVBF5JY84X1pOyShn99esXkjJeWLW8Nk=; b=I0IHBnASELHMWjl/Q7T/EzE9GlTvzK5p3LtF74VFsUT/u9+OzA6blzrooYZvZJ3Fl8 22RUDiRGRPrbUfqxZr+RYPLhe3v2UOr4FYQAOhvTQYidFKwq3Cq2ZPBSIq+DZBcfrDMW dm+AKmsJdNoCc7DFj0mzPneUHpKvfzfBzOmsT5vX1QkWTqvzlpmU37nCCScpOWqtuY8b 4NalHFz8YIz7fj8jBkaixfdspmZGhRouuUZ1p+jHtg92ADALq+QdVc9USnX/HEkQgTFj fSF7tqpuWFYWe/G8lyg2Xihlr1kGCqL/ZMJWs9TjA3biSim4bY/UqBGohYgkahbkSM8F R0lQ== X-Gm-Message-State: AKaTC00Op322ELEHMEezpZrDs2ueXkPPRz5wvj0lEEl4zS2YuSy6b7C+YO19B+Zdd4KBPrORKGVkQkVDYXRHjg== X-Received: by 10.107.133.206 with SMTP id p75mr8387602ioi.175.1479452853637; Thu, 17 Nov 2016 23:07:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.79.25.65 with HTTP; Thu, 17 Nov 2016 23:07:33 -0800 (PST) From: Okash Khawaja Date: Fri, 18 Nov 2016 07:07:33 +0000 Message-ID: Subject: Serial: Initial refactor To: Samuel Thibault Cc: John Covici , David Borowski , "Speakup is a screen review system for Linux." X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 07:07:38 -0000 Hi Samuel, >>From previous email: "You will notice calls to spk_serial_out() in spk_do_catch_up() and spk_synth_flush(). Actually the very first step of your work could be to add a serial_out() method to drivers, which for now would be set to spk_serial_out() in all drivers, and make spk_do_catch_up() and spk_synth_flush() call the method instead of spk_serial_out(). Direct calls to spk_serial_out() within drivers could be converted into calling the method too, so that switching methods will be trivial." So I am wondering if it will be possible to restrict the changes to speakup_dummy while we test the new implementation using tty->ops->write? That means a transitional phase where we have both, the existing serial io for other drivers and new implementation for dummy driver. Or is that what you meant? Thanks, Okash