From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id CBE0E1F059B; Thu, 2 Feb 2017 19:02:14 -0500 (EST) Received: from mail-qt0-x229.google.com (mail-qt0-x229.google.com [IPv6:2607:f8b0:400d:c0d::229]) by befuddled.reisers.ca (Postfix) with ESMTPS id 093EF1F0595 for ; Thu, 2 Feb 2017 19:02:13 -0500 (EST) Received: by mail-qt0-x229.google.com with SMTP id v23so7913433qtb.0 for ; Thu, 02 Feb 2017 16:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Myq1QjcH/iZ3M6bavqDCWX7QQpBgB/OVZFFfYeHFIEU=; b=LaqHXiWj35vith+em3+Uou6l/uCOZBUeR98qX5XujYplCYBJnxB4TcU1lRLVk3rdeP 0ioY+3oYYUYXLkbrpefy90NINt+35qnF1efaY0o6qgJ/YXDi45YP3VnymeDZltOrx6Pc 0lyE/RTRwUzXm4UPgC5BXzMVHiVHthpppeR/hJDcp5/XYhYcTQRH6EXktHLpoIqp0Pkk YeBQhSUHnaMTlce3PaQskg23ma/h5Vhlsv+Fbh9mZdMArh/cDfx4O3hMvJw96uS9BmkN depNA4keIUwY0CQlit9VuCRdEf5IgzICiIgDevzgENlZwXhYaAc1zeE2cl+ZSbjhPlPu DO2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Myq1QjcH/iZ3M6bavqDCWX7QQpBgB/OVZFFfYeHFIEU=; b=XfK1rBD8GJE5eqFBnlbExpfn4Uun8Ub/9M3guWMvyXYrVheSDX6KnaR0CNra1ZzJot hEnMAO2JDaAw+mDesf6UtLSDNekSN5YvFzZbPGkPl/SRQdg9xBQsOVROZRy9El7XSb1G 9WBQxX7xqMXCZnlZZSDIJA60MuuYa+kmv9tlu9ilFMjphU/VL3yJ3cPcCpeRCC+dbrZc /FqlraxkOvJRqFKX8NvXPy1AlG2I0jH72w8tSojmo1OkfQIwa9MRMPVZv+aeM27YZIwD 8LuU4evUzG7suSsEoME0qNrA3IemXGRWsiw6wX43dHteOz0QTpfAQ32tdLGIItkz0TrF 6yCQ== X-Gm-Message-State: AIkVDXK3uMBwSoj11VwFVhDRI/499EqyghE6FbCgT9kUy4nOLpHm3BMOC1zrcCcLUP1zTecY8X7Bpb4FWy1JGg== X-Received: by 10.200.44.1 with SMTP id d1mr10463165qta.215.1486080132364; Thu, 02 Feb 2017 16:02:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.44.8 with HTTP; Thu, 2 Feb 2017 16:02:11 -0800 (PST) In-Reply-To: References: <20170124083045.GN2695@var.home> <20170126001801.GQ3119@var.home> <20170126083312.GB25343@var.home> <20170128175709.GO3304@var.home> <20170128183039.GS3304@var.home> From: Okash Khawaja Date: Fri, 3 Feb 2017 00:02:11 +0000 Message-ID: Subject: Re: Line discipline To: Samuel Thibault Cc: "Speakup is a screen review system for Linux." X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 00:02:14 -0000 On Thu, Feb 2, 2017 at 11:51 PM, Okash Khawaja wrote: > Hi, > > On Sat, Jan 28, 2017 at 6:56 PM, Okash Khawaja wrote: >> On Sat, Jan 28, 2017 at 6:30 PM, Samuel Thibault >> wrote: >>> Okash Khawaja, on Sat 28 Jan 2017 18:29:03 +0000, wrote: >>>> It's SSH into Linux VM which runs speakup_dummy, so running pseudo >>>> terminal. Should be okay? >>> >>> Yes, but then don't be surprised that speakup doesn't print anything: >>> nothing is happening on the linux text console :) You need to log into >>> the linux text console and do stuff there to get speakup to speak it. >> >> My mistake. For some reason I thought espeakup was working with my >> xterm which also uses pseudo terminal which led me to (misguided) >> belief that it should work for SSH connection too. Thanks, it's >> looking better now :) >>> >>> Samuel > > I have attached the patch which uses tty for speakup_dummy. It applies > without conflicts to 4.10.x kernel code but showed conflicts for > 4.8.6. Please note that major and minor device numbers are hard coded > as 4 and 64 inside spk_ttyio_initialise() function. I have changed > names slightly, so there is spk_ttyio_* prefix which identifies > functions related to tty-based comms. The related code is grouped > inside spk_ttyio.c file. > > I noticed that `startup` member of synth_dummy instance was set to > SYNTH_START which meant that probe function for dummy won't be called > when built into kernel image. May be I didn't understand it fully, but > for now I have changed to always be the literal 1. > > Tested dummy and also soft synth/espeakup for regressions. Both seemed > okay but I didn't fully test them. Any ideas for testing will be > useful. > > Thanks, > Okash Attaching gzipped patch due to attachment size limits on the mailing list.