From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 55D1F1EFDB8; Fri, 16 Dec 2016 01:52:51 -0500 (EST) Received: from mail-qk0-x229.google.com (mail-qk0-x229.google.com [IPv6:2607:f8b0:400d:c09::229]) by befuddled.reisers.ca (Postfix) with ESMTPS id 538F11EFDAD for ; Fri, 16 Dec 2016 01:52:49 -0500 (EST) Received: by mail-qk0-x229.google.com with SMTP id t184so28020586qkd.0 for ; Thu, 15 Dec 2016 22:52:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=T8phIMQojttuh3FRHI8sugAitTaJQ9T5wapvmCZzACE=; b=d+IBSVeB1M2l/T80NwIY7v68c1mYj0AXAogo0eCPeDwvOwgy3cbh0TqyhtR7NHyNJq c5xCRLRgoYZUq7DTMIa1YPavlosqG5VleSAmKmNKW2EvIaf8sBiZVSA3gfz7+0DeHAqQ p4Lqe+5iVxa8b53Oio1+eS+txZwnj3Twmji+0RY9qopaHq0TDzceFmpDYY0KnxymHoyk itGr47s6S4p/CcCMR1gDjTEUPGkBH7FYgIrMSyiIdHNR6idXlRj0v5+cYq1mbwYUm3hY JUE5CSPYgBMdQnLLzMY4VfoCXNlTDCCKZ7YSrXuawdQIMa0k+DNB4sSF9rK0dIRFCzaO vr5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=T8phIMQojttuh3FRHI8sugAitTaJQ9T5wapvmCZzACE=; b=KYuAaGTbt10lJd2yFD7A51+yai4UNgBIb/vME1JyRjGx8TgCDvz5WWWF4ewhqxqzIo 1RrwvCfG52LLDi+UJcf3tOrlx/fkMjlqNR1HDD8SaS8JS0Cjax0TQXZmKID3429jD5Ws 3HbktsSbhwRQ17hGSzBRBRmV5aK9/MSA9nxzJrX+1xrBY3ldhixg8nEkLl/mfnqLidXT Fq1xeFpXOKOVwP4tvpGKfW1f4WhiVcSQgxEdKyIoWV0Sw1yZ5C88VRegJH5D2bzATgU8 65ZejfS0QTvHwwBsGsuWBZqSfA1Qahap7MFz22HyKTyVuBfTF9Jf2oknya9iqJq2S1kh 82sw== X-Gm-Message-State: AIkVDXJjl1p+5OVFEj3kNfCMD835itJi9G7uU2h6NG7JXVvpxGTtnBjIqskbJxabXxM7XICb9opYVEVi/7u0pQ== X-Received: by 10.55.39.88 with SMTP id n85mr1211733qkn.244.1481871167382; Thu, 15 Dec 2016 22:52:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.48.33 with HTTP; Thu, 15 Dec 2016 22:52:46 -0800 (PST) In-Reply-To: References: <20161121223631.GY2755@var.home> <20161123145659.GB3012@var.bordeaux.inria.fr> <20161211202244.GU3884@var.home> From: Okash Khawaja Date: Fri, 16 Dec 2016 06:52:46 +0000 Message-ID: Subject: Re: Line discipline To: Samuel Thibault Cc: "Speakup is a screen review system for Linux." X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2016 06:52:51 -0000 Also, the exit function speakup_test_cleanup() needs to contain code from your module's exit function, if it is used as a kernel module, rather than being built into kernel image. On Thu, Dec 15, 2016 at 10:17 PM, Okash Khawaja wrote: > Hi, > > I quickly put together speakup-test.c and compiled it into the kernel > binary. Loading the kernel outputs test messages to ttyS0 and logs the > event in kernel log. "got tty ffff8fcfe74b0000" message appears at time > 3.258357. Both speakup-test.c and dmesg.log are attached. N_SPEAKUP is 26 > in /include/uapi/linux/tty.h. > > Also tested this as kernel module which seemed to work fine too. That > required EXPORT_SYMBOL(tty_set_ldisc); in /drivers/tty/tty_ldisc.c. Will be > able to spend more time over the weekend. > > Thanks! > Okash > > On Sun, Dec 11, 2016 at 10:33 PM, Okash Khawaja > wrote: > >> Hi Samuel, >> >> That's great. Let me get back on this soon as I can. >> >> Thanks, >> Okash >> >> > On 11 Dec 2016, at 20:22, Samuel Thibault >> wrote: >> > >> > Hello, >> > >> > Okash Khawaja, on Sun 27 Nov 2016 20:41:50 +0000, wrote: >> >> Thanks for explanation. I have not been able to work on this recently >> - pulled >> >> away for something urgent. As soon as it's over, I'll be back on it. >> Probably >> >> third week of December. >> > >> > I've taken some time to have a look, I have attached the result: >> > >> > - tty_NULL is a patch against the kernel to make tty functions accept >> > being called with filp == NULL >> > - mymodule.tgz is a dumb module which opens ttyS0 (major 4 minor 64), >> > and writes to it through the tty write operation. >> > >> > So this, combined with your work on the line discipline, should get >> > something working, and opening other serial ports (e.g. ttyUSB0) is a >> > matter of changing the major/minor pair (e.g. 188, 0). >> > >> > Samuel >> > >> > >> > >