From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id EDC9F1EFD44; Sat, 19 Nov 2016 17:54:42 -0500 (EST) Received: from mail-qt0-x244.google.com (mail-qt0-x244.google.com [IPv6:2607:f8b0:400d:c0d::244]) by befuddled.reisers.ca (Postfix) with ESMTPS id D3BE41EFD27 for ; Sat, 19 Nov 2016 17:54:39 -0500 (EST) Received: by mail-qt0-x244.google.com with SMTP id n34so21904823qtb.3 for ; Sat, 19 Nov 2016 14:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=O19E5JKRzxSwmY1D0y8Gc82sWluVLV1nZzLKbsrvyjw=; b=Ag5NFLQTeF/obenZor5AQ0DTvtiwUKsa4Zyt1PQmnnEBbZ6bBdpKSecMiXmiEC7z4h o5WgJzYuLZ62G8HqwyauON7vONE+MjK7ZPeb6aEzb4uJZ0wkACoGke5D9MZ88S451jZe y9hNe1AEsqyDh6dJBzCUfsLTMD4tFltyD2i7gLpg4KwtAh1tdRVLph6NbjJeIoCU6Tg8 +YKN6BLrkiDASxgmu+3tQvi19tL9a/vw5973EbHdMHu72tbEaZNjZZJINWKduwo059fx VnNP0Y9mqLyf9cnoPeygjiAFcoWkr28CMNZ1PFcxXVqFPOMv+yxyPYMRDRh22Ibx5gYH UdlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=O19E5JKRzxSwmY1D0y8Gc82sWluVLV1nZzLKbsrvyjw=; b=THJLQ1GHp6ewaeJIPK4lDLoMA0VUxfRO4Q7LG3XBaHhoHrdUUXOJTrOYSiZVnSx2+H kpuuBUTWnPuw1xNcc2wFPvnaJRovvNRXab1ZInWanVHBTfPFojl91XA3Ryq9mU8Uoief 1QWxgofK4CuqA6zSarJLaKB+oIfdNThf0BkHDlJcjWDzBJ+YD0jkK22J55MCdSI3BbY/ s2+0Ui3L2Ezkh4uMia2Uglxh4ULMmrln+3asgKcHRGFTvfbNnljKu1UH0vyxIO4xcU96 SPblAwUEBT1V4qBHTFt6+q+TqNO6VA5AIadV8XKeVBg67NFm3A8aAsltdyj3e+m+zih0 BcCA== X-Gm-Message-State: AKaTC009ddj8y3IBkOp44OacJe/QWXmyf+oCnnzd/Z8et/GvM7XdYkA5uEEmEIH6NBsMHyEuxKlgsjfHp7n3iQ== X-Received: by 10.200.37.52 with SMTP id 49mr3895018qtm.240.1479596078488; Sat, 19 Nov 2016 14:54:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.37.179 with HTTP; Sat, 19 Nov 2016 14:54:38 -0800 (PST) In-Reply-To: <20161119220328.GH3422@var.home> References: <20161119183514.GA2077@sanghar> <20161119220328.GH3422@var.home> From: Okash Khawaja Date: Sat, 19 Nov 2016 22:54:38 +0000 Message-ID: Subject: Re: [PATCH v2 0/4] staging: speakup: refactor to make room for serial comms changes To: Samuel Thibault Cc: kirk@reisers.ca, David Borowski , Christopher Brannon , William Hubbs , Greg KH , "Speakup is a screen review system for Linux." , devel@driverdev.osuosl.org X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2016 22:54:43 -0000 On Sat, Nov 19, 2016 at 10:03 PM, Samuel Thibault < samuel.thibault@ens-lyon.org> wrote: > Hello, > > Just looking over the patch, it looks good. I don't think it needs to be > split in 4 pieces though, I'd say merge patches 1, 3, and 4 together, > where patch 3 would be modified to make dummy use spk_serial_out too, to > get a patch which does just one complete thing: make serial_out a > method. > > Then you'll have other patches introducing spk_serial_out_tty and making > some drivers use it. > > Also note that as Greg said, the patches you have just submitted do > not really make sense alone. I don't know if staging people feel like > applying them while it's only pavement for future work. If so, then > good; otherwise, then fine too: it's good that you have sent them so > that we could check how they look like, I just wanted to let you know > that they might not get applied yet, just because one may want to see > the future patches before applying what you have done so far. > Yeah makes sense. Perhaps should have asked around beforehand, as my experience for anything other than trivial patches is non-existent. > BTW, I have been looking at functions again, we'll also need > a spk_synth_immediate_tty that drivers can use instead of > spk_synth_immediate, in addition to the _in, and _out functions. For now > (i.e. to make the dummy driver work, and probably a few simple more), > the tty versions for _out and _synth_immediate will probably enough to > get something working and commitable to the main kernel. > Good point, will add tty version of spk_synth_immediate. > > Also, as mentioned, now the hard work is getting to open the tty from > the kernel :) That'd be in a spk_tty_synth_probe function that drivers > would use instead of spk_serial_synth_probe. > > Samuel > Thanks, Okash