From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 4DC9B1F07C7; Sun, 26 Feb 2017 04:53:17 -0500 (EST) Received: from mail-qk0-x229.google.com (mail-qk0-x229.google.com [IPv6:2607:f8b0:400d:c09::229]) by befuddled.reisers.ca (Postfix) with ESMTPS id 719D91F07C0 for ; Sun, 26 Feb 2017 04:53:14 -0500 (EST) Received: by mail-qk0-x229.google.com with SMTP id s186so60679366qkb.1 for ; Sun, 26 Feb 2017 01:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6fpKNHCkpK50toXEW89TB5R/3IUHKMheBUZ5jjW3lng=; b=jDqAHNbqMhsgs18OPcHneoG/ulwMhfvluY9oU06oyFlWWV3VxQi3zVzJasOViU/4iQ KQCZrgEyN1Eyauah3xSNanqY1NPiXJq0OTgKkOBUrIkBBW7F3rwJ3ugvi+AnKCLCvWXq P8zBveEVU9ZStfcakmQt1DULM7Z/HfLsiPrNcQ0oq6h5A9MEJhkZzO5NVO+oJphrt+pv 3QklLr/5k89hZJuDVoGyHFSyxfhJ0NanlTkOu3rb36bkQEU1F+fdOrF+LZTXNT3hNwLD fR8qSalpTQzZ5wyaQFSmHAEVJQyoN9DeYGY8TueiTm9WSBlVoiwFx5//mTMpQhnbiH70 Y/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6fpKNHCkpK50toXEW89TB5R/3IUHKMheBUZ5jjW3lng=; b=NuhzxGtVNrswgJtqzEeoMKu0hpIpKY76bZzeZB10W43iyk0rnKd+OFExBralJfbma7 Hl0w63HFXF9NsUB2TnRDAekxQOmbY8VCcZs3iLF2dCAikn2Cg/q9tpRkcsIaPpHFZXfM DjDEKPP3E/N2wXO8L32souO4+RNqGIWQmPhsGPS1NUImgV0vqqoXeIk7z6srSA8JSs9D WkDsdR5rZp+MIACRUS1/+xcGQk5M0BgXTpe2MWGsCyDu0IsgKcsxtOSy6gAXcV9UwyL0 kwnv87UJRLXOFS4bkkHbKaj9fenVCQyitx4NtmiIeLsIBgMG3vFS13JG/ynsmb8NgXDm vxww== X-Gm-Message-State: AMke39kT2YeeVyxrrqXj6/MYv+Sn3hDnSTQkE4FPFIblPcJzCi9QUVsfTR2FZKZY3Rl78pzx21DDjIgX6tB+9A== X-Received: by 10.237.37.197 with SMTP id y5mr10264313qtc.168.1488102791544; Sun, 26 Feb 2017 01:53:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.44.193 with HTTP; Sun, 26 Feb 2017 01:53:11 -0800 (PST) In-Reply-To: <20170226033811.63lezgzqpkrq5chj@var.youpi.perso.aquilenet.fr> References: <20170225191801.GA4482@sanghar> <20170226033811.63lezgzqpkrq5chj@var.youpi.perso.aquilenet.fr> From: Okash Khawaja Date: Sun, 26 Feb 2017 09:53:11 +0000 Message-ID: Subject: Re: Read this first :) Re: [patch 0/6] staging: speakup: Introduce TTY-based comms To: Samuel Thibault Cc: "Speakup is a screen review system for Linux." Content-Type: text/plain; charset=UTF-8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2017 09:53:17 -0000 Hi, Thanks for the quick feedback and this helpful summary :) On Sun, Feb 26, 2017 at 3:38 AM, Samuel Thibault wrote: > So, just a last mail, which could actually be read first :) > > First, I notice that it took you 12 minutes to send the patch series. > This shows that you are not using quilt to do this :) Really, take the > time to look up how "quilt mail" works, and notably its --send option, > it will save you an awful lot of time (notably since I'm asking to > split the series is rather small patches, which is preferred thing when > pushing to Linux) Quilt has been very helpful in preparing the patches. Sending was tedious without it but today got quilt mail --send working which is great. > > I also gave a lot of information, most of which are mostly notes for > later. I'd say that the priority is this: > > - work on the comments I made on the actual code (patch splitting, > migrating ltlk, not migrating dectlk, moving spk_synth_immediate, > exporting spk_stop_serial_interrupt, taking the ser parameter into > account, renaming spk_ttyio_immediate to spk_ttyio_synth_immediate, > and putting serial_out in a separate spk_io_ops structure) > > - maybe post a last round of patches here, so I make a last review > before we push to linux-kernel > > - then we push to linux-kernel and get flames :) > > - in the meanwhile, you can work on adding a "char *dev" synth parameter > which would replace the "ser" parameter, and writing a function which > translates it into an MKDEV(major,minor) pair (first implement it for > "ttyS*", then for "ttyUSB*", etc.) Sounds good. Should this be done before pushing to linux-kernel? > > - hopefully at that point we can get that series commited mainstream, > even if we only migrate the trivial drivers. > > - then we can work on the other drivers as my mail series suggests. > > Samuel