From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 4BE8C1F0A30; Tue, 24 Jan 2017 01:16:56 -0500 (EST) Received: from mail-qt0-x235.google.com (mail-qt0-x235.google.com [IPv6:2607:f8b0:400d:c0d::235]) by befuddled.reisers.ca (Postfix) with ESMTPS id 415A71F0A2D for ; Tue, 24 Jan 2017 01:16:54 -0500 (EST) Received: by mail-qt0-x235.google.com with SMTP id v23so165289301qtb.0 for ; Mon, 23 Jan 2017 22:16:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kk5vhd9dyuQUyyzJ+sGJCQW/2Vf7E/7s/dxam0M67QM=; b=rltjwb+FU3NSKvhzlLwH27AuSXlEgzkbPb6F6FRUhtOUcDcP+2J8uyzEFBqO2EPjmE qMjgkWwjhJGkfCCc8vlIYW6AE3qfuZaWaUMGNmrR8G/6KOqy7rY4rLDXAVK80qYyr0tO QkH8LisX5T3ckRN8XFWMKvlNXQCBvHrXhpRASz99rgYx1dpcwzmccoWaQn7ukvaU2cDH yS3LM0wR2AMWfWvjXW3USXcFudES7HMGIhYHcnojUF/VIyKC7+PMX0kGNJzkaBDglMYj i+ODXsAD0x17oHcgT+QgtHcjKKMG92QHUf5PwFw6edLAVqDRX+6wLq3aPzXSeAscUn7j 20Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kk5vhd9dyuQUyyzJ+sGJCQW/2Vf7E/7s/dxam0M67QM=; b=BbfUfl5VD5uXJK+3hLWNfwJMyKW7ye3rbCiZFtBDir/cuezA8+GN/iOw8Fuc7VpNJw vazzSst5dD6PqIJDemrLZnghLcQPgYkQglTg5kfup2qf3EGydWbVKAz6ze2KPMqtMNXb cyGcWxc7Fi8wPyg1Pe4aXs590vMIJNxo2Y6+G0Y9cnJM8q2LWbo2kvsXBMaUQ6LVuFSu w1mMNVJBt6RzWeqzsXG9ivz0yxuIvLpR23pPL8RFnODApwbMOND+B6ddw+4QEtw8aiBv km/TP0ly2+JDGUr2tXubGOJlV/achqh5YElEC9ucUfCdtv91GIS0hQxNkqgXDsVWd3mU 9RSQ== X-Gm-Message-State: AIkVDXI8g2YMxxvZn3IDHA0PETVQCsZJXL4JoTAyT0fOcYh2DTMtwvEqaA8fjkitP+TLSU7izx9rUCz+b4FXPg== X-Received: by 10.55.89.196 with SMTP id n187mr17499082qkb.17.1485238607109; Mon, 23 Jan 2017 22:16:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.44.8 with HTTP; Mon, 23 Jan 2017 22:16:46 -0800 (PST) In-Reply-To: References: <20161220010836.GN2895@var.home> From: Okash Khawaja Date: Tue, 24 Jan 2017 06:16:46 +0000 Message-ID: Subject: Re: Line discipline To: Samuel Thibault Cc: "Speakup is a screen review system for Linux." X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 06:16:56 -0000 Hi Samuel, Combined the refactor changes with your tty code to test speakup_dummy. It seems okay except for problem when unloading speakup.ko - it is in use so can't be unloaded. I have just got this so investigating it. One question. Using your code, we can obtain tty, cache it and use it directly for all subsequent writes. Why then use ldisc? Thanks, Okash On Mon, Dec 26, 2016 at 4:02 PM, Okash Khawaja wrote: > Thanks. It seems relatively straightforward from here on. Job switch > combined with an unexpectedly busy holiday period means that I haven't been > able to work on this recently. Things will settle next week when I will be > back on it. > > Merry Christmas and happy new year! > > Okash > > > On 20 Dec 2016, at 01:08, Samuel Thibault > wrote: > > > > Okash Khawaja, on Sun 18 Dec 2016 11:24:11 +0000, wrote: > >> Now I see three items to address, listed below in no particular order. > >> > >> 1. Supplying major and minor dev numbers, instead of hardcoding. > > > > This could be a mere module parameter string that a function turns into > > major/minor. Not a big deal :) > > > >> 2. Integrating the changes into speakup_dummy and testing it. > > > > Yep! > > > >> 3. Strategy for kernel patch. Do we try to have it accepted? Not sure > if there > >> is a standard way of addressing it. > > > > It will never be accepted before step 2. is done. In the end we'll want > > to get it accepted, sure, but we have to make speakup able to use it > > first, otherwise the kernel patch will be rejected. > > > > Thanks! > > Samuel >