From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 289271EF800; Mon, 28 Aug 2017 16:28:16 -0400 (EDT) Received: from mail-oi0-x233.google.com (mail-oi0-x233.google.com [IPv6:2607:f8b0:4003:c06::233]) by befuddled.reisers.ca (Postfix) with ESMTPS id 986721EF3CC for ; Mon, 28 Aug 2017 16:28:14 -0400 (EDT) Received: by mail-oi0-x233.google.com with SMTP id w10so12971358oie.1 for ; Mon, 28 Aug 2017 13:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hwgYoFLMmvgq9mhb8UnIxqW+bKDG65reoW0D8RubROE=; b=kyHnl0i1tjg50rNq1rS2/T3QoBSAhGnbu8ji5djvsM1u4jaiErnUQgRlNhgYk+RxZD txQEcK+dJPpYAk8u1p5pFpeAWSfw6quJvqMPARnJsCnO6ZFX77uF7JjadDixqZP6ftqE S6BDFwbXCcEZGxLUbZTxkVuGUL5mxv4FAdj8dybzZs5l7wSbvlBjJaoDgyYXtG0qZAb6 Vj9RhS+Ne9v0jTO+xcruTDZckFhrB8VBxf2/FiH3eOg2c4Yp2yCi4OujnY/r7jtpY7WX q/T3b4VTtkUT6R8+ovoAHvi+rjeLRLny3eoDPFg/ZqURByIm2P/j20AhYpBIpiaW37Tf +zCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hwgYoFLMmvgq9mhb8UnIxqW+bKDG65reoW0D8RubROE=; b=itCHG3JRYx41Tofvtm6zEWvBceEH74YNb4dRyPn/zOuTQWxuJkvRmj4w/1fFMXDLe3 hkbSekjAAl7XymQQaX3I5RCrFqLh9VhXtBIdukdSdJObEDJyzOTS29rbr43dOHx2e2fB +ongcSH4v2ohJZA6J+8skMHoQ9eAv7Z26FJnE61ME/DMae+Rj2LtkPZ+ZXx6vUNwoOR6 wO39e/ahgzqvhY8tK0vtXWx1gpj1RpQGHQ+fQ45yFkZWFFb/yVpj0p6EyHgZ7gK6ClF8 /xWYqmgVJzj8Y+0tkyGWJG557TFndB3lyyQ+wHjR2NC2lcviBW9rcYTbf3Czvgi9l230 4JLg== X-Gm-Message-State: AHYfb5hTbasU8Sdphjkg0Vx84dHAYJVK06i7Rn7KhB5NejVw4Lf4mBmp RxVTfAcQSMwwVSJEm0fzUhGl5Ed/sA== X-Received: by 10.202.117.129 with SMTP id q123mr1579538oic.4.1503952086102; Mon, 28 Aug 2017 13:28:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.21.59 with HTTP; Mon, 28 Aug 2017 13:28:05 -0700 (PDT) Received: by 10.157.21.59 with HTTP; Mon, 28 Aug 2017 13:28:05 -0700 (PDT) In-Reply-To: <20170828201723.psjxmbm2ahzi5c5d@var.youpi.perso.aquilenet.fr> References: <20170826171513.GA644@sanghar> <20170828201723.psjxmbm2ahzi5c5d@var.youpi.perso.aquilenet.fr> From: Okash Khawaja Date: Mon, 28 Aug 2017 21:28:05 +0100 Message-ID: Subject: Re: [patch] staging: speakup: fix speakup-r empty line lockup To: Samuel Thibault Cc: John Covici , Christopher Brannon , "Speakup is a screen review system for Linux." X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2017 20:28:16 -0000 On 28 Aug 2017 9:17 pm, "Samuel Thibault" wrote: Hello, Okash Khawaja, on sam. 26 ao=C3=BBt 2017 18:15:13 +0100, wrote: > +static volatile int in_keyboard_notifier =3D 0; Why "volatile"? Is the read from read_all_doc really done by another thread? The presence of volatile is usually very bad sign: either there is proper synchronization, and volatile is useless, or there isn't, and volatile just makes code work by luck sometimes only (even if that means "most of the time", that's not "all the time" :) ) Thanks for explaining! And indeed it's not read from a different thread so it's not needed there at all. I'll fix that.