From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id CE1521F0AB3; Sun, 26 Feb 2017 10:11:58 -0500 (EST) Received: from mail-qk0-x22c.google.com (mail-qk0-x22c.google.com [IPv6:2607:f8b0:400d:c09::22c]) by befuddled.reisers.ca (Postfix) with ESMTPS id 78B651F0AB0 for ; Sun, 26 Feb 2017 10:11:57 -0500 (EST) Received: by mail-qk0-x22c.google.com with SMTP id n127so65540915qkf.0 for ; Sun, 26 Feb 2017 07:11:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ltSAaO2Pj5p3EAzjZpnBtO/cob3ntJO/ynQnMaMkIdM=; b=pDPYYhQFeJy5ZhIU4pewoEwrpNymNzx3pMA/CQMcZ+7a1hd+vSNkp9QOpIOf4WyTVi IGj5A5fis+xaqJBjmdeG6tTYbwnXv85flnSVvqICORC8bs6WVa6OC7/s+vTa98bTzCl3 WMw2i57dJ88jpEHX7J4bIapJ6346SxAHbiRqkJ13rjuQo2i+timCSObJ7z0cyf1kQuQZ KtxwO3R4kGOrbD0FZqeRBt3xqIeuVDb+MOQDwIUa8h1dfNTmOjERk5D+lYsWUC6jOBjZ CbuxPbhfde/DtUzYjCjUUqwfWBClV2rDrRnqeEEIHJbVUpuXnpgVvtdHkZb5x2TZSODB tIug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ltSAaO2Pj5p3EAzjZpnBtO/cob3ntJO/ynQnMaMkIdM=; b=NyUwl3thwR80A6tvuVMTK5IGyFDf7HahEGwCJtBJpAdkEcEqyFBVykGlgps/FhMuCG HhRj1rZQxwQKcuGcpOgEyFwzhCisUib0QXbD5i4iO1EMdUuu84O9fERIPFgC0bSBa9H9 hjdxme+7KAOduIjEAJMWX58xzodhcpI5mM7d5qTDeWLsJSdlum2V6VMYgJ6KbdDdohIq ZewXN9fGA7stCoYdC6exu67S2NgqdybfT859fjco8NsoEkogf1O+Pn4qiaxqOeiHkvL1 M97+tH8VzV1OJmQJQasaU+EmxUtwAYWW0li7IEVi/A6WDilwxcPqGd8svO+tcySrW9Un eJcQ== X-Gm-Message-State: AMke39nlH2OAnfDRH5GHvKM/xZdEJ7PT6hFaOq6ZEoHEmNrkik2PjdTKIIFaiPLCtYJY5iFnXVCZB45bJqxlAA== X-Received: by 10.55.89.196 with SMTP id n187mr11342166qkb.17.1488121914989; Sun, 26 Feb 2017 07:11:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.44.193 with HTTP; Sun, 26 Feb 2017 07:11:54 -0800 (PST) In-Reply-To: <20170225230334.dzkz5ytcjwcwavok@var.youpi.perso.aquilenet.fr> References: <20170225192358.GA4499@sanghar> <20170225192526.GA4507@sanghar> <20170225230334.dzkz5ytcjwcwavok@var.youpi.perso.aquilenet.fr> From: Okash Khawaja Date: Sun, 26 Feb 2017 15:11:54 +0000 Message-ID: Subject: Re: [patch 3/6] staging: speakup: refactor spk_stop_serial_interrupt To: Samuel Thibault Cc: "speakup@linux-speakup.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2017 15:11:58 -0000 Hi, > On 25 Feb 2017, at 23:03, Samuel Thibault = wrote: > > Okash Khawaja, on sam. 25 f=C3=A9vr. 2017 19:25:26 +0000, wrote: >> This moves call to spk_stop_serial_interrupt() function out of synth_rel= ease() >> and into release() method of specific spk_synth instances. > > Did you try to compile this as a module? It seems this is missing an > EXPORT_SYMBOL_GPL line for modules to be able to call it. It should need EXPORT_SYMBOL_GPL for other synths to compile as modules but I don't get a linker warning when compiling them as modules. Am I missing something here? > > I'm now having a try, will report later.