From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 651F61F0A78; Sun, 26 Feb 2017 14:16:38 -0500 (EST) Received: from mail-qk0-x233.google.com (mail-qk0-x233.google.com [IPv6:2607:f8b0:400d:c09::233]) by befuddled.reisers.ca (Postfix) with ESMTPS id D9A201F0866 for ; Sun, 26 Feb 2017 14:16:36 -0500 (EST) Received: by mail-qk0-x233.google.com with SMTP id s186so69798391qkb.1 for ; Sun, 26 Feb 2017 11:16:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TG31wLr21NS+e9vLFb02qfk5qk5iLcyrh8Q8xWqZd8E=; b=d8EvORNMMSSmAgS+M6X+t3efJcaRON04aZHPfrrOLPvPKIIMTSw6HUyCODfY9Hx6oG PKKWAjhLUonP43DGRkZTwJo8hEDEYtFQo0v4y15M1wIYjgfzDixzGbVIkkZJzjhkC+VF j4E9HCU1HRKdbWk9nTmKReK1xpmj9WbhP2N3DVDbTIyoBlZzz1UgA3XASExetaoVmNHw JBLkSBFCcAGx8o4qT4CcfheBvOsjVtsPvG1WZS3UBH//mnmPYGT9nu5pRYjU4I0gA1G6 TGTg/kdVyGsqCrEqOmiM9dYb7m5DHVcr5KLk73hsjsHckmyLppn9asu/qKdIrI7L5ip+ iRlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TG31wLr21NS+e9vLFb02qfk5qk5iLcyrh8Q8xWqZd8E=; b=qSCmaRVfk3uosvdUoxOyIU+X3MNS/0gIxtRwwpiXl0XtCygQGCQZVlNHwaGopuEj7E MU6vw+1UNoDDsJ1L9JqUchiAd0rv7NFsh7++d31gj/A7+ilZ2XeZxVVBvAjA8myPGtZj DccAQtn35gTOXojGKytRxwQWWBEg7duzWmBLreqwlxmParu3Ida/0pMyExPgNozJ7EHZ zTD8i2cYtaadt303K2U/15FGdWtU7PKpSxK46jzEUjx6k+EqVlDYLVtg9a/aS38ls1tM dTV/xZC/0JULXWztNIpbMGlQsAkJ6PNSSxZ8kWeNLebD8p7he9WdNTg9VGiDBXAwTqDW EPyQ== X-Gm-Message-State: AMke39mXltj9ecuchFUeQscz5bKmS5N7nxOJOohe2oyy2EkXDIfNgVAgfYop1Nz4t25x5ITOLGa6HdXWW6ApVw== X-Received: by 10.237.38.65 with SMTP id z59mr5052407qtc.215.1488136595329; Sun, 26 Feb 2017 11:16:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.44.193 with HTTP; Sun, 26 Feb 2017 11:16:35 -0800 (PST) In-Reply-To: <20170226032700.usg7anl44pcwxi6c@var.youpi.perso.aquilenet.fr> References: <20170225192132.GA4492@sanghar> <20170225192358.GA4499@sanghar> <20170226032700.usg7anl44pcwxi6c@var.youpi.perso.aquilenet.fr> From: Okash Khawaja Date: Sun, 26 Feb 2017 19:16:35 +0000 Message-ID: Subject: Re: [patch 2/6] staging: speakup: Add serial_out method To: Samuel Thibault Cc: "Speakup is a screen review system for Linux." Content-Type: text/plain; charset=UTF-8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2017 19:16:38 -0000 On Sun, Feb 26, 2017 at 3:27 AM, Samuel Thibault wrote: > So I sent a lot of mails :) > > A lot of them are asking to add yet more methods. I'm starting thinking > that it's tedious to change that in each and every driver, which is kind > of dumb anyway since it's just the same everywhere. > > So I'd say before doing all that stuff, rework what we thought about > adding methods: instead of adding spk_serial_out directly in struct > spk_synth > > - in spk_types.h, just before struct spk_synth, define > > struct spk_io_ops { > int (*serial_out)(struct spk_synth *synth, const char ch); > } Along the way, thinking of renaming serial_out to synth_out - agnostic of actual mechanism: serial or ttyio.