From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id AAD551F08F0; Sat, 28 Jan 2017 13:29:10 -0500 (EST) Received: from mail-qt0-x235.google.com (mail-qt0-x235.google.com [IPv6:2607:f8b0:400d:c0d::235]) by befuddled.reisers.ca (Postfix) with ESMTPS id 5F6B51F08EC for ; Sat, 28 Jan 2017 13:29:09 -0500 (EST) Received: by mail-qt0-x235.google.com with SMTP id k15so174146317qtg.3 for ; Sat, 28 Jan 2017 10:29:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=o1pC6RlgHdmgYBRBihiwC2qXiahZUpKYMw7K2+IZg9I=; b=d0bsMCmGwzKlZlhc8EveH1zk6IbMF5tXIvZSsoLK3y/Gr9y1ognWoH150DCWVRJk73 CT5jYugj738lt+gKzfStUe2K9B0+Bcar9iOjT0kXakATf+yy3jsvUazaE18iL77ujB3T GP9ftyCqzDKQBUwT4RHXF4s+sUv0wZeDhL82HlNrIEBJ0OMxpf2U53v0ZXkRs2xwnjv/ 8VgqtfnJOW4/9JV//LXSKeNQi2VcEmliK1/rnzazYBRws42kzmWhZ7QCH5Ci6fngZpT0 8sef/tXAO4Iroazc+aj848dzqM7G3WiU0XueLS+ahTkpNTFv79ynM8IEL2bgVDZI/uL9 4ZpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=o1pC6RlgHdmgYBRBihiwC2qXiahZUpKYMw7K2+IZg9I=; b=A7V4Ga0x0fKIk+kYWsSNkBb3oQHQ4J7ClubuDj8+ZOaZ1i+1rfKbvTNHuYnUP12rkO ZD0cUSGPlbLyZfo0W0eluQLGxKtWA1+qVtg33sxuDVCXsYZqKqVq0ujdUBWmjTBFcgnJ kor9mgFr4P3MiyC8sAqu+WoCFTxdhb62cb4W0mgdMglaehwW2tevRBXxVd8tZJvK5Alx NO71eUvmfw0IF8Qz2LFV3cW0CHuz/jNcxxC6PdWgroyiusShRv8qnvXwmzV3GgzMwwFT JXeuBuoXIjYducEj0SKAKWMBiOkja4NPkjSCbTbJNOlPlukeSSxSdLzUsDGwtiRm0Oju 7BWg== X-Gm-Message-State: AIkVDXIQriiTGHDkODqD6WZqsWzIRDlJDZhWfU6RrfhOdpkaQJY0VrPIK0R9tXk21k6YZjH9G2YzYUH0l8t1gA== X-Received: by 10.200.44.1 with SMTP id d1mr13247964qta.215.1485628143958; Sat, 28 Jan 2017 10:29:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.44.8 with HTTP; Sat, 28 Jan 2017 10:29:03 -0800 (PST) In-Reply-To: <20170128175709.GO3304@var.home> References: <20161220010836.GN2895@var.home> <20170124083045.GN2695@var.home> <20170126001801.GQ3119@var.home> <20170126083312.GB25343@var.home> <20170128175709.GO3304@var.home> From: Okash Khawaja Date: Sat, 28 Jan 2017 18:29:03 +0000 Message-ID: Subject: Re: Line discipline To: Samuel Thibault Cc: "Speakup is a screen review system for Linux." Content-Type: text/plain; charset=UTF-8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2017 18:29:10 -0000 On Sat, Jan 28, 2017 at 5:57 PM, Samuel Thibault wrote: > Okash Khawaja, on Sat 28 Jan 2017 17:49:01 +0000, wrote: >> Added tty_ldisc_release() which resolved the problem. > > Ok, good. > >> Also added tty_ldisc_flush() before tty_ldisc_release(). > > I don't think it's really needed since the user is asking for speakup to > go away anyway, but it shouldn't hurt. > >> Wouldn't it be safer to add those functions before tty_unlock()? > > See callers of these, they don't lock the tty. > >> The only output I get from speakup_dummy is: >> >> Speakup >> RATE 8 >> PITCH 8 >> VOL 8 >> TONE 8 >> Dummy found > > But are you working on the linux text console? It's SSH into Linux VM which runs speakup_dummy, so running pseudo terminal. Should be okay? > > Samuel