From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id A251D1EFDA7; Mon, 21 Nov 2016 05:30:46 -0500 (EST) Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by befuddled.reisers.ca (Postfix) with ESMTPS id DDACE1EFD4D for ; Mon, 21 Nov 2016 05:30:44 -0500 (EST) Received: by mail-wm0-x244.google.com with SMTP id m203so551252wma.3 for ; Mon, 21 Nov 2016 02:30:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=OqlR+lbsWg+TH3/yGXOF7Z5Sa66C05xbbPTqhToPQ78=; b=xsgtpOo1h8BTEU4wfvD4/sZhRaiANZtzh1PCrvCfw5IZMEKqjS71+KQ5RRygRKYVHr p3aNcSY9TKIC+6mS3znjMP5+pTgCUIeU/krCf7Di6rTfkz7dUNCiX+pweo7zW/mhwPtM RqaQ6HE7jicJSq+Nvo77oVCMPJQmU9Dh55W1sJwlEgYRW/RmPssOuTDaCWFDmiaMLY4A 1Ry95O3e5fO2ddeu+MLiKosMtubEsrenHnSov7t6M8splWRukTiEsAsZgJd48LI19IPW hIBfSasv9j2vJCS8HnLhPPOD1LHlY81fDbg5AyHA663gaOCSI7iv7yzIEmR6BhO64luI EJBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=OqlR+lbsWg+TH3/yGXOF7Z5Sa66C05xbbPTqhToPQ78=; b=J3hLzbQyeZ9/3AwAKNQGr8L0hwniMSMvceVzFOqCJj25XuM+w2QvisnrRIfD8upa6W SeCkbO47+m93PEAD7Qm/lpOfmch4VYS3DkQkGLbLMU/JZzJ1GnlGhoSa7B/JNVPEGjP1 bX6PJC/WuXmyrShWRGZWQSGczvAqfuzpnG4ehxLObWWzjNl52wVd/nfcFR4RqNSTVXYT GoZ6SV/kZ3SLBUu4C+EhGYWlH7Kf+bvrYalnmrd1GnI/JfTZkXXJ+/Of+OiUBDJLP1QJ ZtNNniXpCXJ2iHaMKMfAtQBu+DrzqQBKMumnBUtnxSWeBNj+4BpuF7ihdYGwskj/NmXZ OWcw== X-Gm-Message-State: AKaTC02T3io+jzS3U6tDh6Ay9/qRljb9/6flZEmqKxSNEZFeOnzNB5umSgsv5D5PZBAhRg== X-Received: by 10.28.185.203 with SMTP id j194mr13294536wmf.73.1479724238013; Mon, 21 Nov 2016 02:30:38 -0800 (PST) Received: from [10.67.112.211] (94.197.120.56.threembb.co.uk. [94.197.120.56]) by smtp.gmail.com with ESMTPSA id yg1sm24144205wjb.12.2016.11.21.02.30.37 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Nov 2016 02:30:37 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2 0/4] staging: speakup: refactor to make room for serial comms changes From: Okash Khawaja X-Mailer: iPhone Mail (11A501) In-Reply-To: <20161121100520.GA22858@kroah.com> Date: Mon, 21 Nov 2016 10:30:37 +0000 Cc: Samuel Thibault , "devel@driverdev.osuosl.org" , "kirk@reisers.ca" , "david.a.borowski@gmail.com" , "speakup@linux-speakup.org" , "chris@the-brannons.com" Content-Transfer-Encoding: 7bit Message-Id: <966647AD-D150-4FB7-8EB0-058FCA42C63D@gmail.com> References: <20161119183514.GA2077@sanghar> <20161119220328.GH3422@var.home> <20161121100520.GA22858@kroah.com> To: Greg KH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 10:30:46 -0000 > On 21 Nov 2016, at 10:05, Greg KH wrote: > >> On Sat, Nov 19, 2016 at 11:03:28PM +0100, Samuel Thibault wrote: >> Hello, >> >> Just looking over the patch, it looks good. I don't think it needs to be >> split in 4 pieces though, I'd say merge patches 1, 3, and 4 together, >> where patch 3 would be modified to make dummy use spk_serial_out too, to >> get a patch which does just one complete thing: make serial_out a >> method. >> >> Then you'll have other patches introducing spk_serial_out_tty and making >> some drivers use it. >> >> Also note that as Greg said, the patches you have just submitted do >> not really make sense alone. I don't know if staging people feel like >> applying them while it's only pavement for future work. If so, then >> good; otherwise, then fine too: it's good that you have sent them so >> that we could check how they look like, I just wanted to let you know >> that they might not get applied yet, just because one may want to see >> the future patches before applying what you have done so far. > > I would like to see the full patch series that uses these changes as > right now these patches do nothing on their own, so I don't want to > apply them. > > thanks, > > greg k-h Sure, will send complete patch set. Thanks, Okash