From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id B30E61EF6B4; Thu, 18 Jul 2013 12:04:44 -0400 (EDT) Received: from hurricane.the-brannons.com (hurricane.the-brannons.com [64.62.188.119]) by befuddled.reisers.ca (Postfix) with ESMTP id 377481EF56F for ; Thu, 18 Jul 2013 12:04:44 -0400 (EDT) Received: from localhost (unknown [IPv6:2602:4b:af3c:ae00:12bf:48ff:fe7c:5584]) by hurricane.the-brannons.com (Postfix) with ESMTPSA id D9103787C5 for ; Thu, 18 Jul 2013 09:06:10 -0700 (PDT) From: Chris Brannon To: "Speakup is a screen review system for Linux." Subject: Re: OT: kernel oops References: <0d30e6e5-261e-47e0-b5da-2ce5fe6bad24@default> Date: Thu, 18 Jul 2013 09:04:41 -0700 In-Reply-To: <0d30e6e5-261e-47e0-b5da-2ce5fe6bad24@default> (Don Raikes's message of "Wed, 17 Jul 2013 23:55:50 -0700 (PDT)") Message-ID: <87mwpjx3ae.fsf@mushroom.PK5001Z> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: "Speakup is a screen review system for Linux." List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jul 2013 16:04:44 -0000 Don Raikes writes: > The section of code that is having problems looks like this: *SNIP* > if (copy_from_user(&tbuf, buf, count)) This line is your problem. You are passing a pointer-to-pointer-to-character (char **) as the first argument to copy_from_user, but you should be passing char * instead. So ditch the ampersand, and all will be right with the world! I could give you a thorough explanation of why this is failing, if you like, but to make a long story short, this line of code is smashing the stack! I'm always happy to help. -- Chris