From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 934821EF218; Thu, 13 Aug 2015 05:20:30 -0400 (EDT) Received: from dragnet.batsupport.com (dragnet.batsupport.com [176.9.155.71]) by befuddled.reisers.ca (Postfix) with ESMTPS id 628AC1EF20D for ; Thu, 13 Aug 2015 05:20:29 -0400 (EDT) Received: from [192.168.0.133] (ip98-176-22-138.sd.sd.cox.net [98.176.22.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: bats@batsupport.com) by dragnet.batsupport.com (Postfix) with ESMTPSA id 0522D1F00231 for ; Thu, 13 Aug 2015 02:20:22 -0700 (PDT) Subject: Re: Code style fixes for speakup kernel driver To: "Speakup is a screen review system for Linux." References: <87fv3ocj3l.fsf@hp.cfotr.com> From: Tony Baechler Organization: Baechler Access Technology Services Message-ID: <55CC6154.6000109@baechler.net> Date: Thu, 13 Aug 2015 02:20:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <87fv3ocj3l.fsf@hp.cfotr.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2015 09:20:30 -0000 Hi, Yes, this is the correct list for Speakup development. Someone can correct me on this, but I don't think any major changes have been done to Speakup in years. One thing which would be really helpful is if you could please find a way to get serial synthesizers to work in kernels after 2.6.32 without locking up the machine. On both 3.19 and 4.0, loading the speakup_dectlk module locks up the system every time. Apparently there are ways to fix this, but they also involve patches and it would be better if the patches were not necessary. I am not a programmer, but I don't think this would be too hard to fix. Others can post on the specific code changes or you can search the Speakup list archives. Your help with this would be very appreciated. On 8/12/2015 2:06 PM, Aleksei wrote: > I'm working on euduplula challenge (It is a series of programming > exercises for amateur linux kernel developers). As an exercise i > decided to improve driver for speakup. First I'm going to fix checkpatch > warnings in driver. > > In attachment you can find a patch that fixes two types of warning: > WARNING: Block comments use a trailing */ on a separate line > WARNING: Block comments use * on subsequent lines > > I hope with your guidance i can improve speakup driver a bit.