From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 2A1E91EFDDB; Fri, 18 Nov 2016 07:47:08 -0500 (EST) Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) by befuddled.reisers.ca (Postfix) with ESMTPS id B41AB1EFDD2 for ; Fri, 18 Nov 2016 07:47:06 -0500 (EST) Received: by mail-wm0-x236.google.com with SMTP id f82so35501408wmf.1 for ; Fri, 18 Nov 2016 04:47:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5BFvAa4KoWgR5G1UWjb0S8yTC6ZeTrkSMJquKcRCrAc=; b=ANrXlTY+m4mceHY2vI78VpNsIf40dHfbCFFWkkzokixPpKctgoYb7RVJB1a8L9I1YK n19lyjXCBYpAAy9rWKKqLsPKrDD0GJHRw2kIZ1PHf1VBXqHM8Dpgyl3760LRMJfOUfqi uwzQItWqMtOi8hzCaRFVxovGFVoqIbkj0zjHUcv3z1Qy5uxZ59Bv0AQRV6WszPKB8NUz xIA2CECtm3ZUOVCs3hHao6rNsnDLmfxu3HEuFlj9NApE++BJjqHXro9JZ+N5ZSRkth4A u1C4sGrENU0qVy43q9M1wVieFoGT3q8vpYw7A1KX3G5cVUQo50QVAOD6ed8TyD5tOto3 /Utw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5BFvAa4KoWgR5G1UWjb0S8yTC6ZeTrkSMJquKcRCrAc=; b=eWWUsS/JDSrrBNpW5TwbXGtE5U5eCcMLQ9yh6I4QWZRUOy2Y+lM9Y1D17/6uuZ1z3o 0nmvm6/87RQmJWnFRFbPhgXGyIVC087v8emhYgjmUjnFaoPprUZqHRw4oDNKOtH8x50j HzzQdKWyMylbS/y1/YaTAHvEXjEa88q89EH0MQbPHfA9QVOq+vk472yvCZ6TdqtvOB/K 7uNm90yrVjZSF4YS4TKIQAcPEWU+HIv9iER3j01RzGipvMNE/7iodzH2ou7nig6uaBSA W9Qmxu0694OHrJBXGsPgJLLHuKRNkKh4subHWHscEAPVZtHm8WZTK7JQfOYVMajdmIpM VIOg== X-Gm-Message-State: ABUngvflCZB6//8eMJ6td16JZBitJu2NJwMXr0KRiQSHGkYIVNLuylC92pNcbXa1nISMMw== X-Received: by 10.28.22.193 with SMTP id 184mr10519735wmw.100.1479473217310; Fri, 18 Nov 2016 04:46:57 -0800 (PST) Received: from [10.97.107.80] (94.197.120.92.threembb.co.uk. [94.197.120.92]) by smtp.gmail.com with ESMTPSA id f10sm8669855wjl.28.2016.11.18.04.46.56 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 18 Nov 2016 04:46:56 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Serial: Initial refactor From: Okash Khawaja X-Mailer: iPhone Mail (11A501) In-Reply-To: <20161118123917.GC8282@var.labri.fr> Date: Fri, 18 Nov 2016 12:46:58 +0000 Cc: John Covici , David Borowski , "Speakup is a screen review system for Linux." Content-Transfer-Encoding: quoted-printable Message-Id: <26E394E8-5AD1-415B-8194-D28D2A2C2EB0@gmail.com> References: <20161118074407.GA6256@var.labri.fr> <20161118123917.GC8282@var.labri.fr> To: Samuel Thibault X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 12:47:08 -0000 Got it, thanks > On 18 Nov 2016, at 12:39, Samuel Thibault w= rote: >=20 > Okash Khawaja, on Fri 18 Nov 2016 09:20:08 +0000, wrote: >> Cool. So we start with spk_serial_out() by replacing it with a wrapper wh= erever >> it is used in speakup_dummy? >=20 > By replacing it with calling serial_out method, i.e. call synth->serial_ou= t. > And in all drivers for now, use spk_serial_out for that method. >=20 > Then you can write an spk_serial_out2 which just calls spk_serial_out, > and make the dummy driver use that for the serial_out method instead of > spk_serial_out. >=20 >> - add spk_synth_flush2() which is same as spk_synth_flush() but calls >> spk_serial_out2() instead >> - add spk_do_catch_up2() which is same as spk_do_catch_up() but calls >> spk_serial_out2() instead >=20 > No, we don't want to define new functions for these, just make them call > the serial_out of the synth. >=20 > Samuel