From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id 7FBA11EF741; Fri, 26 Feb 2016 19:34:45 -0500 (EST) Received: from mail0131.smtp25.com (mail0131.smtp25.com [75.126.84.131]) by befuddled.reisers.ca (Postfix) with ESMTPS id A252B1EF245 for ; Fri, 26 Feb 2016 19:34:43 -0500 (EST) Received: from ccs.covici.com (localhost [127.0.0.1]) by ccs.covici.com (8.14.9/8.14.8) with ESMTP id u1R0YUhK002594 for ; Fri, 26 Feb 2016 19:34:30 -0500 From: covici@ccs.covici.com To: "Speakup is a screen review system for Linux." Subject: Re: Help with serial synths in 4.X kernels In-reply-to: <20160226014122.GN3291@var.home> References: <56CC626F.90700@baechler.net> <497.1456239922@ccs.covici.com> <20160226014122.GN3291@var.home> Comments: In-reply-to Samuel Thibault message dated "Fri, 26 Feb 2016 02:41:22 +0100." X-Mailer: MH-E 8.5; nmh 1.6; GNU Emacs 25.1.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2592.1456533270.1@ccs.covici.com> Content-Transfer-Encoding: quoted-printable Date: Fri, 26 Feb 2016 19:34:30 -0500 Message-ID: <2593.1456533270@ccs.covici.com> X-SpamH-OriginatingIP: 70.109.53.110 X-SpamH-Filter: d-out-001.smtp25.com-u1R0YUmM012432 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Feb 2016 00:34:45 -0000 But even with your patch, serial port access is not available with speakup. Also, if you set 8250.nr_uarts=3D0 what happens to other serial ports you may need for modems, or other applications? Samuel Thibault wrote: > Hello, > = > covici@ccs.covici.com, on Tue 23 Feb 2016 10:05:22 -0500, wrote: > > Do you have the serialio.c patched to comment out the return null in > > around line 42? > = > Just wondering... > = > Is it known that passing > = > 8250.nr_uarts=3D0 > = > as a kernel command-line parameter has actually the same effect? It'll > just prevent the normal serial driver from taking the ports, and thus > speakup will not have any trouble accessing them. > = > About the patches I have sent to the linux kernel mailing list, only the > attached one is needed to fix serial port access. > = > About proper serial port access, somebody from the Outreachy intern > program is currently having a look. > = > Samuel > Subject: [PATCH] Staging: speakup: Fix getting port information > = > Commit f79b0d9c223c ("staging: speakup: Fixed warning > instead of ") broke the port information in the speakup > driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included, > and no other header includes asm/serial.h. > = > We here make sure serialio.c does get the arch-specific definition of > SERIAL_PORT_DFNS from asm/serial.h, if any. > = > Along the way, this makes sure that we do have information for the > requested serial port number (index) > = > Signed-off-by: Samuel Thibault > Fixes: f79b0d9c223c ("staging: speakup: Fixed warning i= nstead of ") > = > --- a/drivers/staging/speakup/serialio.c > +++ b/drivers/staging/speakup/serialio.c > @@ -6,6 +6,11 @@ > #include "spk_priv.h" > #include "serialio.h" > = > +#include > +/* WARNING: Do not change this to without testing tha= t > + * SERIAL_PORT_DFNS does get defined to the appropriate value. */ > +#include > + > #ifndef SERIAL_PORT_DFNS > #define SERIAL_PORT_DFNS > #endif > @@ -23,9 +28,15 @@ const struct old_serial_port *spk_serial > int baud =3D 9600, quot =3D 0; > unsigned int cval =3D 0; > int cflag =3D CREAD | HUPCL | CLOCAL | B9600 | CS8; > - const struct old_serial_port *ser =3D rs_table + index; > + const struct old_serial_port *ser; > int err; > = > + if (index >=3D ARRAY_SIZE(rs_table)) { > + pr_info("no port info for ttyS%d\n", index); > + return NULL; > + } > + ser =3D rs_table + index; > + > /* Divisor, bytesize and parity */ > quot =3D ser->baud_base / baud; > cval =3D cflag & (CSIZE | CSTOPB); > _______________________________________________ > Speakup mailing list > Speakup@linux-speakup.org > http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup -- = Your life is like a penny. You're going to lose it. The question is: How do you spend it? John Covici covici@ccs.covici.com