From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by befuddled.reisers.ca (Postfix, from userid 65534) id B4DB21EFD68; Thu, 14 Mar 2019 11:43:09 -0400 (EDT) Authentication-Results: befuddled.reisers.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ubIC+cFW"; dkim-atps=neutral Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by befuddled.reisers.ca (Postfix) with ESMTPS id 2CA1F1EFD46 for ; Thu, 14 Mar 2019 11:43:07 -0400 (EDT) Received: by mail-wr1-x430.google.com with SMTP id g12so6386593wrm.5 for ; Thu, 14 Mar 2019 08:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZbiuLi+PiX5HTQ6XE0vVsutybEi8wyzJx2rHCmen2ZY=; b=ubIC+cFWPFhH668NPKM/c3a4B9Xqpe7twWkY+CngI82AV2rQFQpkVy9s7ONa//Dhty B0RXo3yonFj+g8tssNjyXTXZ0Ay77ejt9fmIZM5iJje3tbe4H20hTNUbxUgGPDgzAQj2 EWYi5KyMZI3do71dyT8XmjiQ+rET11kk4n8+/skIei3DL+XicGtk//oLx+OE3AHxj/ah zY2ZhhUOi2OJSJvMN4DYqUC7hJIKLrsm7TTPkco4EG5EdeKClf/kCQg1W6df6ns4aHCD BXLY9JC0Yq/YkH4ziQI26OI1+MK9zcw4/fv9MdmdYMEtHv6kh2OcoZI7CRTPEBOdR+0d VRjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZbiuLi+PiX5HTQ6XE0vVsutybEi8wyzJx2rHCmen2ZY=; b=NgwWvenmK6QVBc+MtfwfwMBIyUJo6LMnoEPfD2psL1jc7yBnZODvkspVn4oQw4X+KF i9WTOc/NbR1hOTmviIYIdx7YdHsn3aoTG65TqAjAejqzVg5l7NDttF0pAArxrfq02d7f 9KCQNI/8j8wn7njVp4tm5r0qSa2WIE40KwZMcDb5njVDjPyclIQaHExE2iDDnBSXPB+C Yy7NtpzAp9vAaCIcmvngBQf7rnvF8lwt9Hn+srUPr6htuJVXHuyiA/TDwzk4aLMjDta0 pbELibh1F2SjHDngITl+7/3zTz+YhMcgfrpkoYK8XQKeGUaUKuKuzNU85yS2Ik7EFXv8 5tvw== X-Gm-Message-State: APjAAAVNlODEcW9hYh5YLdkpBPyKbUgmj5CrwszqyOSHkgHi5aIzAVA+ kZfH0OD6d6clv6GDBUcE+Lc= X-Google-Smtp-Source: APXvYqzhZ8FQCMlBnYBtiOjFdW4mDFtY0ZDuo17WxD3w9QERu3fgJZEo8LEuht/SfyCBQPC+Egm8eA== X-Received: by 2002:adf:a382:: with SMTP id l2mr22703940wrb.79.1552578185031; Thu, 14 Mar 2019 08:43:05 -0700 (PDT) Received: from narunkot ([94.11.212.65]) by smtp.gmail.com with ESMTPSA id v2sm3566064wme.29.2019.03.14.08.43.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 14 Mar 2019 08:43:04 -0700 (PDT) Date: Thu, 14 Mar 2019 15:43:03 +0000 From: Okash Khawaja To: Samuel Thibault Cc: speakup@linux-speakup.org, William Hubbs Subject: Re: TODO file Message-ID: <20190314154303.0ca2f45d@narunkot> In-Reply-To: <20190314122447.rn2mr47n3rpebbrp@function> References: <20190312202652.1e386ddf@narunkot> <20190312220915.qgtag5vezpaouoxp@function> <20190314110726.3bcc7bcf@narunkot> <20190314122447.rn2mr47n3rpebbrp@function> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 X-BeenThere: speakup@linux-speakup.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Speakup is a screen review system for Linux." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 15:43:10 -0000 On Thu, 14 Mar 2019 13:24:47 +0100 Samuel Thibault wrote: > Okash Khawaja, le jeu. 14 mars 2019 11:07:26 +0000, a ecrit: > > I can't find any reference to in_atomic() in speakup code. > > According to "Atomic context and kernel API design" [1] lwn > > article, in_atomic() started being phased out of general kernel > > code around 2.6.26. I guess this commit removed remaining > > references to in_atomic: d7500135802c "Staging: speakup: Move > > pasting into a work item". Is there any more work to be done for > > this? > > It seems there is no more indeed. > > > Also can someone give a bit of a background or pointers regarding > > moving kobjects: > > > > "The kobjects may have to move to a more proper place in /sys. The > > discussion on lkml resulted to putting speech synthesizers in the > > "speech" class, and the speakup screen reader itself into > > /sys/class/vtconsole/vtcon0/speakup, the nasty path being handled by > > userland tools." > > I don't remember the discussion. I'm not sure what is best. Moving > synthesizers to a speech class and the screen reader to vtconsole > makes sense technically, less so in terms of users (and the userland > tools then have to adapt to the new path). I'd say try to find the > discussions where the location was discussed, to check whether this > is really wanted by kernel developers, otherwise I'd stay leave it > where it is and focus on items which are more useful. > > Actually, perhaps the only item that remains for getting out of > staging/ is the selection duplication. Perhaps it is time to check > with Greg what he sees needs to be done. Perhaps only codestyle > remains at this point? (getting out of staging is an important goal, > both for settling the driver, but also for getting included in > distributions which build only mainline drivers) That sounds good. I'll start a thread with Greg and see where we go. Thanks very much. Okash